[PR #6291] [CLOSED] Cockroachdb #23284

New Issue

Closed

opened 2026-05-16 05:54:36 -05:00 by GiteaMirror · 0 comments

GiteaMirror commented 2026-05-16 05:54:36 -05:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/6291
Author: @haras-unicorn
Created: 9/14/2025
Status: ❌ Closed

Base: main ← Head: cockroachdb

---

📝 Commits (2)

• 8665d39 flake
• de632fa cockroachdb

📊 Changes

124 files changed (+1405 additions, -147 deletions)

View changed files

📝 .env.template (+7 -0)
➕ .envrc (+2 -0)
📝 .github/workflows/build.yml (+25 -28)
📝 .gitignore (+3 -0)
➕ .helix/languages.toml (+56 -0)
📝 .pre-commit-config.yaml (+59 -47)
📝 Cargo.toml (+106 -18)
📝 build.rs (+4 -1)
📝 docker/Dockerfile.alpine (+1 -1)
📝 docker/Dockerfile.debian (+1 -1)
📝 docker/Dockerfile.j2 (+2 -2)
➕ flake.lock (+60 -0)
➕ flake.nix (+55 -0)
➕ migrations/cockroachdb/2019-09-12-100000_create_tables/down.sql (+13 -0)
➕ migrations/cockroachdb/2019-09-12-100000_create_tables/up.sql (+121 -0)
➕ migrations/cockroachdb/2019-09-16-150000_fix_attachments/down.sql (+26 -0)
➕ migrations/cockroachdb/2019-09-16-150000_fix_attachments/up.sql (+27 -0)
➕ migrations/cockroachdb/2019-10-10-083032_add_column_to_twofactor/down.sql (+0 -0)
➕ migrations/cockroachdb/2019-10-10-083032_add_column_to_twofactor/up.sql (+1 -0)
➕ migrations/cockroachdb/2019-11-17-011009_add_email_verification/down.sql (+1 -0)

...and 80 more files

📄 Description

Trying cockroachdb again...

This time adding it as a feature with its own migrations and schema.

It's basically the same as postgres only with the difference of patches to migrations and the DATABASE_URL having to start with cockroach or cockroachdb.

I also added a nix flake and helix configuration which i use for development - hope you don't mind.

Creating a draft for now because I couldn't get playwright tests up and running because of this bit of weirdness:

[+] Running 1/1
 ! Playwright Warning pull access denied for playwright_oidc_playwright, repository ...                     1.3s 
Compose can now delegate builds to bake for better performance.
 To do so, set COMPOSE_BAKE=true.
[+] Building 8.4s (6/14)                                                                          docker:default
 => [Playwright internal] load build definition from Dockerfile                                             0.0s
 => => transferring dockerfile: 1.20kB                                                                      0.0s
 => [Playwright internal] load metadata for docker.io/library/debian:bookworm-slim                          0.7s
 => [Playwright internal] load .dockerignore                                                                0.0s
 => => transferring context: 2B                                                                             0.0s
 => [Playwright internal] load build context                                                                0.0s
 => => transferring context: 1.44kB                                                                         0.0s
 => CACHED [Playwright  1/10] FROM docker.io/library/debian:bookworm-slim@sha256:df52e55e3361a81ac1bead266  0.0s
 => ERROR [Playwright  2/10] RUN apt-get update     && apt-get install -y ca-certificates curl     && curl  7.7s
------                                                                                                           
 > [Playwright  2/10] RUN apt-get update     && apt-get install -y ca-certificates curl     && curl -fsSL https://download.docker.com/linux/debian/gpg -o /etc/apt/keyrings/docker.asc     && chmod a+r /etc/apt/keyrings/docker.asc     && echo "deb [signed-by=/etc/apt/keyrings/docker.asc] https://download.docker.com/linux/debian bookworm stable" | tee /etc/apt/sources.list.d/docker.list     && apt-get update     && apt-get install -y --no-install-recommends         containerd.io         docker-buildx-plugin         docker-ce         docker-ce-cli         docker-compose-plugin         git         libmariadb-dev-compat         libpq5         nodejs         npm         openssl     && rm -rf /var/lib/apt/lists/*:
0.233 Ign:1 http://deb.debian.org/debian bookworm InRelease
0.298 Ign:2 http://deb.debian.org/debian bookworm-updates InRelease
0.377 Ign:3 http://deb.debian.org/debian-security bookworm-security InRelease
1.291 Ign:1 http://deb.debian.org/debian bookworm InRelease
1.354 Ign:2 http://deb.debian.org/debian bookworm-updates InRelease
1.437 Ign:3 http://deb.debian.org/debian-security bookworm-security InRelease
3.351 Ign:1 http://deb.debian.org/debian bookworm InRelease
3.411 Ign:2 http://deb.debian.org/debian bookworm-updates InRelease
3.496 Ign:3 http://deb.debian.org/debian-security bookworm-security InRelease
7.428 Err:1 http://deb.debian.org/debian bookworm InRelease
7.428   Temporary failure resolving 'deb.debian.org'
7.517 Err:2 http://deb.debian.org/debian bookworm-updates InRelease
7.517   Temporary failure resolving 'deb.debian.org'
7.606 Err:3 http://deb.debian.org/debian-security bookworm-security InRelease
7.606   Temporary failure resolving 'deb.debian.org'
7.609 Reading package lists...
7.617 W: Failed to fetch http://deb.debian.org/debian/dists/bookworm/InRelease  Temporary failure resolving 'deb.debian.org'
7.617 W: Failed to fetch http://deb.debian.org/debian/dists/bookworm-updates/InRelease  Temporary failure resolving 'deb.debian.org'
7.617 W: Failed to fetch http://deb.debian.org/debian-security/dists/bookworm-security/InRelease  Temporary failure resolving 'deb.debian.org'
7.617 W: Some index files failed to download. They have been ignored, or old ones used instead.
7.626 Reading package lists...
7.633 Building dependency tree...
7.633 Reading state information...
7.634 Package ca-certificates is not available, but is referred to by another package.
7.634 This may mean that the package is missing, has been obsoleted, or
7.634 is only available from another source
7.634 
7.634 E: Package 'ca-certificates' has no installation candidate
7.634 E: Unable to locate package curl
------
failed to solve: process "/bin/bash -o pipefail -c apt-get update     && apt-get install -y ca-certificates curl     && curl -fsSL https://download.docker.com/linux/debian/gpg -o /etc/apt/keyrings/docker.asc     && chmod a+r /etc/apt/keyrings/docker.asc     && echo \"deb [signed-by=/etc/apt/keyrings/docker.asc] https://download.docker.com/linux/debian bookworm stable\" | tee /etc/apt/sources.list.d/docker.list     && apt-get update     && apt-get install -y --no-install-recommends         containerd.io         docker-buildx-plugin         docker-ce         docker-ce-cli         docker-compose-plugin         git         libmariadb-dev-compat         libpq5         nodejs         npm         openssl     && rm -rf /var/lib/apt/lists/*" did not complete successfully: exit code: 100

If someone knows what I'm doing wrong, info would be much appreciated :).

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/6291 **Author:** [@haras-unicorn](https://github.com/haras-unicorn) **Created:** 9/14/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `cockroachdb` --- ### 📝 Commits (2) - [`8665d39`](https://github.com/dani-garcia/vaultwarden/commit/8665d3994184c0441a9d9a897b14162abe687501) flake - [`de632fa`](https://github.com/dani-garcia/vaultwarden/commit/de632facc8b9376110d2f81d49f4866b1a0b2459) cockroachdb ### 📊 Changes **124 files changed** (+1405 additions, -147 deletions) <details> <summary>View changed files</summary> 📝 `.env.template` (+7 -0) ➕ `.envrc` (+2 -0) 📝 `.github/workflows/build.yml` (+25 -28) 📝 `.gitignore` (+3 -0) ➕ `.helix/languages.toml` (+56 -0) 📝 `.pre-commit-config.yaml` (+59 -47) 📝 `Cargo.toml` (+106 -18) 📝 `build.rs` (+4 -1) 📝 `docker/Dockerfile.alpine` (+1 -1) 📝 `docker/Dockerfile.debian` (+1 -1) 📝 `docker/Dockerfile.j2` (+2 -2) ➕ `flake.lock` (+60 -0) ➕ `flake.nix` (+55 -0) ➕ `migrations/cockroachdb/2019-09-12-100000_create_tables/down.sql` (+13 -0) ➕ `migrations/cockroachdb/2019-09-12-100000_create_tables/up.sql` (+121 -0) ➕ `migrations/cockroachdb/2019-09-16-150000_fix_attachments/down.sql` (+26 -0) ➕ `migrations/cockroachdb/2019-09-16-150000_fix_attachments/up.sql` (+27 -0) ➕ `migrations/cockroachdb/2019-10-10-083032_add_column_to_twofactor/down.sql` (+0 -0) ➕ `migrations/cockroachdb/2019-10-10-083032_add_column_to_twofactor/up.sql` (+1 -0) ➕ `migrations/cockroachdb/2019-11-17-011009_add_email_verification/down.sql` (+1 -0) _...and 80 more files_ </details> ### 📄 Description Trying cockroachdb again... This time adding it as a feature with its own migrations and schema. It's basically the same as postgres only with the difference of patches to migrations and the DATABASE_URL having to start with cockroach or cockroachdb. I also added a nix flake and helix configuration which i use for development - hope you don't mind. Creating a draft for now because I couldn't get playwright tests up and running because of this bit of weirdness: ```text [+] Running 1/1 ! Playwright Warning pull access denied for playwright_oidc_playwright, repository ... 1.3s Compose can now delegate builds to bake for better performance. To do so, set COMPOSE_BAKE=true. [+] Building 8.4s (6/14) docker:default => [Playwright internal] load build definition from Dockerfile 0.0s => => transferring dockerfile: 1.20kB 0.0s => [Playwright internal] load metadata for docker.io/library/debian:bookworm-slim 0.7s => [Playwright internal] load .dockerignore 0.0s => => transferring context: 2B 0.0s => [Playwright internal] load build context 0.0s => => transferring context: 1.44kB 0.0s => CACHED [Playwright 1/10] FROM docker.io/library/debian:bookworm-slim@sha256:df52e55e3361a81ac1bead266 0.0s => ERROR [Playwright 2/10] RUN apt-get update && apt-get install -y ca-certificates curl && curl 7.7s ------ > [Playwright 2/10] RUN apt-get update && apt-get install -y ca-certificates curl && curl -fsSL https://download.docker.com/linux/debian/gpg -o /etc/apt/keyrings/docker.asc && chmod a+r /etc/apt/keyrings/docker.asc && echo "deb [signed-by=/etc/apt/keyrings/docker.asc] https://download.docker.com/linux/debian bookworm stable" | tee /etc/apt/sources.list.d/docker.list && apt-get update && apt-get install -y --no-install-recommends containerd.io docker-buildx-plugin docker-ce docker-ce-cli docker-compose-plugin git libmariadb-dev-compat libpq5 nodejs npm openssl && rm -rf /var/lib/apt/lists/*: 0.233 Ign:1 http://deb.debian.org/debian bookworm InRelease 0.298 Ign:2 http://deb.debian.org/debian bookworm-updates InRelease 0.377 Ign:3 http://deb.debian.org/debian-security bookworm-security InRelease 1.291 Ign:1 http://deb.debian.org/debian bookworm InRelease 1.354 Ign:2 http://deb.debian.org/debian bookworm-updates InRelease 1.437 Ign:3 http://deb.debian.org/debian-security bookworm-security InRelease 3.351 Ign:1 http://deb.debian.org/debian bookworm InRelease 3.411 Ign:2 http://deb.debian.org/debian bookworm-updates InRelease 3.496 Ign:3 http://deb.debian.org/debian-security bookworm-security InRelease 7.428 Err:1 http://deb.debian.org/debian bookworm InRelease 7.428 Temporary failure resolving 'deb.debian.org' 7.517 Err:2 http://deb.debian.org/debian bookworm-updates InRelease 7.517 Temporary failure resolving 'deb.debian.org' 7.606 Err:3 http://deb.debian.org/debian-security bookworm-security InRelease 7.606 Temporary failure resolving 'deb.debian.org' 7.609 Reading package lists... 7.617 W: Failed to fetch http://deb.debian.org/debian/dists/bookworm/InRelease Temporary failure resolving 'deb.debian.org' 7.617 W: Failed to fetch http://deb.debian.org/debian/dists/bookworm-updates/InRelease Temporary failure resolving 'deb.debian.org' 7.617 W: Failed to fetch http://deb.debian.org/debian-security/dists/bookworm-security/InRelease Temporary failure resolving 'deb.debian.org' 7.617 W: Some index files failed to download. They have been ignored, or old ones used instead. 7.626 Reading package lists... 7.633 Building dependency tree... 7.633 Reading state information... 7.634 Package ca-certificates is not available, but is referred to by another package. 7.634 This may mean that the package is missing, has been obsoleted, or 7.634 is only available from another source 7.634 7.634 E: Package 'ca-certificates' has no installation candidate 7.634 E: Unable to locate package curl ------ failed to solve: process "/bin/bash -o pipefail -c apt-get update && apt-get install -y ca-certificates curl && curl -fsSL https://download.docker.com/linux/debian/gpg -o /etc/apt/keyrings/docker.asc && chmod a+r /etc/apt/keyrings/docker.asc && echo \"deb [signed-by=/etc/apt/keyrings/docker.asc] https://download.docker.com/linux/debian bookworm stable\" | tee /etc/apt/sources.list.d/docker.list && apt-get update && apt-get install -y --no-install-recommends containerd.io docker-buildx-plugin docker-ce docker-ce-cli docker-compose-plugin git libmariadb-dev-compat libpq5 nodejs npm openssl && rm -rf /var/lib/apt/lists/*" did not complete successfully: exit code: 100 ``` If someone knows what I'm doing wrong, info would be much appreciated :). --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

GiteaMirror added the pull-request label 2026-05-16 05:54:36 -05:00

GiteaMirror closed this issue 2026-05-16 05:54:37 -05:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

revert-7033-patch-1

cached-config-operations

test_dylint

1.36.0

1.35.8

1.35.7

1.35.6

1.35.5

1.35.4

1.35.3

1.35.2

1.35.1

1.35.0

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

GiteaMirror ninjasurge

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#23284