github-starred/vaultwarden
2
0
Fork 0
mirror of https://github.com/dani-garcia/vaultwarden.git synced 2026-05-22 16:14:20 -05:00
Code Issues 307 Packages Projects Releases 83 Wiki Activity

[PR #6263] [MERGED] Change OIDC dummy identifier #23281

New Issue
Closed
opened 2026-05-16 05:54:30 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-16 05:54:30 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/6263
Author: @Timshel
Created: 9/1/2025
Status: ✅ Merged
Merged: 10/13/2025
Merged by: @BlackDex

Base: main ← Head: fix/dummyIdentifier

📝 Commits (4)

  • 0e57f05 Change OIDC dummy identifier
  • 3b3316d Update src/sso.rs
  • 2941f82 Use Org uuid as identifier
  • 4fb6cb6 Merge branch 'main' into fix/dummyIdentifier

📊 Changes

3 files changed (+9 additions, -9 deletions)

View changed files

📝 src/api/core/accounts.rs (+1 -1)
📝 src/api/core/organizations.rs (+7 -7)
📝 src/sso.rs (+1 -1)

📄 Description

The main use of the fake identifier is to return a value in Organizations::get_auto_enroll_status to allow bypassing the screen which would otherwise ask for one.

Though that the current value was a bit too simple and run the risk of someone creating an Organization with the same name.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/6263 **Author:** [@Timshel](https://github.com/Timshel) **Created:** 9/1/2025 **Status:** ✅ Merged **Merged:** 10/13/2025 **Merged by:** [@BlackDex](https://github.com/BlackDex) **Base:** `main` ← **Head:** `fix/dummyIdentifier` --- ### 📝 Commits (4) - [`0e57f05`](https://github.com/dani-garcia/vaultwarden/commit/0e57f05731f21a20e321de4d59a0004e66bcf638) Change OIDC dummy identifier - [`3b3316d`](https://github.com/dani-garcia/vaultwarden/commit/3b3316d2dd82d280d5c2a733819fbc5364baad3a) Update src/sso.rs - [`2941f82`](https://github.com/dani-garcia/vaultwarden/commit/2941f82532aa317c243565ab190447e9438fded8) Use Org uuid as identifier - [`4fb6cb6`](https://github.com/dani-garcia/vaultwarden/commit/4fb6cb62fc4f33573e2f90d0be84bb02a6c65fa5) Merge branch 'main' into fix/dummyIdentifier ### 📊 Changes **3 files changed** (+9 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/accounts.rs` (+1 -1) 📝 `src/api/core/organizations.rs` (+7 -7) 📝 `src/sso.rs` (+1 -1) </details> ### 📄 Description The main use of the fake identifier is to return a value in `Organizations::get_auto_enroll_status` to allow bypassing the screen which would otherwise ask for one. Though that the current value was a bit too simple and run the risk of someone creating an Organization with the same name. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-16 05:54:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
better for forum
bug
documentation
duplicate
enhancement
future Vault
good first issue
help wanted
low priority
notes
pull-request
Mirrored from GitHub Pull Request
 question
SSO
Third party
troubleshooting
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#23281
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?