[PR #5219] [MERGED] Add partial role support for manager only using web-vault v2024.12.0 #23107

Closed
opened 2026-05-16 05:47:11 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/5219
Author: @BlackDex
Created: 11/21/2024
Status: Merged
Merged: 1/4/2025
Merged by: @dani-garcia

Base: mainHead: mngr-custom-role


📝 Commits (7)

  • 81eae81 Add partial role support for manager only
  • ec2ed57 Fix hide passkey login
  • 0e6f3a4 Fix hide create account
  • 4e59ba2 Small changes for v2024.12.0
  • 84f01d2 Fix hide create account link
  • 296e45b Add pre-release web-vault
  • 48116b0 Rename function to mention swapping uuid's

📊 Changes

10 files changed (+330 additions, -120 deletions)

View changed files

📝 docker/DockerSettings.yaml (+4 -4)
📝 docker/Dockerfile.alpine (+6 -6)
📝 docker/Dockerfile.debian (+7 -7)
📝 src/api/core/organizations.rs (+120 -13)
📝 src/api/web.rs (+1 -38)
📝 src/config.rs (+42 -1)
📝 src/db/models/collection.rs (+4 -1)
📝 src/db/models/group.rs (+4 -1)
📝 src/db/models/organization.rs (+100 -36)
📝 src/static/templates/scss/vaultwarden.scss.hbs (+42 -13)

📄 Description

  • Add the custom role which replaces the manager role
  • Added mini-details endpoint used by v2024.12.0

These changes try to add the custom role in such a way that it stays compatible with the older manager role. It will convert a manager role into a custom role, and if a manager has access-all rights, it will enable the correct custom roles. Upon saving it will convert these back to the old format.

What this does is making sure you are able to revert back to an older version of Vaultwarden without issues. This way we can support newer web-vault's and still be compatible with a previous Vaultwarden version if needed.

In the future this needs to be changed to full role support though.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/5219 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 11/21/2024 **Status:** ✅ Merged **Merged:** 1/4/2025 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `mngr-custom-role` --- ### 📝 Commits (7) - [`81eae81`](https://github.com/dani-garcia/vaultwarden/commit/81eae816832843a90299062b00339c922a6b15c2) Add partial role support for manager only - [`ec2ed57`](https://github.com/dani-garcia/vaultwarden/commit/ec2ed57c04ac13f9430b9763b64d14622b0f91e0) Fix hide passkey login - [`0e6f3a4`](https://github.com/dani-garcia/vaultwarden/commit/0e6f3a491b4c85b690196dcaefc2dd31fcb8441c) Fix hide create account - [`4e59ba2`](https://github.com/dani-garcia/vaultwarden/commit/4e59ba23251c411a04abee2c42de196f22c235d4) Small changes for v2024.12.0 - [`84f01d2`](https://github.com/dani-garcia/vaultwarden/commit/84f01d2c12149ce2ada703bb9db9bea0eea25d27) Fix hide create account link - [`296e45b`](https://github.com/dani-garcia/vaultwarden/commit/296e45bc6ce24edb888bd0bfaa92eefc6c6730bd) Add pre-release web-vault - [`48116b0`](https://github.com/dani-garcia/vaultwarden/commit/48116b0d1777b8fcc99699ee63f085bdd3a78b34) Rename function to mention swapping uuid's ### 📊 Changes **10 files changed** (+330 additions, -120 deletions) <details> <summary>View changed files</summary> 📝 `docker/DockerSettings.yaml` (+4 -4) 📝 `docker/Dockerfile.alpine` (+6 -6) 📝 `docker/Dockerfile.debian` (+7 -7) 📝 `src/api/core/organizations.rs` (+120 -13) 📝 `src/api/web.rs` (+1 -38) 📝 `src/config.rs` (+42 -1) 📝 `src/db/models/collection.rs` (+4 -1) 📝 `src/db/models/group.rs` (+4 -1) 📝 `src/db/models/organization.rs` (+100 -36) 📝 `src/static/templates/scss/vaultwarden.scss.hbs` (+42 -13) </details> ### 📄 Description - Add the custom role which replaces the manager role - Added mini-details endpoint used by v2024.12.0 These changes try to add the custom role in such a way that it stays compatible with the older manager role. It will convert a manager role into a custom role, and if a manager has `access-all` rights, it will enable the correct custom roles. Upon saving it will convert these back to the old format. What this does is making sure you are able to revert back to an older version of Vaultwarden without issues. This way we can support newer web-vault's and still be compatible with a previous Vaultwarden version if needed. In the future this needs to be changed to full role support though. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-16 05:47:11 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#23107