mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-08-26 11:55:50 -05:00
[PR #5219] [MERGED] Add partial role support for manager only using web-vault v2024.12.0 #23107
Reference in New Issue
Block a user
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/5219
Author: @BlackDex
Created: 11/21/2024
Status: ✅ Merged
Merged: 1/4/2025
Merged by: @dani-garcia
Base:
main← Head:mngr-custom-role📝 Commits (7)
81eae81Add partial role support for manager onlyec2ed57Fix hide passkey login0e6f3a4Fix hide create account4e59ba2Small changes for v2024.12.084f01d2Fix hide create account link296e45bAdd pre-release web-vault48116b0Rename function to mention swapping uuid's📊 Changes
10 files changed (+330 additions, -120 deletions)
View changed files
📝
docker/DockerSettings.yaml(+4 -4)📝
docker/Dockerfile.alpine(+6 -6)📝
docker/Dockerfile.debian(+7 -7)📝
src/api/core/organizations.rs(+120 -13)📝
src/api/web.rs(+1 -38)📝
src/config.rs(+42 -1)📝
src/db/models/collection.rs(+4 -1)📝
src/db/models/group.rs(+4 -1)📝
src/db/models/organization.rs(+100 -36)📝
src/static/templates/scss/vaultwarden.scss.hbs(+42 -13)📄 Description
These changes try to add the custom role in such a way that it stays compatible with the older manager role. It will convert a manager role into a custom role, and if a manager has
access-allrights, it will enable the correct custom roles. Upon saving it will convert these back to the old format.What this does is making sure you are able to revert back to an older version of Vaultwarden without issues. This way we can support newer web-vault's and still be compatible with a previous Vaultwarden version if needed.
In the future this needs to be changed to full role support though.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.