[PR #4951] [CLOSED] SSO using OpenID Connect - continuation of PR #3899 #23067

New Issue

GiteaMirror · 2026-05-16T05:44:56-05:00

GiteaMirror commented

2026-05-16 05:44:56 -05:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/4951
Author: @yonas
Created: 9/13/2024
Status: ❌ Closed

Base: main ← Head: sso-support

📝 Commits (3)

35bc13d Add SSO functionality using OpenID Connect
2bcc014 Improvements and error handling
065f80e Stop rolling device token

📊 Changes

67 files changed (+2908 additions, -258 deletions)

View changed files

📝 .env.template (+38 -0)
📝 Cargo.lock (+670 -66)
📝 Cargo.toml (+4 -0)
➕ SSO.md (+286 -0)
📝 docker/start.sh (+7 -0)
➕ migrations/mysql/2023-09-10-133000_add_sso/down.sql (+1 -0)
➕ migrations/mysql/2023-09-10-133000_add_sso/up.sql (+4 -0)
➕ migrations/mysql/2023-09-14-133000_add_users_organizations_invited_by_email/down.sql (+1 -0)
➕ migrations/mysql/2023-09-14-133000_add_users_organizations_invited_by_email/up.sql (+1 -0)
➕ migrations/mysql/2024-02-14-170000_add_state_to_sso_nonce/down.sql (+6 -0)
➕ migrations/mysql/2024-02-14-170000_add_state_to_sso_nonce/up.sql (+8 -0)
➕ migrations/mysql/2024-02-26-170000_add_pkce_to_sso_nonce/down.sql (+8 -0)
➕ migrations/mysql/2024-02-26-170000_add_pkce_to_sso_nonce/up.sql (+9 -0)
➕ migrations/mysql/2024-03-06-170000_add_sso_users/down.sql (+1 -0)
➕ migrations/mysql/2024-03-06-170000_add_sso_users/up.sql (+7 -0)
➕ migrations/mysql/2024-03-13-170000_sso_users_cascade/down.sql (+0 -0)
➕ migrations/mysql/2024-03-13-170000_sso_users_cascade/up.sql (+2 -0)
➕ migrations/postgresql/2023-09-10-133000_add_sso/down.sql (+1 -0)
➕ migrations/postgresql/2023-09-10-133000_add_sso/up.sql (+4 -0)
➕ migrations/postgresql/2023-09-14-133000_add_users_organizations_invited_by_email/down.sql (+1 -0)

...and 47 more files

📄 Description

PR #3899 was closed as per Timshel's wishes. I hope other devs can use this PR to continue where Tim left off.

Hey,

So next week this PR would become one-year-old, but progress on getting it merge is still slow.
Earlier in the year I activated the sponsor feature and without being prompted some of you made a donation, thanks a lot :). But I won't be able to continue like this.

While the amount of work needed to keep-up with Bitwarden can vary and even if the core of the feature is stable there is still quite a bit of improvement and I would enjoy continuing working on it :).

So I decided to create a named fork timshel/OIDCWarden to try to see if I can garner more support.

For now, I will be closing this PR since I don't plan to update it in the short term (will probably reopen it later on) while I work on the fork.

Subjects I intend to work are:
fixing some parameters left over after redirection.
More integration tests (Playwright)
Better doc.
The first fork release is v2024.8.3-1 and as the name suggest include/interface with the v2024.8.3 web-vault release (between the name change and some Organization change proceed with caution ;) ).

If you have any question or feedback don't hesitate over https://github.com/Timshel/OIDCWarden/discussions/1.

Thank you :).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4951 **Author:** [@yonas](https://github.com/yonas) **Created:** 9/13/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `sso-support` --- ### 📝 Commits (3) - [`35bc13d`](https://github.com/dani-garcia/vaultwarden/commit/35bc13d230ba95294338b5a8bb2689168a5f91e2) Add SSO functionality using OpenID Connect - [`2bcc014`](https://github.com/dani-garcia/vaultwarden/commit/2bcc014b2c9544d635be5a254e515015715889fc) Improvements and error handling - [`065f80e`](https://github.com/dani-garcia/vaultwarden/commit/065f80e2c2f6446906f258a455366a40de723a2e) Stop rolling device token ### 📊 Changes **67 files changed** (+2908 additions, -258 deletions) <details> <summary>View changed files</summary> 📝 `.env.template` (+38 -0) 📝 `Cargo.lock` (+670 -66) 📝 `Cargo.toml` (+4 -0) ➕ `SSO.md` (+286 -0) 📝 `docker/start.sh` (+7 -0) ➕ `migrations/mysql/2023-09-10-133000_add_sso/down.sql` (+1 -0) ➕ `migrations/mysql/2023-09-10-133000_add_sso/up.sql` (+4 -0) ➕ `migrations/mysql/2023-09-14-133000_add_users_organizations_invited_by_email/down.sql` (+1 -0) ➕ `migrations/mysql/2023-09-14-133000_add_users_organizations_invited_by_email/up.sql` (+1 -0) ➕ `migrations/mysql/2024-02-14-170000_add_state_to_sso_nonce/down.sql` (+6 -0) ➕ `migrations/mysql/2024-02-14-170000_add_state_to_sso_nonce/up.sql` (+8 -0) ➕ `migrations/mysql/2024-02-26-170000_add_pkce_to_sso_nonce/down.sql` (+8 -0) ➕ `migrations/mysql/2024-02-26-170000_add_pkce_to_sso_nonce/up.sql` (+9 -0) ➕ `migrations/mysql/2024-03-06-170000_add_sso_users/down.sql` (+1 -0) ➕ `migrations/mysql/2024-03-06-170000_add_sso_users/up.sql` (+7 -0) ➕ `migrations/mysql/2024-03-13-170000_sso_users_cascade/down.sql` (+0 -0) ➕ `migrations/mysql/2024-03-13-170000_sso_users_cascade/up.sql` (+2 -0) ➕ `migrations/postgresql/2023-09-10-133000_add_sso/down.sql` (+1 -0) ➕ `migrations/postgresql/2023-09-10-133000_add_sso/up.sql` (+4 -0) ➕ `migrations/postgresql/2023-09-14-133000_add_users_organizations_invited_by_email/down.sql` (+1 -0) _...and 47 more files_ </details> ### 📄 Description PR #3899 was closed as per Timshel's wishes. I hope other devs can use this PR to continue where Tim left off. > Hey, > > So next week this PR would become one-year-old, but progress on getting it merge is still slow. > Earlier in the year I activated the sponsor feature and without being prompted some of you made a donation, thanks a lot :). But I won't be able to continue like this. > > While the amount of work needed to keep-up with Bitwarden can vary and even if the core of the feature is stable there is still quite a bit of improvement and I would enjoy continuing working on it :). > > So I decided to create a named fork [timshel/OIDCWarden](https://github.com/Timshel/OIDCWarden) to try to see if I can garner more support. > > For now, I will be closing this PR since I don't plan to update it in the short term (will probably reopen it later on) while I work on the fork. > > Subjects I intend to work are: > > fixing some parameters left over after redirection. > More integration tests (Playwright) > Better doc. > > The first fork release is v2024.8.3-1 and as the name suggest include/interface with the v2024.8.3 web-vault release (between the name change and some Organization change proceed with caution ;) ). > > If you have any question or feedback don't hesitate over https://github.com/Timshel/OIDCWarden/discussions/1. > > Thank you :). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-16 05:44:56 -05:00

GiteaMirror closed this issue

2026-05-16 05:44:58 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#23067