Note that for stronger guaranty that the email is correctly formatted (would apply to duo_oidc.validate_duo_login too):
Could change the parameter to User.
Could define a custom type for a formatted email and wrap it.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4840
**Author:** [@Timshel](https://github.com/Timshel)
**Created:** 8/12/2024
**Status:** ✅ Merged
**Merged:** 8/17/2024
**Merged by:** [@dani-garcia](https://github.com/dani-garcia)
**Base:** `main` ← **Head:** `feature/email`
---
### 📝 Commits (1)
- [`b895bed`](https://github.com/dani-garcia/vaultwarden/commit/b895bedc6daed933ac35b348086eee3a684aecff) Remove unecessary email normalization
### 📊 Changes
**1 file changed** (+0 additions, -4 deletions)
<details>
<summary>View changed files</summary>
📝 `src/api/core/two_factor/duo.rs` (+0 -4)
</details>
### 📄 Description
Hey,
Was checking the OIDC pr change and realized that this change was still present.
I forgot to include it in the recent https://github.com/dani-garcia/vaultwarden/pull/4779.
Note that for stronger guaranty that the email is correctly formatted (would apply to `duo_oidc.validate_duo_login` too):
- Could change the parameter to `User`.
- Could define a custom type for a formatted email and wrap it.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/4840
Author: @Timshel
Created: 8/12/2024
Status: ✅ Merged
Merged: 8/17/2024
Merged by: @dani-garcia
Base:
main← Head:feature/email📝 Commits (1)
b895bedRemove unecessary email normalization📊 Changes
1 file changed (+0 additions, -4 deletions)
View changed files
📝
src/api/core/two_factor/duo.rs(+0 -4)📄 Description
Hey,
Was checking the OIDC pr change and realized that this change was still present.
I forgot to include it in the recent https://github.com/dani-garcia/vaultwarden/pull/4779.
Note that for stronger guaranty that the email is correctly formatted (would apply to
duo_oidc.validate_duo_logintoo):User.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.