f3a1385 Do not send extra headers for Upgrade connection
ca1a9e2 Remove SET CONSTRAINTS during postgres migration
📊 Changes
2 files changed (+23 additions, -19 deletions)
View changed files
📝src/db/mod.rs (+1 -13) 📝src/util.rs (+22 -6)
📄 Description
Do not send extra headers for Upgrade connection
During a WebSocket connection we currently also send several headers
which could cause issues with some reverse proxy, or with the CloudFlare
tunnel for example. This PR resolves these issues.
The PostgreSQL migrations do not need this setting.
I tested this by running an old Vaultwarden instance (v1.18.0) on a new
PostrgreSQL database, created a few users and some vault items, after
that run the new code and it doesn't break.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/dani-garcia/vaultwarden/pull/3964
**Author:** [@BlackDex](https://github.com/BlackDex)
**Created:** 10/9/2023
**Status:** ✅ Merged
**Merged:** 10/20/2023
**Merged by:** [@dani-garcia](https://github.com/dani-garcia)
**Base:** `main` ← **Head:** `fix-small-issues`
---
### 📝 Commits (2)
- [`f3a1385`](https://github.com/dani-garcia/vaultwarden/commit/f3a1385aee241dcbf6a513d5926eae4cd7872e88) Do not send extra headers for Upgrade connection
- [`ca1a9e2`](https://github.com/dani-garcia/vaultwarden/commit/ca1a9e26d82815c35e0814824d1083bbe56347f9) Remove `SET CONSTRAINTS` during postgres migration
### 📊 Changes
**2 files changed** (+23 additions, -19 deletions)
<details>
<summary>View changed files</summary>
📝 `src/db/mod.rs` (+1 -13)
📝 `src/util.rs` (+22 -6)
</details>
### 📄 Description
## Do not send extra headers for Upgrade connection
During a WebSocket connection we currently also send several headers
which could cause issues with some reverse proxy, or with the CloudFlare
tunnel for example. This PR resolves these issues.
Fixes #3881
## Remove SET CONSTRAINTS during postgres migration
The PostgreSQL migrations do not need this setting.
I tested this by running an old Vaultwarden instance (v1.18.0) on a new
PostrgreSQL database, created a few users and some vault items, after
that run the new code and it doesn't break.
Fixes #3930
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/3964
Author: @BlackDex
Created: 10/9/2023
Status: ✅ Merged
Merged: 10/20/2023
Merged by: @dani-garcia
Base:
main← Head:fix-small-issues📝 Commits (2)
f3a1385Do not send extra headers for Upgrade connectionca1a9e2RemoveSET CONSTRAINTSduring postgres migration📊 Changes
2 files changed (+23 additions, -19 deletions)
View changed files
📝
src/db/mod.rs(+1 -13)📝
src/util.rs(+22 -6)📄 Description
Do not send extra headers for Upgrade connection
During a WebSocket connection we currently also send several headers
which could cause issues with some reverse proxy, or with the CloudFlare
tunnel for example. This PR resolves these issues.
Fixes #3881
Remove SET CONSTRAINTS during postgres migration
The PostgreSQL migrations do not need this setting.
I tested this by running an old Vaultwarden instance (v1.18.0) on a new
PostrgreSQL database, created a few users and some vault items, after
that run the new code and it doesn't break.
Fixes #3930
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.