[PR #3087] [MERGED] Fix failing large note imports #22743

New Issue

GiteaMirror · 2026-05-16T05:31:19-05:00

GiteaMirror commented

2026-05-16 05:31:19 -05:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/3087
Author: @BlackDex
Created: 1/1/2023
Status: ✅ Merged
Merged: 1/9/2023
Merged by: @dani-garcia

Base: main ← Head: issue-3048

📝 Commits (1)

6be26f0 Fix failing large note imports

📊 Changes

4 files changed (+42 additions, -3 deletions)

View changed files

📝 src/api/core/ciphers.rs (+7 -1)
📝 src/api/core/mod.rs (+1 -1)
📝 src/api/core/organizations.rs (+6 -0)
📝 src/db/models/cipher.rs (+28 -1)

📄 Description

When importing to Vaultwarden (or Bitwarden) notes larger then 10_000 encrypted characters are invalid. This because it for one isn't compatible with Bitwarden. And some clients tend to break on very large notes.

We already added a check for this limit when adding a single cipher, but this caused issues during import, and could cause a partial imported vault. Bitwarden does some validations before actually running it through the import process and generates a special error message which helps the user indicate which items are invalid during the import.

This PR adds that validation check and returns the same kind of error. Fixes #3048

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/3087 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 1/1/2023 **Status:** ✅ Merged **Merged:** 1/9/2023 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `issue-3048` --- ### 📝 Commits (1) - [`6be26f0`](https://github.com/dani-garcia/vaultwarden/commit/6be26f0a386309f2b49c440a1d0a029402fb45f2) Fix failing large note imports ### 📊 Changes **4 files changed** (+42 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/ciphers.rs` (+7 -1) 📝 `src/api/core/mod.rs` (+1 -1) 📝 `src/api/core/organizations.rs` (+6 -0) 📝 `src/db/models/cipher.rs` (+28 -1) </details> ### 📄 Description When importing to Vaultwarden (or Bitwarden) notes larger then 10_000 encrypted characters are invalid. This because it for one isn't compatible with Bitwarden. And some clients tend to break on very large notes. We already added a check for this limit when adding a single cipher, but this caused issues during import, and could cause a partial imported vault. Bitwarden does some validations before actually running it through the import process and generates a special error message which helps the user indicate which items are invalid during the import. This PR adds that validation check and returns the same kind of error. Fixes #3048 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-16 05:31:19 -05:00

GiteaMirror closed this issue

2026-05-16 05:31:21 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#22743