[PR #2158] [MERGED] Add support for external icon services #22588

New Issue

GiteaMirror · 2026-05-16T05:26:55-05:00

GiteaMirror commented

2026-05-16 05:26:55 -05:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/2158
Author: @jjlin
Created: 12/20/2021
Status: ✅ Merged
Merged: 12/22/2021
Merged by: @dani-garcia

Base: main ← Head: icons

📝 Commits (1)

2f9ac61 Add support for external icon services

📊 Changes

3 files changed (+91 additions, -9 deletions)

View changed files

📝 .env.template (+17 -3)
📝 src/api/icons.rs (+47 -3)
📝 src/config.rs (+27 -3)

📄 Description

If an external icon service is configured, icon requests return an HTTP redirect to the corresponding icon at the external service.

An external service may be useful for various reasons, such as if:

The Vaultwarden instance has no external network connectivity.
The Vaultwarden instance has trouble handling large bursts of icon requests.
There are concerns that an attacker may probe the instance to try to detect whether icons for certain sites have been cached, which would suggest that the instance contains entries for those sites.
The external icon service does a better job of providing icons than the built-in fetcher.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/2158 **Author:** [@jjlin](https://github.com/jjlin) **Created:** 12/20/2021 **Status:** ✅ Merged **Merged:** 12/22/2021 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `icons` --- ### 📝 Commits (1) - [`2f9ac61`](https://github.com/dani-garcia/vaultwarden/commit/2f9ac61a4e86c272b8029226ad4b7b3fa7171088) Add support for external icon services ### 📊 Changes **3 files changed** (+91 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `.env.template` (+17 -3) 📝 `src/api/icons.rs` (+47 -3) 📝 `src/config.rs` (+27 -3) </details> ### 📄 Description If an external icon service is configured, icon requests return an HTTP redirect to the corresponding icon at the external service. An external service may be useful for various reasons, such as if: * The Vaultwarden instance has no external network connectivity. * The Vaultwarden instance has trouble handling large bursts of icon requests. * There are concerns that an attacker may probe the instance to try to detect whether icons for certain sites have been cached, which would suggest that the instance contains entries for those sites. * The external icon service does a better job of providing icons than the built-in fetcher. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-16 05:26:55 -05:00

GiteaMirror closed this issue

2026-05-16 05:26:57 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#22588