mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-05-23 00:25:37 -05:00
Invite mails use localhost as domain
#224
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/vaultwarden#224
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ldidry on GitHub (Feb 8, 2019).
The line 72 of the .env.template file says that there is no need to set
DOMAIN"Unless you are using U2F, or having problems with attachments not downloading" but without setting upDOMAIN, the invite link in mails useshttp://localhostas domain.This could be fixed either by updating the documentation or using the HTTP headers (Host and Scheme) to find the currently used domain (I don't know if it would work with Docker, I don't know Caddy which is the suggested proxy).
@mprasil commented on GitHub (Feb 8, 2019):
See documentation for other proxies. As far as I remember you only need to forward the
Hostheader and it should work fine.@ldidry commented on GitHub (Feb 8, 2019):
It didn't work for me with Nginx.
@dani-garcia commented on GitHub (Feb 8, 2019):
At the moment we only guess the domain for the attachments, the emails require the
DOMAINvariable to be set, the .env file wasn't updated apparently.We should update the documentation accordingly, and we could also consider using the same domain-guessing for email if possible (For u2f it might not be a good idea, as the authentication can break if the domain changes).
@dani-garcia commented on GitHub (Feb 8, 2019):
I updated the env file to better reflect the current situation, and also added the domain guessing functionality to the feature requests issue, so I think this can be closed now. Thanks!
@ldidry commented on GitHub (Feb 8, 2019):
Thx 👍