[PR #7162] [MERGED] Fix Host/IP resolving #22089

New Issue

GiteaMirror · 2026-04-30T08:25:20-05:00

GiteaMirror commented

2026-04-30 08:25:20 -05:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/7162
Author: @BlackDex
Created: 4/29/2026
Status: ✅ Merged
Merged: 4/29/2026
Merged by: @dani-garcia

Base: main ← Head: fix-host-and-icon-checks

📝 Commits (1)

d13bca8 Fix Host/IP resolving

📊 Changes

5 files changed (+315 additions, -86 deletions)

View changed files

📝 .pre-commit-config.yaml (+1 -1)
📝 .typos.toml (+2 -0)
📝 src/api/icons.rs (+29 -62)
📝 src/http_client.rs (+266 -16)
📝 src/util.rs (+17 -7)

📄 Description

IPv4 addresses can also be in decimal or hex formats. These were not checked during the Global IP check, and could bypass it.

We now convert everything to the right format before running this check and it will catch these formats.

Also updated the is_global() function to match Rust's still unstable version. And updated the Image Magic checks to be more precise and filter out any possible broken or invalid formats.

While at it, also added several checks to ensure these special formatted IPv4 addresses are still blocked and punycode domains are also correctly resolved.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/7162 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 4/29/2026 **Status:** ✅ Merged **Merged:** 4/29/2026 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `fix-host-and-icon-checks` --- ### 📝 Commits (1) - [`d13bca8`](https://github.com/dani-garcia/vaultwarden/commit/d13bca866f988fe5f9eac8479ae1b1b176b14296) Fix Host/IP resolving ### 📊 Changes **5 files changed** (+315 additions, -86 deletions) <details> <summary>View changed files</summary> 📝 `.pre-commit-config.yaml` (+1 -1) 📝 `.typos.toml` (+2 -0) 📝 `src/api/icons.rs` (+29 -62) 📝 `src/http_client.rs` (+266 -16) 📝 `src/util.rs` (+17 -7) </details> ### 📄 Description IPv4 addresses can also be in decimal or hex formats. These were not checked during the Global IP check, and could bypass it. We now convert everything to the right format before running this check and it will catch these formats. Also updated the `is_global()` function to match Rust's still unstable version. And updated the Image Magic checks to be more precise and filter out any possible broken or invalid formats. While at it, also added several checks to ensure these special formatted IPv4 addresses are still blocked and punycode domains are also correctly resolved. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-30 08:25:20 -05:00

GiteaMirror closed this issue

2026-04-30 08:25:21 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#22089