[PR #6882] Implement Fallback Icon service #22058

New Issue

Open

opened 2026-04-30 08:23:02 -05:00 by GiteaMirror · 0 comments

GiteaMirror commented 2026-04-30 08:23:02 -05:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/6882
Author: @Shocker
Created: 2/27/2026
Status: 🔄 Open

Base: main ← Head: icon-service-fallback

---

📝 Commits (6)

• 7287a12 Implement Fallback Icon service
• 75bdd9e resolve conflicts
• db18b7d Merge branch 'main' into icon-service-fallback
• 870afdb fix clippy errors
• 095b3d1 fix fmt
• 8d3e4ba Merge branch 'main' into icon-service-fallback

📊 Changes

2 files changed (+38 additions, -1 deletions)

View changed files

📝 src/api/icons.rs (+7 -1)
📝 src/config.rs (+31 -0)

📄 Description

Following the discussion from here https://github.com/dani-garcia/vaultwarden/pull/6881 add a separate config to allow fallback to external icon services icon URL (bitwarden, duckduckgo, google) when using the internal icon service in case all the default icon links fail to be downloaded (possibly due to anti-bot/anti-crawler techniques)

P.S.: For this pull request to work, https://github.com/dani-garcia/vaultwarden/pull/6880 MUST be accepted/merged. After that this PR will require a small code change to accomodate for those new changes resolved

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/6882 **Author:** [@Shocker](https://github.com/Shocker) **Created:** 2/27/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `icon-service-fallback` --- ### 📝 Commits (6) - [`7287a12`](https://github.com/dani-garcia/vaultwarden/commit/7287a121fbe8b02c435e6fc3190aa9069b836318) Implement Fallback Icon service - [`75bdd9e`](https://github.com/dani-garcia/vaultwarden/commit/75bdd9e86285aa9e803f768f98cc9b6b0f763313) resolve conflicts - [`db18b7d`](https://github.com/dani-garcia/vaultwarden/commit/db18b7db0cc8208734498fce637501f8e495331f) Merge branch 'main' into icon-service-fallback - [`870afdb`](https://github.com/dani-garcia/vaultwarden/commit/870afdbcf2c07cb921c33d0bfd5c14455ee6d97b) fix clippy errors - [`095b3d1`](https://github.com/dani-garcia/vaultwarden/commit/095b3d1a4eb0186215c7061933526bdfb4427ff4) fix fmt - [`8d3e4ba`](https://github.com/dani-garcia/vaultwarden/commit/8d3e4ba67c4a0c761ea5254ec0e7c5f9f654f357) Merge branch 'main' into icon-service-fallback ### 📊 Changes **2 files changed** (+38 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/api/icons.rs` (+7 -1) 📝 `src/config.rs` (+31 -0) </details> ### 📄 Description Following the discussion from here https://github.com/dani-garcia/vaultwarden/pull/6881 add a separate config to allow fallback to external icon services icon URL (bitwarden, duckduckgo, google) when using the internal icon service in case all the default icon links fail to be downloaded (possibly due to anti-bot/anti-crawler techniques) ~~P.S.: For this pull request to work, https://github.com/dani-garcia/vaultwarden/pull/6880 MUST be accepted/merged. After that this PR will require a small code change to accomodate for those new changes~~ resolved --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

GiteaMirror added the pull-request label 2026-04-30 08:23:02 -05:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

revert-7033-patch-1

cached-config-operations

test_dylint

1.36.0

1.35.8

1.35.7

1.35.6

1.35.5

1.35.4

1.35.3

1.35.2

1.35.1

1.35.0

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

GiteaMirror ninjasurge

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#22058