[PR #6321] [MERGED] [Playwright] Improvements around node #21957

New Issue

Closed

opened 2026-04-30 08:18:42 -05:00 by GiteaMirror · 0 comments

GiteaMirror commented 2026-04-30 08:18:42 -05:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/6321
Author: @Timshel
Created: 9/23/2025
Status: ✅ Merged
Merged: 10/29/2025
Merged by: @dani-garcia

Base: main ← Head: improvements/playwright

---

📝 Commits (2)

• c3ea111 Playwright node improvements
• fc8e0b6 Upgrade Keycloak compose to trixie

📊 Changes

8 files changed (+400 additions, -226 deletions)

View changed files

📝 playwright/README.md (+1 -1)
📝 playwright/compose/keycloak/Dockerfile (+7 -28)
📝 playwright/compose/keycloak/setup.sh (+10 -2)
📝 playwright/compose/playwright/Dockerfile (+4 -4)
📝 playwright/docker-compose.yml (+4 -5)
📝 playwright/global-utils.ts (+1 -1)
📝 playwright/package-lock.json (+366 -178)
📝 playwright/package.json (+7 -7)

📄 Description

In the context of the latest supply chain attack on npm (Shai-Hulud).

• Use fixed dependencies version (since it's not deployed using a slightly out of date version is way less of a risk than installing a compromised minor update).
• Replace npm install with npm ci --ignore-scripts to use the lock file (in the doc and docker image).

Additionally, updated the playwright docker image to trixie and backported the Keycloak update from the role PR.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/6321 **Author:** [@Timshel](https://github.com/Timshel) **Created:** 9/23/2025 **Status:** ✅ Merged **Merged:** 10/29/2025 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `improvements/playwright` --- ### 📝 Commits (2) - [`c3ea111`](https://github.com/dani-garcia/vaultwarden/commit/c3ea1114fa3e44ccda343367f61017d68ab6085b) Playwright node improvements - [`fc8e0b6`](https://github.com/dani-garcia/vaultwarden/commit/fc8e0b6c252b2eff4cce11d1418453b4710fbd3a) Upgrade Keycloak compose to trixie ### 📊 Changes **8 files changed** (+400 additions, -226 deletions) <details> <summary>View changed files</summary> 📝 `playwright/README.md` (+1 -1) 📝 `playwright/compose/keycloak/Dockerfile` (+7 -28) 📝 `playwright/compose/keycloak/setup.sh` (+10 -2) 📝 `playwright/compose/playwright/Dockerfile` (+4 -4) 📝 `playwright/docker-compose.yml` (+4 -5) 📝 `playwright/global-utils.ts` (+1 -1) 📝 `playwright/package-lock.json` (+366 -178) 📝 `playwright/package.json` (+7 -7) </details> ### 📄 Description In the context of the latest supply chain attack on npm (Shai-Hulud). - Use fixed dependencies version (since it's not deployed using a slightly out of date version is way less of a risk than installing a compromised minor update). - Replace `npm install` with `npm ci --ignore-scripts` to use the lock file (in the doc and docker image). Additionally, updated the playwright docker image to `trixie` and backported the Keycloak update from the role PR. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

GiteaMirror added the pull-request label 2026-04-30 08:18:42 -05:00

GiteaMirror closed this issue 2026-04-30 08:18:43 -05:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

revert-7033-patch-1

cached-config-operations

test_dylint

1.36.0

1.35.8

1.35.7

1.35.6

1.35.5

1.35.4

1.35.3

1.35.2

1.35.1

1.35.0

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

GiteaMirror ninjasurge

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#21957