[PR #5536] [MERGED] Fix icon redirect not working on desktop #21828

New Issue

Closed

opened 2026-04-30 08:13:58 -05:00 by GiteaMirror · 0 comments

GiteaMirror commented 2026-04-30 08:13:58 -05:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/5536
Author: @BlackDex
Created: 2/3/2025
Status: ✅ Merged
Merged: 2/4/2025
Merged by: @dani-garcia

Base: main ← Head: fix-icon-redirect

---

📝 Commits (3)

• 89f5629 Fix icon redirect not working on desktop
• cbaddc8 Add informational comments to the icon_external function
• 2d46c20 Fix spelling/grammar

📊 Changes

2 files changed (+11 additions, -4 deletions)

View changed files

📝 src/api/icons.rs (+3 -0)
📝 src/util.rs (+8 -4)

📄 Description

We also need to exclude the header in case we do an external_icon call.

Fixes #5535

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/5536 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 2/3/2025 **Status:** ✅ Merged **Merged:** 2/4/2025 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `fix-icon-redirect` --- ### 📝 Commits (3) - [`89f5629`](https://github.com/dani-garcia/vaultwarden/commit/89f562968f0c8c23bcb16bbccfc839525ffb7e1e) Fix icon redirect not working on desktop - [`cbaddc8`](https://github.com/dani-garcia/vaultwarden/commit/cbaddc8b199e00a50f9b026010f6580cd3a3df5d) Add informational comments to the icon_external function - [`2d46c20`](https://github.com/dani-garcia/vaultwarden/commit/2d46c2087426b4f6bb0834abae12d614999ff623) Fix spelling/grammar ### 📊 Changes **2 files changed** (+11 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/api/icons.rs` (+3 -0) 📝 `src/util.rs` (+8 -4) </details> ### 📄 Description We also need to exclude the header in case we do an external_icon call. Fixes #5535 --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

GiteaMirror added the pull-request label 2026-04-30 08:13:58 -05:00

GiteaMirror closed this issue 2026-04-30 08:13:59 -05:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

revert-7033-patch-1

cached-config-operations

test_dylint

1.36.0

1.35.8

1.35.7

1.35.6

1.35.5

1.35.4

1.35.3

1.35.2

1.35.1

1.35.0

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

GiteaMirror ninjasurge

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#21828