[PR #5037] [CLOSED] enchancement: use Arc + Mutex for dbpool instance instead clone() #21751

New Issue

2026-04-30T08:10:52-05:00

GiteaMirror commented

2026-04-30 08:10:52 -05:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/5037
Author: @sillent
Created: 10/3/2024
Status: ❌ Closed

Base: main ← Head: feat/arc

📝 Commits (7)

e8b7a3f use arc for pool of db
047f674 arc for db pool
74273e5 arc for dbpool
b72498c use Arc::clone semantic
2fcc353 refactor: use RwLock on DbPool instead Mutex
06aa6fd merge main for resolve conflict
2f340fb removed commented use block

📊 Changes

9 files changed (+51 additions, -35 deletions)

View changed files

📝 src/api/core/accounts.rs (+5 -2)
📝 src/api/core/ciphers.rs (+4 -2)
📝 src/api/core/emergency_access.rs (+7 -4)
📝 src/api/core/events.rs (+4 -3)
📝 src/api/core/sends.rs (+4 -2)
📝 src/api/core/two_factor/duo_oidc.rs (+4 -3)
📝 src/api/core/two_factor/mod.rs (+5 -2)
📝 src/db/mod.rs (+3 -3)
📝 src/main.rs (+15 -14)

📄 Description

Hi, this is PR with minor changes - use Arc::clone instead .clone() instance of DbPool

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/5037 **Author:** [@sillent](https://github.com/sillent) **Created:** 10/3/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/arc` --- ### 📝 Commits (7) - [`e8b7a3f`](https://github.com/dani-garcia/vaultwarden/commit/e8b7a3fa63e2ee351ebe05849cedaa8ddd1bb216) use arc for pool of db - [`047f674`](https://github.com/dani-garcia/vaultwarden/commit/047f6747824cdfe007df8dba15a17858bb4eaab1) arc for db pool - [`74273e5`](https://github.com/dani-garcia/vaultwarden/commit/74273e57b8051e263794c25980545736c91fca54) arc for dbpool - [`b72498c`](https://github.com/dani-garcia/vaultwarden/commit/b72498c3574e0c329374c9544ed9c56afd5dcf3e) use Arc::clone semantic - [`2fcc353`](https://github.com/dani-garcia/vaultwarden/commit/2fcc353db02613c8da0bc6c974f66e868d74147f) refactor: use RwLock on DbPool instead Mutex - [`06aa6fd`](https://github.com/dani-garcia/vaultwarden/commit/06aa6fdc042c6553a965740d9a3a723fc14d39a1) merge main for resolve conflict - [`2f340fb`](https://github.com/dani-garcia/vaultwarden/commit/2f340fbc373d2aa6db0beccc884afab01aa58af8) removed commented use block ### 📊 Changes **9 files changed** (+51 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/accounts.rs` (+5 -2) 📝 `src/api/core/ciphers.rs` (+4 -2) 📝 `src/api/core/emergency_access.rs` (+7 -4) 📝 `src/api/core/events.rs` (+4 -3) 📝 `src/api/core/sends.rs` (+4 -2) 📝 `src/api/core/two_factor/duo_oidc.rs` (+4 -3) 📝 `src/api/core/two_factor/mod.rs` (+5 -2) 📝 `src/db/mod.rs` (+3 -3) 📝 `src/main.rs` (+15 -14) </details> ### 📄 Description Hi, this is PR with minor changes - use Arc::clone instead .clone() instance of DbPool --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-30 08:10:52 -05:00

GiteaMirror closed this issue

2026-04-30 08:10:53 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#21751