This should fix syncing with the new native clients.
Filter out password history items which have null
Redesigned the Secure Note Type check to be more robust
Check for null passwords in history during import (or key rotation)
This should not be an issue during the key rotation, since we do not return the invalid password history items anymore.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4932
**Author:** [@BlackDex](https://github.com/BlackDex)
**Created:** 9/7/2024
**Status:** ✅ Merged
**Merged:** 9/9/2024
**Merged by:** [@dani-garcia](https://github.com/dani-garcia)
**Base:** `main` ← **Head:** `fix-sync-response`
---
### 📝 Commits (1)
- [`21e4e02`](https://github.com/dani-garcia/vaultwarden/commit/21e4e025d06c4a48aba73c746847fe175fec6760) Fix sync with new native clients
### 📊 Changes
**4 files changed** (+50 additions, -15 deletions)
<details>
<summary>View changed files</summary>
📝 `src/api/core/accounts.rs` (+1 -1)
📝 `src/api/core/ciphers.rs` (+2 -2)
📝 `src/api/core/organizations.rs` (+1 -1)
📝 `src/db/models/cipher.rs` (+46 -11)
</details>
### 📄 Description
This should fix syncing with the new native clients.
- Filter out password history items which have `null`
- Redesigned the Secure Note Type check to be more robust
- Check for `null` passwords in history during import (or key rotation)
This should not be an issue during the key rotation, since we do not return the invalid password history items anymore.
Fixes #4870
Fixes #4921
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/4932
Author: @BlackDex
Created: 9/7/2024
Status: ✅ Merged
Merged: 9/9/2024
Merged by: @dani-garcia
Base:
main← Head:fix-sync-response📝 Commits (1)
21e4e02Fix sync with new native clients📊 Changes
4 files changed (+50 additions, -15 deletions)
View changed files
📝
src/api/core/accounts.rs(+1 -1)📝
src/api/core/ciphers.rs(+2 -2)📝
src/api/core/organizations.rs(+1 -1)📝
src/db/models/cipher.rs(+46 -11)📄 Description
This should fix syncing with the new native clients.
nullnullpasswords in history during import (or key rotation)This should not be an issue during the key rotation, since we do not return the invalid password history items anymore.
Fixes #4870
Fixes #4921
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.