Do not update externalId on group updates Groups are only updated via the web-vault currently, and those do not send the externalId value, and thus we need to prevent updating it.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/dani-garcia/vaultwarden/pull/3690
**Author:** [@BlackDex](https://github.com/BlackDex)
**Created:** 7/12/2023
**Status:** ✅ Merged
**Merged:** 7/14/2023
**Merged by:** [@dani-garcia](https://github.com/dani-garcia)
**Base:** `main` ← **Head:** `fix-issue-3685`
---
### 📝 Commits (1)
- [`631d022`](https://github.com/dani-garcia/vaultwarden/commit/631d022e175810ce4573b040c34af486b1fcb87f) Fix some external_id issues
### 📊 Changes
**3 files changed** (+28 additions, -38 deletions)
<details>
<summary>View changed files</summary>
📝 `src/api/core/organizations.rs` (+21 -25)
📝 `src/db/models/group.rs` (+5 -12)
📝 `src/db/models/organization.rs` (+2 -1)
</details>
### 📄 Description
- Do not update `externalId` on group updates Groups are only updated via the web-vault currently, and those do not send the `externalId` value, and thus we need to prevent updating it.
- Refactored some other ExternalId functions
- Prevent empty `externalId` on `Collections`
- Return `externalId` for users
Fixes #3685
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/3690
Author: @BlackDex
Created: 7/12/2023
Status: ✅ Merged
Merged: 7/14/2023
Merged by: @dani-garcia
Base:
main← Head:fix-issue-3685📝 Commits (1)
631d022Fix some external_id issues📊 Changes
3 files changed (+28 additions, -38 deletions)
View changed files
📝
src/api/core/organizations.rs(+21 -25)📝
src/db/models/group.rs(+5 -12)📝
src/db/models/organization.rs(+2 -1)📄 Description
externalIdon group updates Groups are only updated via the web-vault currently, and those do not send theexternalIdvalue, and thus we need to prevent updating it.externalIdonCollectionsexternalIdfor usersFixes #3685
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.