[PR #2479] [CLOSED] Migrate old ws crate to tungstenite #21295

New Issue

GiteaMirror · 2026-04-30T07:50:59-05:00

GiteaMirror commented

2026-04-30 07:50:59 -05:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/2479
Author: @dani-garcia
Created: 5/20/2022
Status: ❌ Closed

Base: main ← Head: ws_to_tungstenite

📝 Commits (6)

97c1e6b Migrate old ws crate to tungstenite, which is async and also removes over 20 old dependencies
120a774 Move to job_scheduler_ng
49ab956 use dashmap in icons blacklist regex
e5da4b0 Fix incorrect pings sent, and respond to pings from the client
ec0b043 Fix clippy lint and remove unused log
9ed9645 Re-Base, Update crates and small change.

📊 Changes

10 files changed (+474 additions, -842 deletions)

View changed files

📝 Cargo.lock (+238 -570)
📝 Cargo.toml (+12 -21)
📝 src/api/core/ciphers.rs (+10 -10)
📝 src/api/core/folders.rs (+3 -3)
📝 src/api/core/sends.rs (+5 -5)
📝 src/api/icons.rs (+10 -19)
📝 src/api/notifications.rs (+186 -202)
📝 src/config.rs (+7 -9)
📝 src/error.rs (+2 -0)
📝 src/main.rs (+1 -3)

📄 Description

This new crate supports async, is more popular and is better supported. As another benefit, we dropped nearly 20 duplicate crates with older non-semver-compatible versions that were used by the ws crate.

I'm opening this as a PR to get some reviews and to avoid blocking a new release, which I'll hopefully be able to do this weekend.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/2479 **Author:** [@dani-garcia](https://github.com/dani-garcia) **Created:** 5/20/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `ws_to_tungstenite` --- ### 📝 Commits (6) - [`97c1e6b`](https://github.com/dani-garcia/vaultwarden/commit/97c1e6b14a780bf7432978215b651db35ad1d221) Migrate old ws crate to tungstenite, which is async and also removes over 20 old dependencies - [`120a774`](https://github.com/dani-garcia/vaultwarden/commit/120a77416928b9a18be94c908ab0ad9ee54102be) Move to job_scheduler_ng - [`49ab956`](https://github.com/dani-garcia/vaultwarden/commit/49ab956a07364436154f85bece818b77f9599c1a) use dashmap in icons blacklist regex - [`e5da4b0`](https://github.com/dani-garcia/vaultwarden/commit/e5da4b0ee9f423b614d46e53e237dad0ba576578) Fix incorrect pings sent, and respond to pings from the client - [`ec0b043`](https://github.com/dani-garcia/vaultwarden/commit/ec0b0435a2f92ea1903b674e41e913712dcb94ab) Fix clippy lint and remove unused log - [`9ed9645`](https://github.com/dani-garcia/vaultwarden/commit/9ed9645b5bd459c47a1ff9e5658097f9d2d9c48c) Re-Base, Update crates and small change. ### 📊 Changes **10 files changed** (+474 additions, -842 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+238 -570) 📝 `Cargo.toml` (+12 -21) 📝 `src/api/core/ciphers.rs` (+10 -10) 📝 `src/api/core/folders.rs` (+3 -3) 📝 `src/api/core/sends.rs` (+5 -5) 📝 `src/api/icons.rs` (+10 -19) 📝 `src/api/notifications.rs` (+186 -202) 📝 `src/config.rs` (+7 -9) 📝 `src/error.rs` (+2 -0) 📝 `src/main.rs` (+1 -3) </details> ### 📄 Description This new crate supports async, is more popular and is better supported. As another benefit, we dropped nearly 20 duplicate crates with older non-semver-compatible versions that were used by the ws crate. I'm opening this as a PR to get some reviews and to avoid blocking a new release, which I'll hopefully be able to do this weekend. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-30 07:50:59 -05:00

GiteaMirror closed this issue

2026-04-30 07:51:00 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#21295