[PR #4763] [MERGED] Fix Dockerfile linter warnings #20321

New Issue

Closed

opened 2026-04-25 22:28:16 -05:00 by GiteaMirror · 0 comments

GiteaMirror commented 2026-04-25 22:28:16 -05:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/4763
Author: @dfunkt
Created: 7/17/2024
Status: ✅ Merged
Merged: 7/23/2024
Merged by: @dani-garcia

Base: main ← Head: fix-dockerfile-warnings

---

📝 Commits (1)

• 2e93ed3 Fix Dockerfile linter warnings

📊 Changes

3 files changed (+14 additions, -11 deletions)

View changed files

📝 docker/Dockerfile.alpine (+7 -6)
📝 docker/Dockerfile.debian (+3 -2)
📝 docker/Dockerfile.j2 (+4 -3)

📄 Description

• they seem to have started appearing with buildx v0.16.0

Alpine warnings:

13 warnings found (use --debug to expand):
 - FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" (line 37)
 - FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" (line 38)
 - RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior (line 133)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 35)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 36)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 42)
 - FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" (line 29)
 - FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" (line 36)
 - FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" (line 42)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 29)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 34)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 37)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 38)

Debian warnings:

5 warnings found (use --debug to expand):
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 29)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 38)
 - FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" (line 29)
 - FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" (line 34)
 - RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior (line 171)

For FromPlatformFlagConstDisallowed I decided to use the 3rd variant from here:
https://github.com/moby/buildkit/blob/master/frontend/dockerfile/linter/docs/FromPlatformFlagConstDisallowed.md#description

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4763 **Author:** [@dfunkt](https://github.com/dfunkt) **Created:** 7/17/2024 **Status:** ✅ Merged **Merged:** 7/23/2024 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `fix-dockerfile-warnings` --- ### 📝 Commits (1) - [`2e93ed3`](https://github.com/dani-garcia/vaultwarden/commit/2e93ed3d967da270af72ab7165e774b0a3df1c91) Fix Dockerfile linter warnings ### 📊 Changes **3 files changed** (+14 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `docker/Dockerfile.alpine` (+7 -6) 📝 `docker/Dockerfile.debian` (+3 -2) 📝 `docker/Dockerfile.j2` (+4 -3) </details> ### 📄 Description - they seem to have started appearing with buildx v0.16.0 Alpine warnings: ``` 13 warnings found (use --debug to expand): - FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" (line 37) - FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" (line 38) - RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior (line 133) - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 35) - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 36) - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 42) - FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" (line 29) - FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" (line 36) - FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" (line 42) - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 29) - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 34) - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 37) - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 38) ``` Debian warnings: ``` 5 warnings found (use --debug to expand): - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 29) - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 38) - FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" (line 29) - FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" (line 34) - RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior (line 171) ``` For ```FromPlatformFlagConstDisallowed``` I decided to use the 3rd variant from here: https://github.com/moby/buildkit/blob/master/frontend/dockerfile/linter/docs/FromPlatformFlagConstDisallowed.md#description --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

GiteaMirror added the pull-request label 2026-04-25 22:28:16 -05:00

GiteaMirror closed this issue 2026-04-25 22:28:17 -05:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

revert-7033-patch-1

cached-config-operations

test_dylint

1.36.0

1.35.8

1.35.7

1.35.6

1.35.5

1.35.4

1.35.3

1.35.2

1.35.1

1.35.0

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

GiteaMirror ninjasurge

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#20321