[PR #4265] [MERGED] prevent side effects if groups are disabled #20233

New Issue

GiteaMirror · 2026-04-25T22:24:10-05:00

GiteaMirror commented

2026-04-25 22:24:10 -05:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/4265
Author: @stefan0xC
Created: 1/22/2024
Status: ✅ Merged
Merged: 1/25/2024
Merged by: @dani-garcia

Base: main ← Head: prevent-group-side-effects

📝 Commits (1)

4c69326 prevent side effects if groups are disabled

📊 Changes

4 files changed (+225 additions, -125 deletions)

View changed files

📝 src/api/core/ciphers.rs (+14 -7)
📝 src/api/core/organizations.rs (+1 -1)
📝 src/db/models/cipher.rs (+83 -43)
📝 src/db/models/collection.rs (+127 -74)

📄 Description

while working on #3754 I noticed that if I disable groups the collections and ciphers that I had access to via a group are still shown because the queries don't take into account if the groups are enabled or not.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4265 **Author:** [@stefan0xC](https://github.com/stefan0xC) **Created:** 1/22/2024 **Status:** ✅ Merged **Merged:** 1/25/2024 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `prevent-group-side-effects` --- ### 📝 Commits (1) - [`4c69326`](https://github.com/dani-garcia/vaultwarden/commit/4c69326a661219f2809172194cc85d0549c9eb76) prevent side effects if groups are disabled ### 📊 Changes **4 files changed** (+225 additions, -125 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/ciphers.rs` (+14 -7) 📝 `src/api/core/organizations.rs` (+1 -1) 📝 `src/db/models/cipher.rs` (+83 -43) 📝 `src/db/models/collection.rs` (+127 -74) </details> ### 📄 Description while working on #3754 I noticed that if I disable groups the collections and ciphers that I had access to via a group are still shown because the queries don't take into account if the groups are enabled or not. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 22:24:10 -05:00

GiteaMirror closed this issue

2026-04-25 22:24:11 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#20233