[PR #385] [MERGED] Retry updating revision - fixes #383 #19557

New Issue

Closed

opened 2026-04-25 22:03:47 -05:00 by GiteaMirror · 0 comments

GiteaMirror commented 2026-04-25 22:03:47 -05:00

Owner

Copy Link

Copy Source

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/385
Author: @mprasil
Created: 2/5/2019
Status: ✅ Merged
Merged: 2/5/2019
Merged by: @dani-garcia

Base: master ← Head: update_revision_retry

---

📝 Commits (5)

• bce656c Retry updating revision - fixes #383
• bd65c4e Remove superfluous cipher.save() call
• 1a5ecd4 cipher does not need to be mutable
• b3f7394 Do not update revision at the end, as we already did that
• 637f655 Do not allocate uneccessary Vec

📊 Changes

2 files changed (+8 additions, -7 deletions)

View changed files

📝 src/api/core/ciphers.rs (+2 -3)
📝 src/db/models/user.rs (+6 -4)

📄 Description

This should fix #383 (or any other mass operations that trigger a lot of updates)

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/385 **Author:** [@mprasil](https://github.com/mprasil) **Created:** 2/5/2019 **Status:** ✅ Merged **Merged:** 2/5/2019 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `update_revision_retry` --- ### 📝 Commits (5) - [`bce656c`](https://github.com/dani-garcia/vaultwarden/commit/bce656c7876bd33dd8db45966823ff2c5ab60066) Retry updating revision - fixes #383 - [`bd65c4e`](https://github.com/dani-garcia/vaultwarden/commit/bd65c4e312219c3165b6aef92183bc84c082e9ef) Remove superfluous cipher.save() call - [`1a5ecd4`](https://github.com/dani-garcia/vaultwarden/commit/1a5ecd4d4aaa3744b45d8e67c689335959f7cc1b) cipher does not need to be mutable - [`b3f7394`](https://github.com/dani-garcia/vaultwarden/commit/b3f7394c06f78fd0019947d6d82f21fedd7a7db5) Do not update revision at the end, as we already did that - [`637f655`](https://github.com/dani-garcia/vaultwarden/commit/637f655b6fe48fb8312b338d439a548911743057) Do not allocate uneccessary Vec ### 📊 Changes **2 files changed** (+8 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/ciphers.rs` (+2 -3) 📝 `src/db/models/user.rs` (+6 -4) </details> ### 📄 Description This should fix #383 (or any other mass operations that trigger a lot of updates) --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

GiteaMirror added the pull-request label 2026-04-25 22:03:47 -05:00

GiteaMirror closed this issue 2026-04-25 22:03:47 -05:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

v2-registration

revert-7033-patch-1

cached-config-operations

test_dylint

1.37.2

1.37.1

1.37.0

1.36.0

1.35.8

1.35.7

1.35.6

1.35.5

1.35.4

1.35.3

1.35.2

1.35.1

1.35.0

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

wontfix

No labels pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

GiteaMirror ninjasurge (Kaehlen Rog)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#19557