Currently we return 404 if WEB_VAULT_ENABLED is set to false and 500 if Vault is enabled. Upstream API responds with 404 for non-existent endpoints, so we should do the same.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/dani-garcia/vaultwarden/pull/92
**Author:** [@mprasil](https://github.com/mprasil)
**Created:** 7/18/2018
**Status:** ✅ Merged
**Merged:** 7/18/2018
**Merged by:** [@dani-garcia](https://github.com/dani-garcia)
**Base:** `master` ← **Head:** `not_found`
---
### 📝 Commits (2)
- [`233d23a`](https://github.com/dani-garcia/vaultwarden/commit/233d23a527f6eebd29324618e1c53de574256f39) Return 404 in case the path doesn't match instead of 500
- [`2dc1427`](https://github.com/dani-garcia/vaultwarden/commit/2dc1427027cb2c5436ec8ebc4d11d6b0964d803a) Bump the version
### 📊 Changes
**2 files changed** (+14 additions, -9 deletions)
<details>
<summary>View changed files</summary>
📝 `Cargo.toml` (+1 -1)
📝 `src/api/web.rs` (+13 -8)
</details>
### 📄 Description
Currently we return 404 if `WEB_VAULT_ENABLED` is set to `false` and 500 if Vault is enabled. Upstream API responds with 404 for non-existent endpoints, so we should do the same.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/92
Author: @mprasil
Created: 7/18/2018
Status: ✅ Merged
Merged: 7/18/2018
Merged by: @dani-garcia
Base:
master← Head:not_found📝 Commits (2)
233d23aReturn 404 in case the path doesn't match instead of 5002dc1427Bump the version📊 Changes
2 files changed (+14 additions, -9 deletions)
View changed files
📝
Cargo.toml(+1 -1)📝
src/api/web.rs(+13 -8)📄 Description
Currently we return 404 if
WEB_VAULT_ENABLEDis set tofalseand 500 if Vault is enabled. Upstream API responds with 404 for non-existent endpoints, so we should do the same.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.