github-starred/vaultwarden
2
0
Fork 0
mirror of https://github.com/dani-garcia/vaultwarden.git synced 2026-05-24 17:12:43 -05:00
Code Issues 307 Packages Projects Releases 83 Wiki Activity

[PR #6855] [CLOSED] add a config experimental_client_feature_flags_skip_validation #16697

New Issue
Closed
opened 2026-04-23 08:02:50 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 08:02:50 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/6855
Author: @phoeagon
Created: 2/21/2026
Status: ❌ Closed

Base: main ← Head: newb

📝 Commits (1)

  • acb2069 add a config experimental_client_feature_flags_skip_validation, that, when set, passes through all feature flags verbatim without validation. Useful for testing and eaerly adopters

📊 Changes

2 files changed (+17 additions, -6 deletions)

View changed files

📝 .env.template (+5 -0)
📝 src/config.rs (+12 -6)

📄 Description

add a config experimental_client_feature_flags_skip_validation, that, when set, passes through all feature flags verbatim without validation.

This is useful for testing and early adopters to test it out in their docker spaces, without waiting for an official binary change.

verified that this achieves the desired behavior:
https://gist.github.com/phoeagon/6e599a40001f452837ece1f967ae8e77

phoeagon@Zhes-Mac-mini vaultwarden % cargo run --features sqlite   
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.16s
     Running `target/debug/vaultwarden`
/--------------------------------------------------------------------\
|                        Starting Vaultwarden                        |
|--------------------------------------------------------------------|
| This is an *unofficial* Bitwarden implementation, DO NOT use the   |
| official channels to report bugs/features, regardless of client.   |
| Send usage/configuration questions or feature requests to:         |
|   https://github.com/dani-garcia/vaultwarden/discussions or        |
|   https://vaultwarden.discourse.group/                             |
| Report suspected bugs/issues in the software itself at:            |
|   https://github.com/dani-garcia/vaultwarden/issues/new            |
\--------------------------------------------------------------------/

[2026-02-20 20:31:46.550][start][INFO] Rocket has launched from http://127.0.0.1:8000
[2026-02-20 20:32:02.571][request][INFO] GET /api
[2026-02-20 20:32:02.571][response][INFO] 404 Not Found
^C[2026-02-20 20:32:48.560][vaultwarden][INFO] Exiting Vaultwarden!
[2026-02-20 20:32:48.560][rocket::server][WARN] Received SIGINT. Requesting shutdown.
^C[2026-02-20 20:32:50.455][rocket::server][WARN] Received SIGINT. Shutdown already in progress.
[2026-02-20 20:32:50.564][vaultwarden][INFO] Vaultwarden process exited!
phoeagon@Zhes-Mac-mini vaultwarden % export EXPERIMENTAL_CLIENT_FEATURE_FLAGS=non-exist
phoeagon@Zhes-Mac-mini vaultwarden % cargo run --features sqlite
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.19s
     Running `target/debug/vaultwarden`
/--------------------------------------------------------------------\
|                        Starting Vaultwarden                        |
|--------------------------------------------------------------------|
| This is an *unofficial* Bitwarden implementation, DO NOT use the   |
| official channels to report bugs/features, regardless of client.   |
| Send usage/configuration questions or feature requests to:         |
|   https://github.com/dani-garcia/vaultwarden/discussions or        |
|   https://vaultwarden.discourse.group/                             |
| Report suspected bugs/issues in the software itself at:            |
|   https://github.com/dani-garcia/vaultwarden/issues/new            |
\--------------------------------------------------------------------/

Error loading config:
  Unrecognized experimental client feature flags: ["non-exist"].

Please ensure all feature flags are spelled correctly and that they are supported in this version.
Supported flags: ["inline-menu-positioning-improvements", "inline-menu-totp", "ssh-agent", "ssh-key-vault-item", "pm-25373-windows-biometrics-v2", "export-attachments", "anon-addy-self-host-alias", "simple-login-self-host-alias", "mutual-tls"]

phoeagon@Zhes-Mac-mini vaultwarden % export EXPERIMENTAL_CLIENT_FEATURE_FLAGS_SKIP_VALIDATION=true
phoeagon@Zhes-Mac-mini vaultwarden % cargo run --features sqlite
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.17s
     Running `target/debug/vaultwarden`
/--------------------------------------------------------------------\
|                        Starting Vaultwarden                        |
|--------------------------------------------------------------------|
| This is an *unofficial* Bitwarden implementation, DO NOT use the   |
| official channels to report bugs/features, regardless of client.   |
| Send usage/configuration questions or feature requests to:         |
|   https://github.com/dani-garcia/vaultwarden/discussions or        |
|   https://vaultwarden.discourse.group/                             |
| Report suspected bugs/issues in the software itself at:            |
|   https://github.com/dani-garcia/vaultwarden/issues/new            |
\--------------------------------------------------------------------/

[2026-02-20 20:33:56.619][start][INFO] Rocket has launched from http://127.0.0.1:8000

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/6855 **Author:** [@phoeagon](https://github.com/phoeagon) **Created:** 2/21/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `newb` --- ### 📝 Commits (1) - [`acb2069`](https://github.com/dani-garcia/vaultwarden/commit/acb2069fe6f5533370f8aeede144d12782f998e2) add a config experimental_client_feature_flags_skip_validation, that, when set, passes through all feature flags verbatim without validation. Useful for testing and eaerly adopters ### 📊 Changes **2 files changed** (+17 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `.env.template` (+5 -0) 📝 `src/config.rs` (+12 -6) </details> ### 📄 Description add a config experimental_client_feature_flags_skip_validation, that, when set, passes through all feature flags verbatim without validation. This is useful for testing and early adopters to test it out in their docker spaces, without waiting for an official binary change. verified that this achieves the desired behavior: https://gist.github.com/phoeagon/6e599a40001f452837ece1f967ae8e77 ``` phoeagon@Zhes-Mac-mini vaultwarden % cargo run --features sqlite Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.16s Running `target/debug/vaultwarden` /--------------------------------------------------------------------\ | Starting Vaultwarden | |--------------------------------------------------------------------| | This is an *unofficial* Bitwarden implementation, DO NOT use the | | official channels to report bugs/features, regardless of client. | | Send usage/configuration questions or feature requests to: | | https://github.com/dani-garcia/vaultwarden/discussions or | | https://vaultwarden.discourse.group/ | | Report suspected bugs/issues in the software itself at: | | https://github.com/dani-garcia/vaultwarden/issues/new | \--------------------------------------------------------------------/ [2026-02-20 20:31:46.550][start][INFO] Rocket has launched from http://127.0.0.1:8000 [2026-02-20 20:32:02.571][request][INFO] GET /api [2026-02-20 20:32:02.571][response][INFO] 404 Not Found ^C[2026-02-20 20:32:48.560][vaultwarden][INFO] Exiting Vaultwarden! [2026-02-20 20:32:48.560][rocket::server][WARN] Received SIGINT. Requesting shutdown. ^C[2026-02-20 20:32:50.455][rocket::server][WARN] Received SIGINT. Shutdown already in progress. [2026-02-20 20:32:50.564][vaultwarden][INFO] Vaultwarden process exited! phoeagon@Zhes-Mac-mini vaultwarden % export EXPERIMENTAL_CLIENT_FEATURE_FLAGS=non-exist phoeagon@Zhes-Mac-mini vaultwarden % cargo run --features sqlite Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.19s Running `target/debug/vaultwarden` /--------------------------------------------------------------------\ | Starting Vaultwarden | |--------------------------------------------------------------------| | This is an *unofficial* Bitwarden implementation, DO NOT use the | | official channels to report bugs/features, regardless of client. | | Send usage/configuration questions or feature requests to: | | https://github.com/dani-garcia/vaultwarden/discussions or | | https://vaultwarden.discourse.group/ | | Report suspected bugs/issues in the software itself at: | | https://github.com/dani-garcia/vaultwarden/issues/new | \--------------------------------------------------------------------/ Error loading config: Unrecognized experimental client feature flags: ["non-exist"]. Please ensure all feature flags are spelled correctly and that they are supported in this version. Supported flags: ["inline-menu-positioning-improvements", "inline-menu-totp", "ssh-agent", "ssh-key-vault-item", "pm-25373-windows-biometrics-v2", "export-attachments", "anon-addy-self-host-alias", "simple-login-self-host-alias", "mutual-tls"] phoeagon@Zhes-Mac-mini vaultwarden % export EXPERIMENTAL_CLIENT_FEATURE_FLAGS_SKIP_VALIDATION=true phoeagon@Zhes-Mac-mini vaultwarden % cargo run --features sqlite Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.17s Running `target/debug/vaultwarden` /--------------------------------------------------------------------\ | Starting Vaultwarden | |--------------------------------------------------------------------| | This is an *unofficial* Bitwarden implementation, DO NOT use the | | official channels to report bugs/features, regardless of client. | | Send usage/configuration questions or feature requests to: | | https://github.com/dani-garcia/vaultwarden/discussions or | | https://vaultwarden.discourse.group/ | | Report suspected bugs/issues in the software itself at: | | https://github.com/dani-garcia/vaultwarden/issues/new | \--------------------------------------------------------------------/ [2026-02-20 20:33:56.619][start][INFO] Rocket has launched from http://127.0.0.1:8000 ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 08:02:50 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
better for forum
bug
documentation
duplicate
enhancement
future Vault
good first issue
help wanted
low priority
notes
pull-request
Mirrored from GitHub Pull Request
 question
SSO
Third party
troubleshooting
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#16697
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?