As reported in #6477, redirection of favicon's didn't allowed caching. This commit fixes this by adding the Cached wrapper around the response. It will use the same TTL's used for downloading icon's locally.
Also removed _ as valid domain character, these should not be used in FQDN's at all. Those only serve as special chars used in domain labels, mostly used in SRV or TXT records.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/dani-garcia/vaultwarden/pull/6487
**Author:** [@BlackDex](https://github.com/BlackDex)
**Created:** 11/23/2025
**Status:** ✅ Merged
**Merged:** 11/23/2025
**Merged by:** [@dani-garcia](https://github.com/dani-garcia)
**Base:** `main` ← **Head:** `icon-fixes`
---
### 📝 Commits (1)
- [`d54c17d`](https://github.com/dani-garcia/vaultwarden/commit/d54c17ddbe6ed1e91d11fa60fd03e23e5b19924d) Fix icon redirect caching
### 📊 Changes
**1 file changed** (+7 additions, -6 deletions)
<details>
<summary>View changed files</summary>
📝 `src/api/icons.rs` (+7 -6)
</details>
### 📄 Description
As reported in #6477, redirection of favicon's didn't allowed caching. This commit fixes this by adding the `Cached` wrapper around the response. It will use the same TTL's used for downloading icon's locally.
Also removed `_` as valid domain character, these should not be used in FQDN's at all. Those only serve as special chars used in domain labels, mostly used in SRV or TXT records.
Fixes #6477
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/6487
Author: @BlackDex
Created: 11/23/2025
Status: ✅ Merged
Merged: 11/23/2025
Merged by: @dani-garcia
Base:
main← Head:icon-fixes📝 Commits (1)
d54c17dFix icon redirect caching📊 Changes
1 file changed (+7 additions, -6 deletions)
View changed files
📝
src/api/icons.rs(+7 -6)📄 Description
As reported in #6477, redirection of favicon's didn't allowed caching. This commit fixes this by adding the
Cachedwrapper around the response. It will use the same TTL's used for downloading icon's locally.Also removed
_as valid domain character, these should not be used in FQDN's at all. Those only serve as special chars used in domain labels, mostly used in SRV or TXT records.Fixes #6477
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.