[PR #5072] [MERGED] Updates and collection management fixes #16400

New Issue

GiteaMirror · 2026-04-23T07:51:30-05:00

GiteaMirror commented

2026-04-23 07:51:30 -05:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/5072
Author: @BlackDex
Created: 10/11/2024
Status: ✅ Merged
Merged: 10/11/2024
Merged by: @dani-garcia

Base: main ← Head: updates-and-collection-fixes

📝 Commits (2)

0cc865e Fix collections not editable by managers
c749708 Update crates and GitHub Actions

📊 Changes

8 files changed (+175 additions, -183 deletions)

View changed files

📝 .github/workflows/build.yml (+1 -1)
📝 .github/workflows/hadolint.yml (+2 -2)
📝 .github/workflows/release.yml (+7 -7)
📝 .github/workflows/trivy.yml (+7 -4)
📝 Cargo.lock (+126 -163)
📝 Cargo.toml (+4 -4)
📝 src/api/core/organizations.rs (+2 -2)
📝 src/db/models/organization.rs (+26 -0)

📄 Description

Fix collections not editable by managers

Since a newer version of the web-vault we use manager were not able to create sub collections anymore.
This was because of some missing details in the response of some json objects.

This commit fixes this by using the to_json_details instead of the to_json

Fixes #5066
Fixes #5044

Update crates and GitHub Actions

Updated all the crates
Updated all the GHA dependencies
Configured the trivy workflow to only run on the main repo and not on forks
Also selected a random new scheduled date so it will not run at the same time as all other forks.
The two changes should help running this scan every day without failing, and also prevent the same for new or updated forks.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/5072 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 10/11/2024 **Status:** ✅ Merged **Merged:** 10/11/2024 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `updates-and-collection-fixes` --- ### 📝 Commits (2) - [`0cc865e`](https://github.com/dani-garcia/vaultwarden/commit/0cc865efdba323b8452a42194b0f6736d4633c13) Fix collections not editable by managers - [`c749708`](https://github.com/dani-garcia/vaultwarden/commit/c749708a5699e41354c96265b8c740c611d96f93) Update crates and GitHub Actions ### 📊 Changes **8 files changed** (+175 additions, -183 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+1 -1) 📝 `.github/workflows/hadolint.yml` (+2 -2) 📝 `.github/workflows/release.yml` (+7 -7) 📝 `.github/workflows/trivy.yml` (+7 -4) 📝 `Cargo.lock` (+126 -163) 📝 `Cargo.toml` (+4 -4) 📝 `src/api/core/organizations.rs` (+2 -2) 📝 `src/db/models/organization.rs` (+26 -0) </details> ### 📄 Description ## Fix collections not editable by managers Since a newer version of the web-vault we use manager were not able to create sub collections anymore. This was because of some missing details in the response of some json objects. This commit fixes this by using the `to_json_details` instead of the `to_json` Fixes #5066 Fixes #5044 ## Update crates and GitHub Actions - Updated all the crates - Updated all the GHA dependencies - Configured the trivy workflow to only run on the main repo and not on forks Also selected a random new scheduled date so it will not run at the same time as all other forks. The two changes should help running this scan every day without failing, and also prevent the same for new or updated forks. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-23 07:51:30 -05:00

GiteaMirror closed this issue

2026-04-23 07:51:32 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#16400