The migration can still fail because there is no default set. If the table contains values it will fail because there is no default set. Also removed all the backticks, they only causes issues
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4971
**Author:** [@BlackDex](https://github.com/BlackDex)
**Created:** 9/20/2024
**Status:** ✅ Merged
**Merged:** 9/20/2024
**Merged by:** [@dani-garcia](https://github.com/dani-garcia)
**Base:** `main` ← **Head:** `fix-2fa-sql-migration`
---
### 📝 Commits (1)
- [`d0e1b08`](https://github.com/dani-garcia/vaultwarden/commit/d0e1b08f31e925cdea14b0128ed704e887d4969a) Fix Device Type column for 2FA migration
### 📊 Changes
**5 files changed** (+73 additions, -96 deletions)
<details>
<summary>View changed files</summary>
📝 `Cargo.lock` (+67 -90)
📝 `Cargo.toml` (+3 -3)
📝 `migrations/mysql/2024-09-04-091351_use_device_type_for_mails/up.sql` (+1 -1)
📝 `migrations/postgresql/2024-09-04-091351_use_device_type_for_mails/up.sql` (+1 -1)
📝 `migrations/sqlite/2024-09-04-091351_use_device_type_for_mails/up.sql` (+1 -1)
</details>
### 📄 Description
The migration can still fail because there is no default set. If the table contains values it will fail because there is no default set. Also removed all the backticks, they only causes issues
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/4971
Author: @BlackDex
Created: 9/20/2024
Status: ✅ Merged
Merged: 9/20/2024
Merged by: @dani-garcia
Base:
main← Head:fix-2fa-sql-migration📝 Commits (1)
d0e1b08Fix Device Type column for 2FA migration📊 Changes
5 files changed (+73 additions, -96 deletions)
View changed files
📝
Cargo.lock(+67 -90)📝
Cargo.toml(+3 -3)📝
migrations/mysql/2024-09-04-091351_use_device_type_for_mails/up.sql(+1 -1)📝
migrations/postgresql/2024-09-04-091351_use_device_type_for_mails/up.sql(+1 -1)📝
migrations/sqlite/2024-09-04-091351_use_device_type_for_mails/up.sql(+1 -1)📄 Description
The migration can still fail because there is no default set. If the table contains values it will fail because there is no default set. Also removed all the backticks, they only causes issues
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.