[PR #4737] [MERGED] Update admin interface #16330

New Issue

Closed

opened 2026-04-23 07:48:33 -05:00 by GiteaMirror · 0 comments

GiteaMirror commented 2026-04-23 07:48:33 -05:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/4737
Author: @BlackDex
Created: 7/11/2024
Status: ✅ Merged
Merged: 7/12/2024
Merged by: @dani-garcia

Base: main ← Head: admin-fixes

---

📝 Commits (1)

• d756837 Update admin interface

📊 Changes

11 files changed (+95 additions, -67 deletions)

View changed files

📝 src/api/admin.rs (+9 -3)
📝 src/auth.rs (+30 -2)
📝 src/config.rs (+0 -27)
📝 src/static/scripts/admin.js (+2 -2)
📝 src/static/scripts/admin_diagnostics.js (+5 -5)
📝 src/static/scripts/admin_settings.js (+1 -1)
📝 src/static/scripts/admin_users.js (+4 -2)
📝 src/static/scripts/datatables.css (+2 -2)
📝 src/static/scripts/datatables.js (+35 -18)
📝 src/static/templates/admin/organizations.hbs (+1 -1)
📝 src/static/templates/admin/users.hbs (+6 -4)

📄 Description

• Updated datatables
• Set Cookie Secure flag if the connection is https
• Prevent possible XSS via Organization Name
  Converted all innerHTML and innerText to the Safe Sink version textContent
• Removed jsesc function as handlebars escapes all these chars already and more by default

Fixes: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-39926

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4737 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 7/11/2024 **Status:** ✅ Merged **Merged:** 7/12/2024 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `admin-fixes` --- ### 📝 Commits (1) - [`d756837`](https://github.com/dani-garcia/vaultwarden/commit/d7568371c5e00f19aa5925d68db751cbfb08d9a2) Update admin interface ### 📊 Changes **11 files changed** (+95 additions, -67 deletions) <details> <summary>View changed files</summary> 📝 `src/api/admin.rs` (+9 -3) 📝 `src/auth.rs` (+30 -2) 📝 `src/config.rs` (+0 -27) 📝 `src/static/scripts/admin.js` (+2 -2) 📝 `src/static/scripts/admin_diagnostics.js` (+5 -5) 📝 `src/static/scripts/admin_settings.js` (+1 -1) 📝 `src/static/scripts/admin_users.js` (+4 -2) 📝 `src/static/scripts/datatables.css` (+2 -2) 📝 `src/static/scripts/datatables.js` (+35 -18) 📝 `src/static/templates/admin/organizations.hbs` (+1 -1) 📝 `src/static/templates/admin/users.hbs` (+6 -4) </details> ### 📄 Description - Updated datatables - Set Cookie Secure flag if the connection is https - Prevent possible XSS via Organization Name Converted all `innerHTML` and `innerText` to the Safe Sink version `textContent` - Removed `jsesc` function as handlebars escapes all these chars already and more by default Fixes: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-39926 --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

GiteaMirror added the pull-request label 2026-04-23 07:48:33 -05:00

GiteaMirror closed this issue 2026-04-23 07:48:33 -05:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

revert-7033-patch-1

cached-config-operations

test_dylint

1.36.0

1.35.8

1.35.7

1.35.6

1.35.5

1.35.4

1.35.3

1.35.2

1.35.1

1.35.0

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

GiteaMirror ninjasurge

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#16330