mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-05-24 00:53:23 -05:00
Documentation insondistency concerning websocket notifications #1622
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/vaultwarden#1622
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sheerun on GitHub (Jul 1, 2023).
https://github.com/dani-garcia/vaultwarden/wiki/Enabling-WebSocket-notifications
It says "Note: The reason for this workaround is the lack of support for WebSockets from Rocket (though it's a planned feature), which forces us to launch a secondary server on a separate port."
I think it is not up do date because "it's a planned feature" links to https://github.com/SergioBenitez/Rocket/issues/90 which is closed
@BobWs commented on GitHub (Jul 2, 2023):
This was added to the wiki a long time ago...
@JeDaYoshi commented on GitHub (Jul 2, 2023):
It also doesn't mention that WebSocket support was directly added to the Rocket server.
However, it's currently only on beta, not on a stable release - although seems to be working well for me.
@ShlomiD83 commented on GitHub (Jul 2, 2023):
Hi all,
If I use WS on port 80 my chrome extension doesn't seem to update automatically.
If I use port 3012 everything works.
What am I doing wrong?