[PR #3754] [MERGED] Fix #3624: fix manager permission within groups #16182

New Issue

GiteaMirror · 2026-04-23T07:44:14-05:00

GiteaMirror commented

2026-04-23 07:44:14 -05:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/3754
Author: @matlink
Created: 8/4/2023
Status: ✅ Merged
Merged: 3/17/2024
Merged by: @dani-garcia

Base: main ← Head: 3624_manager_groups

📝 Commits (10+)

bb100df Fix #3624: fix manager permission within groups
f4e9857 Query returns UUID only
67732fe Fix issue when user is manager and in a group having access to all collections
a477a6f optimize condition check
704d9bd fix(groups): renaming and optimizations
7bc45a0 fix: wrong organization group membership detection
7c93866 Simplify group membership check
a41125d Remove unused statement
e858b96 improve check if the user has access via groups
92d2df9 improve comments for get_org_collections_details

📊 Changes

2 files changed (+59 additions, -18 deletions)

View changed files

📝 src/api/core/organizations.rs (+26 -18)
📝 src/db/models/group.rs (+33 -0)

📄 Description

Fix #3624 by checking if the user is member of a group that has access to the collection.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/3754 **Author:** [@matlink](https://github.com/matlink) **Created:** 8/4/2023 **Status:** ✅ Merged **Merged:** 3/17/2024 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `3624_manager_groups` --- ### 📝 Commits (10+) - [`bb100df`](https://github.com/dani-garcia/vaultwarden/commit/bb100df31a983ca0bfe56a3ad90bd4c6ddc81433) Fix #3624: fix manager permission within groups - [`f4e9857`](https://github.com/dani-garcia/vaultwarden/commit/f4e9857dfd73f80f3151649250fd360c4f0a9e80) Query returns UUID only - [`67732fe`](https://github.com/dani-garcia/vaultwarden/commit/67732fe5a1d60efe586928fc5c035adf04b35ce1) Fix issue when user is manager and in a group having access to all collections - [`a477a6f`](https://github.com/dani-garcia/vaultwarden/commit/a477a6f242cf776520b54c17b63f2b5df46fada3) optimize condition check - [`704d9bd`](https://github.com/dani-garcia/vaultwarden/commit/704d9bde1ede94eb882878cdf77002546c5332ce) fix(groups): renaming and optimizations - [`7bc45a0`](https://github.com/dani-garcia/vaultwarden/commit/7bc45a04f7024bf6d662df3faf67d2cebe142011) fix: wrong organization group membership detection - [`7c93866`](https://github.com/dani-garcia/vaultwarden/commit/7c938668afab467082cb05370605e4df58225afe) Simplify group membership check - [`a41125d`](https://github.com/dani-garcia/vaultwarden/commit/a41125d34f7530289aff11bca4eaac5c393cb95e) Remove unused statement - [`e858b96`](https://github.com/dani-garcia/vaultwarden/commit/e858b96ff1c53b2d631129368907ebf87be9640a) improve check if the user has access via groups - [`92d2df9`](https://github.com/dani-garcia/vaultwarden/commit/92d2df99f9c3ff66460580747b2394a1cc01b399) improve comments for get_org_collections_details ### 📊 Changes **2 files changed** (+59 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/organizations.rs` (+26 -18) 📝 `src/db/models/group.rs` (+33 -0) </details> ### 📄 Description Fix #3624 by checking if the user is member of a group that has access to the collection. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-23 07:44:14 -05:00

GiteaMirror closed this issue

2026-04-23 07:44:14 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#16182