Since many email clients don't load external images I was wondering if we should include the images as attachment instead.
Some drawbacks to this change:
Embedding the images as attachments makes the mails around ~5kb bigger.
If you change the templates vaultwarden would still attach the images to the mail.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/dani-garcia/vaultwarden/pull/2784
**Author:** [@stefan0xC](https://github.com/stefan0xC)
**Created:** 10/2/2022
**Status:** ✅ Merged
**Merged:** 10/19/2022
**Merged by:** [@dani-garcia](https://github.com/dani-garcia)
**Base:** `main` ← **Head:** `email-attach-images`
---
### 📝 Commits (2)
- [`ea19c22`](https://github.com/dani-garcia/vaultwarden/commit/ea19c2250e0812659461c8abaf8f1a85e69c7423) attach images to email
- [`4289663`](https://github.com/dani-garcia/vaultwarden/commit/4289663a1697bd8d78743e2c8eaef255cb811e1b) use static_files() for email attachments
### 📊 Changes
**7 files changed** (+71 additions, -6 deletions)
<details>
<summary>View changed files</summary>
📝 `.env.template` (+3 -0)
📝 `src/api/mod.rs` (+1 -0)
📝 `src/api/web.rs` (+1 -1)
📝 `src/config.rs` (+12 -0)
📝 `src/mail.rs` (+52 -3)
📝 `src/static/templates/email/email_footer.hbs` (+1 -1)
📝 `src/static/templates/email/email_header.hbs` (+1 -1)
</details>
### 📄 Description
Since many email clients don't load external images I was wondering if we should include the images as attachment instead.
Some drawbacks to this change:
- Embedding the images as attachments makes the mails around ~5kb bigger.
- If you change the templates vaultwarden would still attach the images to the mail.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/2784
Author: @stefan0xC
Created: 10/2/2022
Status: ✅ Merged
Merged: 10/19/2022
Merged by: @dani-garcia
Base:
main← Head:email-attach-images📝 Commits (2)
ea19c22attach images to email4289663use static_files() for email attachments📊 Changes
7 files changed (+71 additions, -6 deletions)
View changed files
📝
.env.template(+3 -0)📝
src/api/mod.rs(+1 -0)📝
src/api/web.rs(+1 -1)📝
src/config.rs(+12 -0)📝
src/mail.rs(+52 -3)📝
src/static/templates/email/email_footer.hbs(+1 -1)📝
src/static/templates/email/email_header.hbs(+1 -1)📄 Description
Since many email clients don't load external images I was wondering if we should include the images as attachment instead.
Some drawbacks to this change:
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.