Update BUILD.md to reflect changes to the web-vault build process
I switched to git clone instead of unpacking release archives because there is a git submodule (jslib) which is not packed into the archives. One could also download the specific commit archive of bitwarden/jslib for the release archive and unpack it into the jslib directory, but this would be a much more complex process, because we would also have to explain how to find the matching commit hash.
I also removed the instructions to change upstream files because npm run dist:selfhost already applies everything changed by the docker patch, if I'm not mistaken(See bitwarden/web/package.json for setting the env variables and services.modules.ts which uses it).
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/dani-garcia/vaultwarden/pull/151
**Author:** [@mqus](https://github.com/mqus)
**Created:** 8/23/2018
**Status:** ❌ Closed
**Base:** `master` ← **Head:** `patch-3`
---
### 📝 Commits (1)
- [`c3fe92e`](https://github.com/dani-garcia/vaultwarden/commit/c3fe92eb5d411226e186b517350f649d99decf0f) Update BUILD.md for web-vault 2.x.x
### 📊 Changes
**1 file changed** (+9 additions, -15 deletions)
<details>
<summary>View changed files</summary>
📝 `BUILD.md` (+9 -15)
</details>
### 📄 Description
Update BUILD.md to reflect changes to the web-vault build process
I switched to `git clone` instead of unpacking release archives because there is a git submodule (jslib) which is not packed into the archives. One could also download the specific commit archive of [bitwarden/jslib](https://github.com/bitwarden/jslib) for the release archive and unpack it into the `jslib` directory, but this would be a much more complex process, because we would also have to explain how to find the matching commit hash.
I also removed the instructions to change upstream files because `npm run dist:selfhost` already applies everything changed by the docker patch, if I'm not mistaken(See [bitwarden/web/package.json](https://github.com/bitwarden/web/blob/master/package.json#L15) for setting the env variables and [services.modules.ts](https://github.com/bitwarden/web/blob/master/src/app/services/services.module.ts#L127) which uses it).
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/151
Author: @mqus
Created: 8/23/2018
Status: ❌ Closed
Base:
master← Head:patch-3📝 Commits (1)
c3fe92eUpdate BUILD.md for web-vault 2.x.x📊 Changes
1 file changed (+9 additions, -15 deletions)
View changed files
📝
BUILD.md(+9 -15)📄 Description
Update BUILD.md to reflect changes to the web-vault build process
I switched to
git cloneinstead of unpacking release archives because there is a git submodule (jslib) which is not packed into the archives. One could also download the specific commit archive of bitwarden/jslib for the release archive and unpack it into thejslibdirectory, but this would be a much more complex process, because we would also have to explain how to find the matching commit hash.I also removed the instructions to change upstream files because
npm run dist:selfhostalready applies everything changed by the docker patch, if I'm not mistaken(See bitwarden/web/package.json for setting the env variables and services.modules.ts which uses it).🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.