[PR #7031] [MERGED] Rotate refresh-tokens on sstamp reset #12763

Closed
opened 2026-04-20 15:59:03 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/7031
Author: @BlackDex
Created: 3/29/2026
Status: Merged
Merged: 3/29/2026
Merged by: @dani-garcia

Base: mainHead: login-fixes


📝 Commits (1)

  • 9caedb8 Rotate refresh-tokens on sstamp reset

📊 Changes

6 files changed (+46 additions, -17 deletions)

View changed files

📝 src/api/admin.rs (+2 -2)
📝 src/api/core/accounts.rs (+16 -8)
📝 src/api/core/emergency_access.rs (+1 -1)
📝 src/api/core/organizations.rs (+2 -1)
📝 src/db/models/device.rs (+17 -1)
📝 src/db/models/user.rs (+8 -4)

📄 Description

When a security-stamp gets reset/rotated we should also rotate all device refresh-tokens to invalidate them. Else clients are still able to use old refresh tokens.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/7031 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 3/29/2026 **Status:** ✅ Merged **Merged:** 3/29/2026 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `login-fixes` --- ### 📝 Commits (1) - [`9caedb8`](https://github.com/dani-garcia/vaultwarden/commit/9caedb8c8a42782b47730a58266ff8d1ff125e8a) Rotate refresh-tokens on sstamp reset ### 📊 Changes **6 files changed** (+46 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `src/api/admin.rs` (+2 -2) 📝 `src/api/core/accounts.rs` (+16 -8) 📝 `src/api/core/emergency_access.rs` (+1 -1) 📝 `src/api/core/organizations.rs` (+2 -1) 📝 `src/db/models/device.rs` (+17 -1) 📝 `src/db/models/user.rs` (+8 -4) </details> ### 📄 Description When a security-stamp gets reset/rotated we should also rotate all device refresh-tokens to invalidate them. Else clients are still able to use old refresh tokens. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 15:59:03 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#12763