[PR #6160] [MERGED] make webauthn more optional #12593

New Issue

GiteaMirror · 2026-04-20T15:51:54-05:00

GiteaMirror commented

2026-04-20 15:51:54 -05:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/6160
Author: @stefan0xC
Created: 8/9/2025
Status: ✅ Merged
Merged: 8/26/2025
Merged by: @dani-garcia

Base: main ← Head: make-webauthn-optional

📝 Commits (2)

792499b make webauthn optional
1e36d8e hide passkey if domain is not set

📊 Changes

6 files changed (+33 additions, -57 deletions)

View changed files

📝 src/api/core/two_factor/webauthn.rs (+13 -39)
📝 src/api/identity.rs (+8 -16)
📝 src/api/web.rs (+1 -0)
📝 src/config.rs (+4 -0)
📝 src/main.rs (+0 -2)
📝 src/static/templates/scss/vaultwarden.scss.hbs (+7 -0)

📄 Description

I don't think that we need initialize webauthn on startup (which currently fails if you set DOMAIN to an IP address because webauthn requires a domain name as rp_id). I've also hidden it as an option if you have setup the domain to be an IP address.

This won't touch on the other issues that were reported but I do think that it's important that Vaultwarden can start with something like DOMAIN=http://127.0.0.1:8000.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/6160 **Author:** [@stefan0xC](https://github.com/stefan0xC) **Created:** 8/9/2025 **Status:** ✅ Merged **Merged:** 8/26/2025 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `make-webauthn-optional` --- ### 📝 Commits (2) - [`792499b`](https://github.com/dani-garcia/vaultwarden/commit/792499b1c1931aec09388ea8498301c16c85c407) make webauthn optional - [`1e36d8e`](https://github.com/dani-garcia/vaultwarden/commit/1e36d8e72279d0c9c2fedf5752502ecfb7eac8c9) hide passkey if domain is not set ### 📊 Changes **6 files changed** (+33 additions, -57 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/two_factor/webauthn.rs` (+13 -39) 📝 `src/api/identity.rs` (+8 -16) 📝 `src/api/web.rs` (+1 -0) 📝 `src/config.rs` (+4 -0) 📝 `src/main.rs` (+0 -2) 📝 `src/static/templates/scss/vaultwarden.scss.hbs` (+7 -0) </details> ### 📄 Description I don't think that we need initialize webauthn on startup (which currently fails if you set `DOMAIN` to an IP address because [webauthn requires a domain name as `rp_id`](https://www.w3.org/TR/webauthn-2/#relying-party-identifier)). I've also hidden it as an option if you have setup the [domain](https://docs.rs/url/2.5.4/url/struct.Url.html#method.domain) to be an IP address. This won't touch on the other issues that were reported but I do think that it's important that Vaultwarden can start with something like `DOMAIN=http://127.0.0.1:8000`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 15:51:54 -05:00

GiteaMirror closed this issue

2026-04-20 15:51:55 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#12593