[PR #5321] [MERGED] fix group issue in send_invite #12463

New Issue

GiteaMirror · 2026-04-20T15:45:53-05:00

GiteaMirror commented

2026-04-20 15:45:53 -05:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/5321
Author: @stefan0xC
Created: 12/22/2024
Status: ✅ Merged
Merged: 12/31/2024
Merged by: @BlackDex

Base: main ← Head: fix-send-invite

📝 Commits (1)

fa15662 fix group issue in send_invite

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/api/core/organizations.rs (+1 -1)

📄 Description

As pointed out in #5320 we have a small bug in this call:

For example I noticed that we are passing the wrong id here:

ed4ad67e73/src/api/core/organizations.rs (L910)

Because in contrast to CollectionUser the GroupUser::new actually expects a different id:

ed4ad67e73/src/db/models/group.rs (L122)
This was probably overlooked because it's not a major issue when a user is not correctly invited to a group and it only shows up as a small warning in the logs:
[2024-12-22 21:23:47.022][request][INFO] POST /api/organizations/152bd996-19f9-40ee-b991-e52333a7e719/users/invite
[2024-12-22 21:23:47.031][vaultwarden::db::models::group][WARN] User could not be found!
[2024-12-22 21:23:48.082][response][INFO] (send_invite) POST /api/organizations/<org_id>/users/invite => 200 OK

Since reviewing my other PR will probably take a while this is a separate fix to address this one issue I found and remembered.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/5321 **Author:** [@stefan0xC](https://github.com/stefan0xC) **Created:** 12/22/2024 **Status:** ✅ Merged **Merged:** 12/31/2024 **Merged by:** [@BlackDex](https://github.com/BlackDex) **Base:** `main` ← **Head:** `fix-send-invite` --- ### 📝 Commits (1) - [`fa15662`](https://github.com/dani-garcia/vaultwarden/commit/fa156626ea6feedb78def23d9bd8cf1cdbe80585) fix group issue in send_invite ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/organizations.rs` (+1 -1) </details> ### 📄 Description As pointed out in #5320 we have a small bug in this call: > For example I noticed that we are passing the wrong id here: > > https://github.com/dani-garcia/vaultwarden/blob/ed4ad67e732c213beaec78970cdb68e48bee3dc1/src/api/core/organizations.rs#L910 > > Because in contrast to `CollectionUser` the `GroupUser::new` actually expects a different id: > > https://github.com/dani-garcia/vaultwarden/blob/ed4ad67e732c213beaec78970cdb68e48bee3dc1/src/db/models/group.rs#L122 > This was probably overlooked because it's not a major issue when a user is not correctly invited to a group and it only shows up as a small warning in the logs: > > ``` > [2024-12-22 21:23:47.022][request][INFO] POST /api/organizations/152bd996-19f9-40ee-b991-e52333a7e719/users/invite > [2024-12-22 21:23:47.031][vaultwarden::db::models::group][WARN] User could not be found! > [2024-12-22 21:23:48.082][response][INFO] (send_invite) POST /api/organizations/<org_id>/users/invite => 200 OK > ``` Since reviewing my other PR will probably take a while this is a separate fix to address this one issue I found and remembered. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 15:45:53 -05:00

GiteaMirror closed this issue

2026-04-20 15:45:53 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#12463