The reprompt value somehow sometimes has a value of 4. This isn't a valid value, and doesn't cause issues with other clients, but the native clients are more strict.
This commit fixes this by validating the value before storing and returning.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/dani-garcia/vaultwarden/pull/5259
**Author:** [@BlackDex](https://github.com/BlackDex)
**Created:** 12/6/2024
**Status:** ✅ Merged
**Merged:** 12/8/2024
**Merged by:** [@dani-garcia](https://github.com/dani-garcia)
**Base:** `main` ← **Head:** `fix-sync`
---
### 📝 Commits (1)
- [`565d3e6`](https://github.com/dani-garcia/vaultwarden/commit/565d3e699331f291b6515f4c52239fce46780f25) Fix another sync issue with native clients
### 📊 Changes
**3 files changed** (+4 additions, -5 deletions)
<details>
<summary>View changed files</summary>
📝 `src/api/core/ciphers.rs` (+1 -1)
📝 `src/db/models/cipher.rs` (+2 -3)
📝 `src/db/models/mod.rs` (+1 -1)
</details>
### 📄 Description
The `reprompt` value somehow sometimes has a value of `4`. This isn't a valid value, and doesn't cause issues with other clients, but the native clients are more strict.
This commit fixes this by validating the value before storing and returning.
Fixes #5237
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/5259
Author: @BlackDex
Created: 12/6/2024
Status: ✅ Merged
Merged: 12/8/2024
Merged by: @dani-garcia
Base:
main← Head:fix-sync📝 Commits (1)
565d3e6Fix another sync issue with native clients📊 Changes
3 files changed (+4 additions, -5 deletions)
View changed files
📝
src/api/core/ciphers.rs(+1 -1)📝
src/db/models/cipher.rs(+2 -3)📝
src/db/models/mod.rs(+1 -1)📄 Description
The
repromptvalue somehow sometimes has a value of4. This isn't a valid value, and doesn't cause issues with other clients, but the native clients are more strict.This commit fixes this by validating the value before storing and returning.
Fixes #5237
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.