We have way too many Dockerfiles in the root dir of the repo. The plan here is to:
split the Dockerfiles into subdirectories and just leave symlink to docker/amd64/sqlite/Dockerfile to have the "default" Dockerfile present in the repository root. (done in this PR)
update the docker hub configuration and point to specific Dockerfile for each architecture and feature
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/dani-garcia/vaultwarden/pull/514
**Author:** [@mprasil](https://github.com/mprasil)
**Created:** 6/24/2019
**Status:** ✅ Merged
**Merged:** 6/26/2019
**Merged by:** [@dani-garcia](https://github.com/dani-garcia)
**Base:** `master` ← **Head:** `dockerfile_cleanup`
---
### 📝 Commits (3)
- [`dd0b847`](https://github.com/dani-garcia/vaultwarden/commit/dd0b84791253acb2178e72c4f386f8f255b4d4c7) Move current dockerfiles to their arch folders
- [`d10ef3f`](https://github.com/dani-garcia/vaultwarden/commit/d10ef3fd4b7b9b2554568324cef6e29a6e20dd39) Create Dockerfiles for mysql builds
- [`9671ed4`](https://github.com/dani-garcia/vaultwarden/commit/9671ed4cca50e621cf18066292928ccb4e04594e) Symlink amd64 Dockerfile to repo root
### 📊 Changes
**11 files changed** (+564 additions, -96 deletions)
<details>
<summary>View changed files</summary>
➖ `Dockerfile` (+0 -96)
➕ `Dockerfile` (+1 -0)
➕ `docker/aarch64/mysql/Dockerfile` (+97 -0)
📝 `docker/aarch64/sqlite/Dockerfile` (+0 -0)
➕ `docker/amd64/mysql/Dockerfile` (+96 -0)
➕ `docker/amd64/mysql/Dockerfile.alpine` (+79 -0)
➕ `docker/amd64/sqlite/Dockerfile` (+96 -0)
📝 `docker/amd64/sqlite/Dockerfile.alpine` (+0 -0)
➕ `docker/armv6/mysql/Dockerfile` (+97 -0)
📝 `docker/armv6/sqlite/Dockerfile` (+0 -0)
➕ `docker/armv7/mysql/Dockerfile` (+98 -0)
📝 `docker/armv7/sqlite/Dockerfile` (+0 -0)
</details>
### 📄 Description
We have way too many Dockerfiles in the root dir of the repo. The plan here is to:
1. split the Dockerfiles into subdirectories and just leave symlink to `docker/amd64/sqlite/Dockerfile` to have the "default" Dockerfile present in the repository root. (done in this PR)
2. update the docker hub configuration and point to specific Dockerfile for each architecture and feature
3. update any outdated documentation if there's any
This should also allow us to easily fix #512.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/514
Author: @mprasil
Created: 6/24/2019
Status: ✅ Merged
Merged: 6/26/2019
Merged by: @dani-garcia
Base:
master← Head:dockerfile_cleanup📝 Commits (3)
dd0b847Move current dockerfiles to their arch foldersd10ef3fCreate Dockerfiles for mysql builds9671ed4Symlink amd64 Dockerfile to repo root📊 Changes
11 files changed (+564 additions, -96 deletions)
View changed files
➖
Dockerfile(+0 -96)➕
Dockerfile(+1 -0)➕
docker/aarch64/mysql/Dockerfile(+97 -0)📝
docker/aarch64/sqlite/Dockerfile(+0 -0)➕
docker/amd64/mysql/Dockerfile(+96 -0)➕
docker/amd64/mysql/Dockerfile.alpine(+79 -0)➕
docker/amd64/sqlite/Dockerfile(+96 -0)📝
docker/amd64/sqlite/Dockerfile.alpine(+0 -0)➕
docker/armv6/mysql/Dockerfile(+97 -0)📝
docker/armv6/sqlite/Dockerfile(+0 -0)➕
docker/armv7/mysql/Dockerfile(+98 -0)📝
docker/armv7/sqlite/Dockerfile(+0 -0)📄 Description
We have way too many Dockerfiles in the root dir of the repo. The plan here is to:
docker/amd64/sqlite/Dockerfileto have the "default" Dockerfile present in the repository root. (done in this PR)This should also allow us to easily fix #512.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.