Bitwarden invite emails are failing DKIM checks because one of the lines in the HTML template ends up being > 1000 characters, while the SMTP spec sets the max line length at 1000. Postfix ends up adding a newline at the 1,000th character, which causes the body to change and thus the DKIM signature to fail.
This PR fixes this problem by adding a line break to separate some of the HTML attributes from the invite token link, which shortens the line and allows it to pass DKIM checks.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/dani-garcia/vaultwarden/pull/437
**Author:** [@njfox](https://github.com/njfox)
**Created:** 3/21/2019
**Status:** ✅ Merged
**Merged:** 3/21/2019
**Merged by:** [@dani-garcia](https://github.com/dani-garcia)
**Base:** `master` ← **Head:** `fix-smtp-error`
---
### 📝 Commits (2)
- [`5ee9676`](https://github.com/dani-garcia/vaultwarden/commit/5ee96769411b083b3e20b73103a2319c4d97c296) Break up long line to stop SMTP from breaking
- [`7976d39`](https://github.com/dani-garcia/vaultwarden/commit/7976d39d9db75eae481b7e6ddca2ae4eea47951d) Adjust whitespace
### 📊 Changes
**1 file changed** (+2 additions, -1 deletions)
<details>
<summary>View changed files</summary>
📝 `src/static/templates/email/send_org_invite.html.hbs` (+2 -1)
</details>
### 📄 Description
Bitwarden invite emails are failing DKIM checks because one of the lines in the HTML template ends up being > 1000 characters, while the SMTP spec sets the max line length at 1000. Postfix ends up adding a newline at the 1,000th character, which causes the body to change and thus the DKIM signature to fail.
This PR fixes this problem by adding a line break to separate some of the HTML attributes from the invite token link, which shortens the line and allows it to pass DKIM checks.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/437
Author: @njfox
Created: 3/21/2019
Status: ✅ Merged
Merged: 3/21/2019
Merged by: @dani-garcia
Base:
master← Head:fix-smtp-error📝 Commits (2)
5ee9676Break up long line to stop SMTP from breaking7976d39Adjust whitespace📊 Changes
1 file changed (+2 additions, -1 deletions)
View changed files
📝
src/static/templates/email/send_org_invite.html.hbs(+2 -1)📄 Description
Bitwarden invite emails are failing DKIM checks because one of the lines in the HTML template ends up being > 1000 characters, while the SMTP spec sets the max line length at 1000. Postfix ends up adding a newline at the 1,000th character, which causes the body to change and thus the DKIM signature to fail.
This PR fixes this problem by adding a line break to separate some of the HTML attributes from the invite token link, which shortens the line and allows it to pass DKIM checks.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.