Android might add trailing space to email on login input
Deployment environment
vaultwarden version: 1.24.0
Install method: Docker Compose
Clients used: Android Client
Reverse proxy and version: traefik v2
PostgreSQL version: PostgreSQL 11.15 (Debian 11.15-1.pgdg90+1) on x86_64-pc-linux-gnu
Other relevant details:
Steps to reproduce
Using gboard auto completion on first login and/or after disconnecting the account
The email address input might have a trailing space.
Perform the login and you will get an authentication error.
The "issue" is not easily visible
looking in vaultwarden logs you find the error: [2022-03-02 22:12:09.086][vaultwarden::api::identity][ERROR] Username or password is incorrect. Try again. IP: x.x.x.x. Username: xxxxxx@gmail.com .
Server perform trim on input email berfore looking for the user in the database.
Actual behaviour
Login is rejected
Troubleshooting data
Originally created by @hitech95 on GitHub (Mar 2, 2022).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/2348
<!--
# ###
NOTE: Please update to the latest version of vaultwarden before reporting an issue!
This saves you and us a lot of time and troubleshooting.
See:
* https://github.com/dani-garcia/vaultwarden/issues/1180
* https://github.com/dani-garcia/vaultwarden/wiki/Updating-the-vaultwarden-image
# ###
-->
<!--
Please fill out the following template to make solving your problem easier and faster for us.
This is only a guideline. If you think that parts are unnecessary for your issue, feel free to remove them.
Remember to hide/redact personal or confidential information,
such as passwords, IP addresses, and DNS names as appropriate.
-->
### Subject of the issue
Android might add trailing space to email on login input
### Deployment environment
<!--
=========================================================================================
Preferably, use the `Generate Support String` button on the admin page's Diagnostics tab.
That will auto-generate most of the info requested in this section.
=========================================================================================
-->
<!-- The version number, obtained from the logs (at startup) or the admin diagnostics page -->
<!-- This is NOT the version number shown on the web vault, which is versioned separately from vaultwarden -->
<!-- Remember to check if your issue exists on the latest version first! -->
* vaultwarden version: 1.24.0
<!-- How the server was installed: Docker image, OS package, built from source, etc. -->
* Install method: Docker Compose
* Clients used: Android Client
* Reverse proxy and version: traefik v2
* PostgreSQL version: PostgreSQL 11.15 (Debian 11.15-1.pgdg90+1) on x86_64-pc-linux-gnu
* Other relevant details:
### Steps to reproduce
<!-- Tell us how to reproduce this issue. What parameters did you set (differently from the defaults)
and how did you start vaultwarden? -->
- Using gboard auto completion on first login and/or after disconnecting the account
- The email address input might have a trailing space.
- Perform the login and you will get an authentication error.
- The "issue" is not easily visible
- looking in vaultwarden logs you find the error:
`[2022-03-02 22:12:09.086][vaultwarden::api::identity][ERROR] Username or password is incorrect. Try again. IP: x.x.x.x. Username: xxxxxx@gmail.com .`
- Note that the trailing dot is not attached to the email address as in the template:
https://github.com/dani-garcia/vaultwarden/blob/main/src/api/identity.rs#L104
The issue seems not to be present using the official server. (I have not tried with self hosted one)
### Expected behaviour
<!-- Tell us what you expected to happen -->
Server perform trim on input email berfore looking for the user in the database.
### Actual behaviour
<!-- Tell us what actually happened -->
Login is rejected
### Troubleshooting data
<!-- Share any log files, screenshots, or other relevant troubleshooting data -->
Can reproduce on web vault too. Since autocomplete is happy to do this, it's probably best user-experience speaking if it is trimmed, for safety.
(For some reason though, /api/accounts/prelogin sends { email: "test@example.com" } while /identity/connect/token sends { "username": "test@example.com " }. Weird.)
<!-- gh-comment-id:1058016172 -->
@jeda commented on GitHub (Mar 3, 2022):
Can reproduce on web vault too. Since autocomplete is happy to do this, it's probably best user-experience speaking if it is trimmed, for safety.
(For some reason though, `/api/accounts/prelogin` sends `{ email: "test@example.com" }` while `/identity/connect/token` sends `{ "username": "test@example.com " }`. Weird.)
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Originally created by @hitech95 on GitHub (Mar 2, 2022).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/2348
Subject of the issue
Android might add trailing space to email on login input
Deployment environment
Install method: Docker Compose
Clients used: Android Client
Reverse proxy and version: traefik v2
PostgreSQL version: PostgreSQL 11.15 (Debian 11.15-1.pgdg90+1) on x86_64-pc-linux-gnu
Other relevant details:
Steps to reproduce
[2022-03-02 22:12:09.086][vaultwarden::api::identity][ERROR] Username or password is incorrect. Try again. IP: x.x.x.x. Username: xxxxxx@gmail.com .https://github.com/dani-garcia/vaultwarden/blob/main/src/api/identity.rs#L104
The issue seems not to be present using the official server. (I have not tried with self hosted one)
Expected behaviour
Server perform trim on input email berfore looking for the user in the database.
Actual behaviour
Login is rejected
Troubleshooting data
@jeda commented on GitHub (Mar 3, 2022):
Can reproduce on web vault too. Since autocomplete is happy to do this, it's probably best user-experience speaking if it is trimmed, for safety.
(For some reason though,
/api/accounts/preloginsends{ email: "test@example.com" }while/identity/connect/tokensends{ "username": "test@example.com " }. Weird.)