[PR #748] feat: add NATS template #9944

New Issue

GiteaMirror · 2026-06-05T09:14:53-05:00

GiteaMirror commented

2026-06-05 09:14:53 -05:00

📋 Pull Request Information

Original PR: https://github.com/Dokploy/templates/pull/748
Author: @quochuydev
Created: 3/18/2026
Status: 🔄 Open

Base: canary ← Head: feat/add-natsio-template

📝 Commits (3)

44d8b2c feat: add NATS template with auth token and WebSocket support
46fff77 fix: remove duplicate strapi entry from meta.json
70bb6fa fix: fix nats config file mount and add example domains in template

📊 Changes

4 files changed (+66 additions, -18 deletions)

View changed files

➕ blueprints/nats/docker-compose.yml (+17 -0)
➕ blueprints/nats/nats.jpeg (+0 -0)
➕ blueprints/nats/template.toml (+32 -0)
📝 meta.json (+17 -18)

📄 Description

What is this PR about?

New PR of NATS — a high-performance, open-source messaging system for cloud-native applications, IoT, and microservices.

Checklist

Before submitting this PR, please make sure that:

I have read the suggestions in the README.md file https://github.com/Dokploy/templates?tab=readme-ov-file#general-requirements-when-creating-a-template
I have tested the template in my instance, so the maintainers don't spend time trying to figure out what's wrong.
I have added tests that demonstrate that my correction works or that my new feature works.

Screenshots or Videos

Greptile Summary

This PR adds a new NATS messaging broker template (blueprints/nats/) with a pinned Docker image (nats:2.10.24-alpine), a config file mount that enables token-based authentication and WebSocket support, monitoring and WebSocket domains, and registers the template in meta.json. The template structure is sound and consistent with repository conventions.

Key issues found:

Accidental Strapi deletion: The entire Strapi entry was removed from meta.json — this is unrelated to the NATS PR and appears to be caused by a merge conflict or outdated base branch. The blueprints/strapi/ directory still exists, so Strapi would silently disappear from the template registry.
Unused data volume: nats-data:/data is mounted in docker-compose.yml but the nats.conf does not include a store_dir directive, so the volume will never be written to unless JetStream is manually configured post-deploy.
Logo format: A JPEG (nats.jpeg) is used instead of the preferred SVG format per contribution guidelines.

Confidence Score: 2/5

Not safe to merge — the accidental Strapi entry deletion from meta.json must be resolved first.
The NATS blueprint itself is well-structured and follows conventions, but the unintentional removal of the Strapi entry from meta.json is a blocking issue. Merging as-is would silently remove a working template from the registry without any corresponding blueprint deletion.
meta.json requires immediate attention to restore the accidentally deleted Strapi entry.

Comments Outside Diff (2)

meta.json, line 5969-5984 (link)

Accidental Strapi entry deletion

This PR removes the entire Strapi entry from meta.json, but the PR description only mentions adding the NATS template. This appears to be an accidental deletion — possibly caused by a merge conflict or working off an outdated base branch.

The blueprints/strapi/ directory still exists in the repository, so removing its metadata entry would make it disappear from the template registry without removing the underlying blueprint. Please restore the Strapi entry.
blueprints/nats/nats.jpeg, line 1 (link)

Logo should prefer SVG format

Per the project's contribution guidelines (AGENTS.md), logos should be SVG format at approximately 128×128px. A JPEG logo may appear blurry or pixelated at different display sizes. Consider replacing nats.jpeg with an SVG version — the official NATS logo is available as an SVG from the NATS branding resources.

Rule Used: AGENTS.md (source)

_{Last reviewed commit: "feat: add NATS templ..."}

Greptile also left 1 inline comment on this PR.

Context used:

Rule used - AGENTS.md (source)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Dokploy/templates/pull/748 **Author:** [@quochuydev](https://github.com/quochuydev) **Created:** 3/18/2026 **Status:** 🔄 Open **Base:** `canary` ← **Head:** `feat/add-natsio-template` --- ### 📝 Commits (3) - [`44d8b2c`](https://github.com/Dokploy/templates/commit/44d8b2cd896265af9295fb532cca9249d878b64d) feat: add NATS template with auth token and WebSocket support - [`46fff77`](https://github.com/Dokploy/templates/commit/46fff77fb92c720c95c3d16f65a880736f762f2b) fix: remove duplicate strapi entry from meta.json - [`70bb6fa`](https://github.com/Dokploy/templates/commit/70bb6fa612e7f1e85eed01aced1386de425d5a5c) fix: fix nats config file mount and add example domains in template ### 📊 Changes **4 files changed** (+66 additions, -18 deletions) <details> <summary>View changed files</summary> ➕ `blueprints/nats/docker-compose.yml` (+17 -0) ➕ `blueprints/nats/nats.jpeg` (+0 -0) ➕ `blueprints/nats/template.toml` (+32 -0) 📝 `meta.json` (+17 -18) </details> ### 📄 Description ## What is this PR about? New PR of NATS — a high-performance, open-source messaging system for cloud-native applications, IoT, and microservices. ## Checklist Before submitting this PR, please make sure that: - [x] I have read the suggestions in the README.md file https://github.com/Dokploy/templates?tab=readme-ov-file#general-requirements-when-creating-a-template - [x] I have tested the template in my instance, so the maintainers don't spend time trying to figure out what's wrong. - [x] I have added tests that demonstrate that my correction works or that my new feature works. ## Screenshots or Videos  <h3>Greptile Summary</h3> This PR adds a new NATS messaging broker template (`blueprints/nats/`) with a pinned Docker image (`nats:2.10.24-alpine`), a config file mount that enables token-based authentication and WebSocket support, monitoring and WebSocket domains, and registers the template in `meta.json`. The template structure is sound and consistent with repository conventions. **Key issues found:** - **Accidental Strapi deletion**: The entire Strapi entry was removed from `meta.json` — this is unrelated to the NATS PR and appears to be caused by a merge conflict or outdated base branch. The `blueprints/strapi/` directory still exists, so Strapi would silently disappear from the template registry. - **Unused data volume**: `nats-data:/data` is mounted in `docker-compose.yml` but the `nats.conf` does not include a `store_dir` directive, so the volume will never be written to unless JetStream is manually configured post-deploy. - **Logo format**: A JPEG (`nats.jpeg`) is used instead of the preferred SVG format per contribution guidelines. <h3>Confidence Score: 2/5</h3> - Not safe to merge — the accidental Strapi entry deletion from meta.json must be resolved first. - The NATS blueprint itself is well-structured and follows conventions, but the unintentional removal of the Strapi entry from meta.json is a blocking issue. Merging as-is would silently remove a working template from the registry without any corresponding blueprint deletion. - meta.json requires immediate attention to restore the accidentally deleted Strapi entry.  <details><summary><h3>Comments Outside Diff (2)</h3></summary> 1. `meta.json`, line 5969-5984 ([link](https://github.com/dokploy/templates/blob/383ea566c312b8f5cf76aea6c3d883ac48991c55/meta.json#L5969-L5984)) <a href="#"><img alt="P2" src="https://greptile-static-assets.s3.amazonaws.com/badges/p2.svg?v=7" align="top"></a> **Accidental Strapi entry deletion** This PR removes the entire Strapi entry from `meta.json`, but the PR description only mentions adding the NATS template. This appears to be an accidental deletion — possibly caused by a merge conflict or working off an outdated base branch. The `blueprints/strapi/` directory still exists in the repository, so removing its metadata entry would make it disappear from the template registry without removing the underlying blueprint. Please restore the Strapi entry. 2. `blueprints/nats/nats.jpeg`, line 1 ([link](https://github.com/dokploy/templates/blob/383ea566c312b8f5cf76aea6c3d883ac48991c55/blueprints/nats/nats.jpeg#L1)) <a href="#"><img alt="P2" src="https://greptile-static-assets.s3.amazonaws.com/badges/p2.svg?v=7" align="top"></a> **Logo should prefer SVG format** Per the project's contribution guidelines (AGENTS.md), logos should be SVG format at approximately 128×128px. A JPEG logo may appear blurry or pixelated at different display sizes. Consider replacing `nats.jpeg` with an SVG version — the official NATS logo is available as an SVG from the NATS branding resources. **Rule Used:** AGENTS.md ([source](https://app.greptile.com/review/custom-context?memory=09330bde-2058-497c-9c64-ceae637fb5b2)) </details>  <sub>Last reviewed commit: ["feat: add NATS templ..."](https://github.com/dokploy/templates/commit/383ea566c312b8f5cf76aea6c3d883ac48991c55)</sub> > Greptile also left **1 inline comment** on this PR. **Context used:** - Rule used - AGENTS.md ([source](https://app.greptile.com/review/custom-context?memory=09330bde-2058-497c-9c64-ceae637fb5b2))  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-06-05 09:14:53 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/templates#9944