github-starred/templates
2
0
Fork 1
mirror of https://github.com/Dokploy/templates.git synced 2026-07-17 06:36:23 -05:00
Code Issues 3.0k Packages Projects Releases Wiki Activity

[PR #665] [MERGED] Added the frappe lending template #7904

New Issue
Closed
opened 2026-05-21 23:20:34 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-21 23:20:34 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/Dokploy/templates/pull/665
Author: @Harikrishnan1367709
Created: 1/19/2026
Status: ✅ Merged
Merged: 5/12/2026
Merged by: @Siumauricio

Base: canary ← Head: Add-Frappe-lending-Template

📝 Commits (2)

  • b1fc223 added the frappe lending template
  • 9c637bb removed the external network

📊 Changes

4 files changed (+599 additions, -0 deletions)

View changed files

➕ blueprints/frappe-lending/docker-compose.yml (+550 -0)
➕ blueprints/frappe-lending/frappe-lending.png (+0 -0)
➕ blueprints/frappe-lending/template.toml (+29 -0)
📝 meta.json (+20 -0)

📄 Description

Description

Adds Frappe Lending template - a loan management system built on Frappe Framework for managing loans, repayments, and lending operations.

Technical Details

  • Base Image: frappe/erpnext:v15
  • Apps: ERPNext + Lending
  • Services: Backend, Frontend (Nginx), MariaDB, Redis, Queue Workers
  • Port: 8080
Screenshot 2026-01-13 at 5 55 37 PM

Greptile Summary

Added Frappe Lending template - a loan management system built on Frappe Framework for managing loans, repayments, and lending operations.

Key changes:

  • New blueprint directory with docker-compose.yml, template.toml, and logo
  • Configured services: backend, frontend (Nginx), MariaDB, Redis, queue workers (default, long, short), scheduler, websocket
  • Added configurator and create-site services for initial setup
  • Configured lending app installation and site creation logic
  • Added entry to meta.json with appropriate tags

Issues identified:

  • Missing version: "3.8" field at the start of docker-compose.yml (required by style guide)
  • Using VERSION=latest in template.toml and meta.json instead of pinning to specific version like v15

Positive aspects:

  • Correctly avoids using networks (unlike other frappe templates in the repo)
  • Correctly avoids using ports and container_name directives
  • Proper use of volumes for data persistence
  • Comprehensive healthchecks and service dependencies

Confidence Score: 4/5

  • This PR is safe to merge with minor fixes needed
  • The template follows most Dokploy conventions and adds a functional Frappe Lending deployment. The issues found are primarily style-related (missing version field, using latest instead of pinned version). The template correctly avoids problematic directives like networks, ports, and container_name. Once the version field is added and versions are pinned, this will be fully compliant.
  • docker-compose.yml needs version field added, template.toml and meta.json need version pinning from latest to v15

Last reviewed commit: 9c637bb

Context used:

  • Context from dashboard - AGENTS.md (source)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Dokploy/templates/pull/665 **Author:** [@Harikrishnan1367709](https://github.com/Harikrishnan1367709) **Created:** 1/19/2026 **Status:** ✅ Merged **Merged:** 5/12/2026 **Merged by:** [@Siumauricio](https://github.com/Siumauricio) **Base:** `canary` ← **Head:** `Add-Frappe-lending-Template` --- ### 📝 Commits (2) - [`b1fc223`](https://github.com/Dokploy/templates/commit/b1fc2238abbf0bd4c843b30847efff8ffd5d4306) added the frappe lending template - [`9c637bb`](https://github.com/Dokploy/templates/commit/9c637bb7e56cbc7f01ae987c409a8c8fa00888d8) removed the external network ### 📊 Changes **4 files changed** (+599 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `blueprints/frappe-lending/docker-compose.yml` (+550 -0) ➕ `blueprints/frappe-lending/frappe-lending.png` (+0 -0) ➕ `blueprints/frappe-lending/template.toml` (+29 -0) 📝 `meta.json` (+20 -0) </details> ### 📄 Description ## Description Adds Frappe Lending template - a loan management system built on Frappe Framework for managing loans, repayments, and lending operations. ## Technical Details - **Base Image**: `frappe/erpnext:v15` - **Apps**: ERPNext + Lending - **Services**: Backend, Frontend (Nginx), MariaDB, Redis, Queue Workers - **Port**: 8080 <img width="1416" height="854" alt="Screenshot 2026-01-13 at 5 55 37 PM" src="https://github.com/user-attachments/assets/cc77c5ea-adbd-47e6-b479-5e55c725fe31" /> <!-- greptile_comment --> <h3>Greptile Summary</h3> Added Frappe Lending template - a loan management system built on Frappe Framework for managing loans, repayments, and lending operations. **Key changes:** - New blueprint directory with docker-compose.yml, template.toml, and logo - Configured services: backend, frontend (Nginx), MariaDB, Redis, queue workers (default, long, short), scheduler, websocket - Added configurator and create-site services for initial setup - Configured lending app installation and site creation logic - Added entry to meta.json with appropriate tags **Issues identified:** - Missing `version: "3.8"` field at the start of docker-compose.yml (required by style guide) - Using `VERSION=latest` in template.toml and meta.json instead of pinning to specific version like `v15` **Positive aspects:** - Correctly avoids using `networks` (unlike other frappe templates in the repo) - Correctly avoids using `ports` and `container_name` directives - Proper use of volumes for data persistence - Comprehensive healthchecks and service dependencies <h3>Confidence Score: 4/5</h3> - This PR is safe to merge with minor fixes needed - The template follows most Dokploy conventions and adds a functional Frappe Lending deployment. The issues found are primarily style-related (missing version field, using latest instead of pinned version). The template correctly avoids problematic directives like networks, ports, and container_name. Once the version field is added and versions are pinned, this will be fully compliant. - docker-compose.yml needs version field added, template.toml and meta.json need version pinning from latest to v15 <sub>Last reviewed commit: 9c637bb</sub> <!-- greptile_other_comments_section --> **Context used:** - Context from `dashboard` - AGENTS.md ([source](https://app.greptile.com/review/custom-context?memory=09330bde-2058-497c-9c64-ceae637fb5b2)) <!-- /greptile_comment --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-21 23:20:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
pull-request
Mirrored from GitHub Pull Request
 template
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/templates#7904
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?