[PR #740] fix: Imgproxy container exposure #5695

New Issue

GiteaMirror · 2026-05-13T19:56:30-05:00

GiteaMirror commented

2026-05-13 19:56:30 -05:00

📋 Pull Request Information

Original PR: https://github.com/Dokploy/templates/pull/740
Author: @vladyslavprosolupov
Created: 3/9/2026
Status: 🔄 Open

Base: canary ← Head: canary

📝 Commits (1)

8d7fb61 fix: Imgproxy container exposure

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 blueprints/imgproxy/docker-compose.yml (+2 -0)

📄 Description

What is this PR about?

@Siumauricio On fresh dokploy installation imgproxy container exposure was needed. Unfortunately, my previous implementation doesn't work as expected without direct expose in docker-compose.yml.

Checklist

Before submitting this PR, please make sure that:

I have read the suggestions in the README.md file https://github.com/Dokploy/templates?tab=readme-ov-file#general-requirements-when-creating-a-template
I have tested the template in my instance, so the maintainers don't spend time trying to figure out what's wrong.

Greptile Summary

This PR fixes container-to-container communication for the imgproxy blueprint by adding an explicit expose: - 8080 directive to the imgproxy service in docker-compose.yml. On fresh Dokploy installations, the platform relies on the expose declaration to wire up internal service routing, so without it nginx could not reach imgproxy on port 8080.

The change is minimal and correct — it mirrors the existing expose: - 80 pattern already present on the nginx service.
Port 8080 is imgproxy's default listen port and is already referenced in the nginx proxy_pass http://imgproxy:8080 directive, so this is a consistent fix.
Uses expose (not ports), which is the required convention for this repository per the Docker Compose guidelines.

Confidence Score: 5/5

This PR is safe to merge — it makes a single, minimal, and correct change that aligns with both Docker Compose conventions and the repository's own guidelines.
The change adds a single expose: - 8080 directive that is already the established pattern for this repository (nginx already has expose: - 80), targets the correct default imgproxy port, does not introduce ports or any other prohibited directive, and directly resolves the reported deployment issue on fresh Dokploy installations.
No files require special attention.

_{Last reviewed commit: 8d7fb61}

_{(3/5) Reply to the agent's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!}

Context used:

Rule used - AGENTS.md (source)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Dokploy/templates/pull/740 **Author:** [@vladyslavprosolupov](https://github.com/vladyslavprosolupov) **Created:** 3/9/2026 **Status:** 🔄 Open **Base:** `canary` ← **Head:** `canary` --- ### 📝 Commits (1) - [`8d7fb61`](https://github.com/Dokploy/templates/commit/8d7fb610f19656f42a22a7583397377140cd5f19) fix: Imgproxy container exposure ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `blueprints/imgproxy/docker-compose.yml` (+2 -0) </details> ### 📄 Description ## What is this PR about? @Siumauricio On fresh dokploy installation imgproxy container exposure was needed. Unfortunately, my previous implementation doesn't work as expected without direct expose in docker-compose.yml. ## Checklist Before submitting this PR, please make sure that: - [x] I have read the suggestions in the README.md file https://github.com/Dokploy/templates?tab=readme-ov-file#general-requirements-when-creating-a-template - [x] I have tested the template in my instance, so the maintainers don't spend time trying to figure out what's wrong.  <h3>Greptile Summary</h3> This PR fixes container-to-container communication for the `imgproxy` blueprint by adding an explicit `expose: - 8080` directive to the `imgproxy` service in `docker-compose.yml`. On fresh Dokploy installations, the platform relies on the `expose` declaration to wire up internal service routing, so without it nginx could not reach imgproxy on port 8080. - The change is minimal and correct — it mirrors the existing `expose: - 80` pattern already present on the `nginx` service. - Port `8080` is imgproxy's default listen port and is already referenced in the nginx `proxy_pass http://imgproxy:8080` directive, so this is a consistent fix. - Uses `expose` (not `ports`), which is the required convention for this repository per the Docker Compose guidelines. <h3>Confidence Score: 5/5</h3> - This PR is safe to merge — it makes a single, minimal, and correct change that aligns with both Docker Compose conventions and the repository's own guidelines. - The change adds a single `expose: - 8080` directive that is already the established pattern for this repository (nginx already has `expose: - 80`), targets the correct default imgproxy port, does not introduce `ports` or any other prohibited directive, and directly resolves the reported deployment issue on fresh Dokploy installations. - No files require special attention. <sub>Last reviewed commit: 8d7fb61</sub> <sub>(3/5) Reply to the agent's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!</sub> **Context used:** - Rule used - AGENTS.md ([source](https://app.greptile.com/review/custom-context?memory=09330bde-2058-497c-9c64-ceae637fb5b2))  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-13 19:56:30 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/templates#5695