github-starred/templates
2
0
Fork 1
mirror of https://github.com/Dokploy/templates.git synced 2026-05-07 17:18:26 -05:00
Code Issues 1.2k Packages Projects Releases Wiki Activity

[PR #812] add duplicati #4284

New Issue
Open
opened 2026-04-30 06:51:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-30 06:51:27 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/Dokploy/templates/pull/812
Author: @schmanat
Created: 4/19/2026
Status: 🔄 Open

Base: canary ← Head: add-duplicati

📝 Commits (1)

📊 Changes

4 files changed (+406 additions, -1822 deletions)

View changed files

➕ blueprints/duplicati/docker-compose.yml (+28 -0)
➕ blueprints/duplicati/logo.png (+0 -0)
➕ blueprints/duplicati/template.toml (+13 -0)
📝 meta.json (+365 -1822)

📄 Description

What is this PR about?

New PR of Duplicati

Checklist

Before submitting this PR, please make sure that:

Issues related (if applicable)

Close automatically the related issues using the keywords: closes #ISSUE_NUMBER

Screenshots or Videos

Greptile Summary

This PR adds a Duplicati backup template. The docker-compose.yml is missing several required fields (version: "3.8", restart policy, pinned image tag) and uses absolute host paths in bind mounts — all of which are explicitly required by the project's contribution guidelines. Additionally, the PR includes a large unrelated reformatting of tags arrays across meta.json that should be reverted to keep the change focused.

  • P1: Missing version: \"3.8\", restart: unless-stopped, and unpinned latest image tag in docker-compose.yml
  • P1: Absolute host paths (/path/to/backups, etc.) in bind-mount volumes must be changed to relative paths
  • P2: Hundreds of unrelated tags array reformatting changes in meta.json

Confidence Score: 3/5

Not safe to merge — multiple required docker-compose conventions are violated and absolute bind-mount paths will break deployments.

Two P1 findings affect correctness: missing version/restart directives (required by project guidelines) and absolute volume paths that will fail on real deployments. These need to be fixed before merging.

blueprints/duplicati/docker-compose.yml needs version, restart, pinned image, and relative volume paths fixed.

Comments Outside Diff (1)

  1. meta.json, line 10-72 (link)

    P2 Unrelated bulk reformatting of tags arrays

    This PR reformats hundreds of existing tags arrays from multi-line to single-line style throughout meta.json. These changes are unrelated to adding Duplicati and will make the diff much harder to review. They also risk failing CI validation if the process-meta script enforces a specific format. Consider reverting these formatting-only changes and keeping the PR focused on the Duplicati addition.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Reviews (1): Last reviewed commit: "add duplicati" | Re-trigger Greptile

Greptile also left 2 inline comments on this PR.

Context used:

  • Context used - AGENTS.md (source)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Dokploy/templates/pull/812 **Author:** [@schmanat](https://github.com/schmanat) **Created:** 4/19/2026 **Status:** 🔄 Open **Base:** `canary` ← **Head:** `add-duplicati` --- ### 📝 Commits (1) - [`bf4d1d6`](https://github.com/Dokploy/templates/commit/bf4d1d6605a8ecc3bde22c3e5243af18c295dca6) add duplicati ### 📊 Changes **4 files changed** (+406 additions, -1822 deletions) <details> <summary>View changed files</summary> ➕ `blueprints/duplicati/docker-compose.yml` (+28 -0) ➕ `blueprints/duplicati/logo.png` (+0 -0) ➕ `blueprints/duplicati/template.toml` (+13 -0) 📝 `meta.json` (+365 -1822) </details> ### 📄 Description ## What is this PR about? New PR of Duplicati ## Checklist Before submitting this PR, please make sure that: - [x] I have read the suggestions in the README.md file https://github.com/Dokploy/templates?tab=readme-ov-file#general-requirements-when-creating-a-template - [x] I have tested the template in my instance, so the maintainers don't spend time trying to figure out what's wrong. - [x] I have added tests that demonstrate that my correction works or that my new feature works. ## Issues related (if applicable) Close automatically the related issues using the keywords: `closes #ISSUE_NUMBER` ## Screenshots or Videos <!-- greptile_comment --> <h3>Greptile Summary</h3> This PR adds a Duplicati backup template. The `docker-compose.yml` is missing several required fields (`version: "3.8"`, `restart` policy, pinned image tag) and uses absolute host paths in bind mounts — all of which are explicitly required by the project's contribution guidelines. Additionally, the PR includes a large unrelated reformatting of `tags` arrays across `meta.json` that should be reverted to keep the change focused. - **P1**: Missing `version: \"3.8\"`, `restart: unless-stopped`, and unpinned `latest` image tag in `docker-compose.yml` - **P1**: Absolute host paths (`/path/to/backups`, etc.) in bind-mount volumes must be changed to relative paths - **P2**: Hundreds of unrelated `tags` array reformatting changes in `meta.json` <h3>Confidence Score: 3/5</h3> Not safe to merge — multiple required docker-compose conventions are violated and absolute bind-mount paths will break deployments. Two P1 findings affect correctness: missing version/restart directives (required by project guidelines) and absolute volume paths that will fail on real deployments. These need to be fixed before merging. `blueprints/duplicati/docker-compose.yml` needs version, restart, pinned image, and relative volume paths fixed. <!-- greptile_failed_comments --> <details><summary><h3>Comments Outside Diff (1)</h3></summary> 1. `meta.json`, line 10-72 ([link](https://github.com/dokploy/templates/blob/bf4d1d6605a8ecc3bde22c3e5243af18c295dca6/meta.json#L10-L72)) <a href="#"><img alt="P2" src="https://greptile-static-assets.s3.amazonaws.com/badges/p2.svg?v=7" align="top"></a> **Unrelated bulk reformatting of `tags` arrays** This PR reformats hundreds of existing `tags` arrays from multi-line to single-line style throughout `meta.json`. These changes are unrelated to adding Duplicati and will make the diff much harder to review. They also risk failing CI validation if the `process-meta` script enforces a specific format. Consider reverting these formatting-only changes and keeping the PR focused on the Duplicati addition. Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! </details> <!-- /greptile_failed_comments --> <sub>Reviews (1): Last reviewed commit: ["add duplicati"](https://github.com/dokploy/templates/commit/bf4d1d6605a8ecc3bde22c3e5243af18c295dca6) | [Re-trigger Greptile](https://app.greptile.com/api/retrigger?id=28917329)</sub> > Greptile also left **2 inline comments** on this PR. **Context used:** - Context used - AGENTS.md ([source](https://app.greptile.com/review/custom-context?memory=09330bde-2058-497c-9c64-ceae637fb5b2)) <!-- /greptile_comment --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 06:51:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
pull-request
Mirrored from GitHub Pull Request
 template
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/templates#4284
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?