[PR #382] [MERGED] Makes APP_URL valid for Pyrodactyl to function properly #414

New Issue

GiteaMirror · 2025-11-22T20:38:03-06:00

GiteaMirror commented

2025-11-22 20:38:03 -06:00

📋 Pull Request Information

Original PR: https://github.com/Dokploy/templates/pull/382
Author: @EdyTheCow
Created: 9/20/2025
Status: ✅ Merged
Merged: 9/21/2025
Merged by: @Siumauricio

Base: main ← Head: fix-app-url-variable

📝 Commits (1)

721f4cd Makes full APP_URL valid for Pyrodactyl to function properly

📊 Changes

2 files changed (+2 additions, -3 deletions)

View changed files

📝 blueprints/pyrodactyl/docker-compose.yml (+1 -2)
📝 blueprints/pyrodactyl/template.toml (+1 -1)

📄 Description

Pyrodactyl expects full URL inside APP_URL variable. While you could add the "https://" to the variable inside the .env (template.toml), it doesn't properly pass the full APP_URL down to docker compose file. This causes some functions of the panel not to function properly.

This change moves the APP_URL variable directly to docker compose file, and instead adds the "https://" part, with a new variable APP_DOMAIN which only expects domain itself.

To reproduce the issue I am talking about:

Deploy Pyrodactyl using the template (you might need to change the image version to either v4.0.0 or canary to test this with new DNS manager feature that was recently added)
Create admin account
Navigate to "Admin panel > Settings > Domains > Create New Domain"
Select "Cloudflare" as DNS provider from the drop-down menu
"DNS Provider Configuration" field should appear but it does not due to invalid "APP_URL"

To make it work, move the APP_URL directly to docker compose file and add "https://" in front of the domain. Re-deploy and repeat step 3 and 4. Now you'll notice that "DNS Provider Configuration" section does appear properly.

Additionally I have removed MYSQL_PASSWORD and MYSQL_ROOT_PASSWORD variables from panel in docker compose, because those variables do not belong there as they are database specific.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Dokploy/templates/pull/382 **Author:** [@EdyTheCow](https://github.com/EdyTheCow) **Created:** 9/20/2025 **Status:** ✅ Merged **Merged:** 9/21/2025 **Merged by:** [@Siumauricio](https://github.com/Siumauricio) **Base:** `main` ← **Head:** `fix-app-url-variable` --- ### 📝 Commits (1) - [`721f4cd`](https://github.com/Dokploy/templates/commit/721f4cd1e287bc2c60e8bee6f9cabc3a3c8436dc) Makes full APP_URL valid for Pyrodactyl to function properly ### 📊 Changes **2 files changed** (+2 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `blueprints/pyrodactyl/docker-compose.yml` (+1 -2) 📝 `blueprints/pyrodactyl/template.toml` (+1 -1) </details> ### 📄 Description Pyrodactyl expects full URL inside APP_URL variable. While you could add the "https://" to the variable inside the .env (template.toml), it doesn't properly pass the full APP_URL down to docker compose file. This causes some functions of the panel not to function properly. This change moves the APP_URL variable directly to docker compose file, and instead adds the "https://" part, with a new variable APP_DOMAIN which only expects domain itself. **To reproduce the issue I am talking about:** 1. Deploy Pyrodactyl using the template (you might need to change the image version to either v4.0.0 or canary to test this with new DNS manager feature that was recently added) 2. Create admin account 3. Navigate to "Admin panel > Settings > Domains > Create New Domain" 4. Select "Cloudflare" as DNS provider from the drop-down menu 5. "DNS Provider Configuration" field should appear but it does not due to invalid "APP_URL" To make it work, move the APP_URL directly to docker compose file and add "https://" in front of the domain. Re-deploy and repeat step 3 and 4. Now you'll notice that "DNS Provider Configuration" section does appear properly. Additionally I have removed MYSQL_PASSWORD and MYSQL_ROOT_PASSWORD variables from panel in docker compose, because those variables do not belong there as they are database specific. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-22 20:38:03 -06:00

GiteaMirror closed this issue

2025-11-22 20:38:03 -06:00

GiteaMirror referenced this issue

2025-11-22 20:38:44 -06:00

[PR #414] Add TacticalRMM blueprint and metadata #442

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/templates#414