[PR #294] [CLOSED] feat: Complete CI/CD pipeline overhaul with meta.json validation system #342

Closed
opened 2025-11-22 20:35:49 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Dokploy/templates/pull/294
Author: @jaainil
Created: 8/19/2025
Status: Closed

Base: mainHead: fix/remove-duplicate-meta-entries


📝 Commits (10+)

  • 821f17c removed
  • 28d8398 Replace application catalog entries with new software entries
  • 16351e6 Test 1
  • db4d883 Updated Scripts
  • 60004ae Final Test
  • b5ecea3 Fix
  • a816240 Remove redundant dependency installation steps from GitHub Actions workflow
  • 0520be1 Test 2
  • 15e19fb Update meta sorting logic to ASCII order and add --backup option for deduplication
  • 6a784b9 Fix meta.json: Remove duplicates and apply correct ASCII sorting

📊 Changes

10 files changed (+4096 additions, -2261 deletions)

View changed files

📝 .github/workflows/build-preview.yml (+58 -1)
📝 .github/workflows/cloudflare-pages-production.yml (+59 -2)
📝 .github/workflows/deploy-preview.yml (+66 -1)
.github/workflows/validate-meta.yml (+80 -0)
Makefile (+45 -0)
README-meta-processing.md (+227 -0)
build-scripts/process-meta.js (+292 -0)
dedupe-and-sort-meta.js (+182 -0)
📝 meta.json (+3056 -2257)
package.json (+31 -0)

📄 Description

🔧 Core Processing Improvements:

  • Fixed meta.json duplicate detection and ASCII sorting algorithms
  • Enhanced backup system with optional --backup flag support
  • Added comprehensive error handling and exit codes
  • Implemented consistent validation across all processing tools
  • Fixed line counting vs JSON entry counting in CI workflows

🚀 Workflow Enhancements:

  • Added meta.json validation to cloudflare-pages-production.yml
  • Added meta.json validation to build-preview.yml
  • Added meta.json validation to deploy-preview.yml
  • Implemented consistent validation steps across all workflows
  • Added early failure detection to prevent invalid deployments

Quality Assurance:

  • Ensured 241 unique, properly sorted entries in meta.json
  • Added required fields validation for all entries
  • Implemented robust diff validation for formatting consistency
  • Created fail-fast deployment pipeline to catch issues early

🛠️ Technical Improvements:

  • Updated build-scripts/process-meta.js with --backup support
  • Enhanced dedupe-and-sort-meta.js with improved sorting
  • Fixed validate-meta.yml workflow entry counting logic
  • Added comprehensive test coverage for all processing commands

📋 Files Modified:

  • .github/workflows/cloudflare-pages-production.yml
  • .github/workflows/build-preview.yml
  • .github/workflows/deploy-preview.yml
  • .github/workflows/validate-meta.yml
  • build-scripts/process-meta.js
  • dedupe-and-sort-meta.js
  • package.json (NPM scripts)
  • Makefile (Make targets)

🎯 Result: Bulletproof CI/CD pipeline with comprehensive meta.json validation
preventing production deployments with invalid data while maintaining
data integrity and deployment reliability.

Fixes: Production and preview deployment failures
Resolves: Meta.json duplicate and sorting issues
Implements: Comprehensive validation system across all workflows


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Dokploy/templates/pull/294 **Author:** [@jaainil](https://github.com/jaainil) **Created:** 8/19/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/remove-duplicate-meta-entries` --- ### 📝 Commits (10+) - [`821f17c`](https://github.com/Dokploy/templates/commit/821f17c72054b433a292a20793ebe0773d55e8a8) removed - [`28d8398`](https://github.com/Dokploy/templates/commit/28d839843db1e6ae041fda63d507fccefda98c2d) Replace application catalog entries with new software entries - [`16351e6`](https://github.com/Dokploy/templates/commit/16351e65945529bcfbc9355f3286fc7fd7c3c7f9) Test 1 - [`db4d883`](https://github.com/Dokploy/templates/commit/db4d883f24700dd6fbf0edc63e5ea6ceee84f88f) Updated Scripts - [`60004ae`](https://github.com/Dokploy/templates/commit/60004ae85694119be723a157861b4d6b89a7c174) Final Test - [`b5ecea3`](https://github.com/Dokploy/templates/commit/b5ecea3fa863622ec00ed74edd9fd7c49a091a40) Fix - [`a816240`](https://github.com/Dokploy/templates/commit/a816240c2d57afef1c2a20759e6dd89e02a56be6) Remove redundant dependency installation steps from GitHub Actions workflow - [`0520be1`](https://github.com/Dokploy/templates/commit/0520be130f0c97977e22dc50429769a8185da995) Test 2 - [`15e19fb`](https://github.com/Dokploy/templates/commit/15e19fbdcd52ce768a9fb0ebcd9f237a5fe30f77) Update meta sorting logic to ASCII order and add --backup option for deduplication - [`6a784b9`](https://github.com/Dokploy/templates/commit/6a784b9747fe92e375c7d0cdde0a611dd43cadc6) Fix meta.json: Remove duplicates and apply correct ASCII sorting ### 📊 Changes **10 files changed** (+4096 additions, -2261 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build-preview.yml` (+58 -1) 📝 `.github/workflows/cloudflare-pages-production.yml` (+59 -2) 📝 `.github/workflows/deploy-preview.yml` (+66 -1) ➕ `.github/workflows/validate-meta.yml` (+80 -0) ➕ `Makefile` (+45 -0) ➕ `README-meta-processing.md` (+227 -0) ➕ `build-scripts/process-meta.js` (+292 -0) ➕ `dedupe-and-sort-meta.js` (+182 -0) 📝 `meta.json` (+3056 -2257) ➕ `package.json` (+31 -0) </details> ### 📄 Description 🔧 Core Processing Improvements: - Fixed meta.json duplicate detection and ASCII sorting algorithms - Enhanced backup system with optional --backup flag support - Added comprehensive error handling and exit codes - Implemented consistent validation across all processing tools - Fixed line counting vs JSON entry counting in CI workflows 🚀 Workflow Enhancements: - Added meta.json validation to cloudflare-pages-production.yml - Added meta.json validation to build-preview.yml - Added meta.json validation to deploy-preview.yml - Implemented consistent validation steps across all workflows - Added early failure detection to prevent invalid deployments ✅ Quality Assurance: - Ensured 241 unique, properly sorted entries in meta.json - Added required fields validation for all entries - Implemented robust diff validation for formatting consistency - Created fail-fast deployment pipeline to catch issues early 🛠️ Technical Improvements: - Updated build-scripts/process-meta.js with --backup support - Enhanced dedupe-and-sort-meta.js with improved sorting - Fixed validate-meta.yml workflow entry counting logic - Added comprehensive test coverage for all processing commands 📋 Files Modified: - .github/workflows/cloudflare-pages-production.yml - .github/workflows/build-preview.yml - .github/workflows/deploy-preview.yml - .github/workflows/validate-meta.yml - build-scripts/process-meta.js - dedupe-and-sort-meta.js - package.json (NPM scripts) - Makefile (Make targets) 🎯 Result: Bulletproof CI/CD pipeline with comprehensive meta.json validation preventing production deployments with invalid data while maintaining data integrity and deployment reliability. Fixes: Production and preview deployment failures Resolves: Meta.json duplicate and sorting issues Implements: Comprehensive validation system across all workflows --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-22 20:35:49 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/templates#342