github-starred/templates
2
0
Fork 1
mirror of https://github.com/Dokploy/templates.git synced 2026-05-06 10:37:26 -05:00
Code Issues 990 Packages Projects Releases Wiki Activity

[PR #600] [CLOSED] Add Obscreen blueprint template #3348

New Issue
Closed
opened 2026-04-25 18:04:43 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-25 18:04:43 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/Dokploy/templates/pull/600
Author: @jr-k
Created: 12/18/2025
Status: ❌ Closed

Base: canary ← Head: obscreen

📝 Commits (4)

  • 3a38af3 Add Obscreen blueprint template
  • b6789e4 meta changes to obscreen blueprints
  • 445302a meta changes to obscreen blueprints
  • d6667b9 Merge branch 'Dokploy:canary' into obscreen

📊 Changes

4 files changed (+54 additions, -0 deletions)

View changed files

➕ blueprints/obscreen/docker-compose.yml (+16 -0)
➕ blueprints/obscreen/obscreen.png (+0 -0)
➕ blueprints/obscreen/template.toml (+16 -0)
📝 meta.json (+22 -0)

📄 Description

What is this PR about?

New PR of Obscreen - a digital signage service

Checklist

Before submitting this PR, please make sure that:

Issues related (if applicable)

Close automatically the related issues using the keywords: closes #ISSUE_NUMBER

Screenshots or Videos

https://cln.sh/ppXb4frK

Greptile Overview

Greptile Summary

This PR adds a new Obscreen blueprint template for deploying a digital signage service via Dokploy. The template includes a single-service Docker Compose setup with persistent volumes, a TOML configuration with domain and secret key generation, a logo image, and a meta.json entry.

  • Version mismatch (critical): meta.json declares version 2025.12.5, but docker-compose.yml uses the :latest image tag. Per repository conventions, these must match. The image should be pinned to obscreen/obscreen:2025.12.5.
  • Missing version: "3.8": The docker-compose.yml omits the version field. While many recent templates also omit it, the AGENTS.md convention recommends including version: "3.8".
  • FROZEN_VAR_EXTERNAL_URL uses http://: Since Dokploy typically terminates TLS, the external URL should likely use https:// to avoid mixed-content or redirect issues.
  • Missing trailing newline in template.toml.

Confidence Score: 3/5

  • This PR is mostly safe but has a version mismatch between meta.json and docker-compose.yml that should be resolved before merging.
  • The template structure is straightforward and follows most repository conventions. However, the version mismatch between meta.json (2025.12.5) and the Docker image tag (latest) violates the repository's stated requirements and could lead to deployment inconsistencies. The other issues (missing version field, http vs https, missing newline) are minor style concerns.
  • Pay close attention to blueprints/obscreen/docker-compose.yml (version mismatch with meta.json) and blueprints/obscreen/template.toml (external URL protocol).

Last reviewed commit: d6667b9

(3/5) Reply to the agent's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!

Context used:

  • Context from dashboard - AGENTS.md (source)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Dokploy/templates/pull/600 **Author:** [@jr-k](https://github.com/jr-k) **Created:** 12/18/2025 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `obscreen` --- ### 📝 Commits (4) - [`3a38af3`](https://github.com/Dokploy/templates/commit/3a38af398ddbd53681936080ef07823ac64ebaf5) Add Obscreen blueprint template - [`b6789e4`](https://github.com/Dokploy/templates/commit/b6789e48bbbceaaf0871b6b0b4783ae792b4c705) meta changes to obscreen blueprints - [`445302a`](https://github.com/Dokploy/templates/commit/445302ad7ebbcc805dcc450216e720fec837cad8) meta changes to obscreen blueprints - [`d6667b9`](https://github.com/Dokploy/templates/commit/d6667b9c9a61fff866b653a55f506968df081e84) Merge branch 'Dokploy:canary' into obscreen ### 📊 Changes **4 files changed** (+54 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `blueprints/obscreen/docker-compose.yml` (+16 -0) ➕ `blueprints/obscreen/obscreen.png` (+0 -0) ➕ `blueprints/obscreen/template.toml` (+16 -0) 📝 `meta.json` (+22 -0) </details> ### 📄 Description ## What is this PR about? New PR of Obscreen - a digital signage service ## Checklist Before submitting this PR, please make sure that: - [x] I have read the suggestions in the README.md file https://github.com/Dokploy/templates?tab=readme-ov-file#general-requirements-when-creating-a-template - [x] I have tested the template in my instance, so the maintainers don't spend time trying to figure out what's wrong. - [x] I have added tests that demonstrate that my correction works or that my new feature works. ## Issues related (if applicable) Close automatically the related issues using the keywords: `closes #ISSUE_NUMBER` ## Screenshots or Videos https://cln.sh/ppXb4frK <!-- greptile_comment --> <h2>Greptile Overview</h2> <h3>Greptile Summary</h3> This PR adds a new Obscreen blueprint template for deploying a digital signage service via Dokploy. The template includes a single-service Docker Compose setup with persistent volumes, a TOML configuration with domain and secret key generation, a logo image, and a `meta.json` entry. - **Version mismatch (critical):** `meta.json` declares version `2025.12.5`, but `docker-compose.yml` uses the `:latest` image tag. Per repository conventions, these must match. The image should be pinned to `obscreen/obscreen:2025.12.5`. - **Missing `version: "3.8"`:** The `docker-compose.yml` omits the version field. While many recent templates also omit it, the AGENTS.md convention recommends including `version: "3.8"`. - **`FROZEN_VAR_EXTERNAL_URL` uses `http://`:** Since Dokploy typically terminates TLS, the external URL should likely use `https://` to avoid mixed-content or redirect issues. - **Missing trailing newline** in `template.toml`. <h3>Confidence Score: 3/5</h3> - This PR is mostly safe but has a version mismatch between meta.json and docker-compose.yml that should be resolved before merging. - The template structure is straightforward and follows most repository conventions. However, the version mismatch between meta.json (2025.12.5) and the Docker image tag (latest) violates the repository's stated requirements and could lead to deployment inconsistencies. The other issues (missing version field, http vs https, missing newline) are minor style concerns. - Pay close attention to `blueprints/obscreen/docker-compose.yml` (version mismatch with meta.json) and `blueprints/obscreen/template.toml` (external URL protocol). <sub>Last reviewed commit: d6667b9</sub> <!-- greptile_other_comments_section --> <sub>(3/5) Reply to the agent's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!</sub> **Context used:** - Context from `dashboard` - AGENTS.md ([source](https://app.greptile.com/review/custom-context?memory=09330bde-2058-497c-9c64-ceae637fb5b2)) <!-- /greptile_comment --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-25 18:04:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
pull-request
Mirrored from GitHub Pull Request
 template
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/templates#3348
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?