github-starred/templates
2
0
Fork 1
mirror of https://github.com/Dokploy/templates.git synced 2026-05-06 02:07:03 -05:00
Code Issues 990 Packages Projects Releases Wiki Activity

[PR #735] [MERGED] feat(blueprint): add Verdaccio - private node.js package registry #2859

New Issue
Closed
opened 2026-04-23 03:36:42 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 03:36:42 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/Dokploy/templates/pull/735
Author: @wladiarce
Created: 3/3/2026
Status: ✅ Merged
Merged: 3/5/2026
Merged by: @Siumauricio

Base: canary ← Head: add-verdaccio-template

📝 Commits (1)

  • fc72f73 feat(blueprint): add Verdaccio - private node.js package registry

📊 Changes

4 files changed (+349 additions, -18 deletions)

View changed files

➕ blueprints/verdaccio/docker-compose.yml (+17 -0)
➕ blueprints/verdaccio/template.toml (+259 -0)
➕ blueprints/verdaccio/verdaccio.svg (+38 -0)
📝 meta.json (+35 -18)

📄 Description

What is this PR about?

New PR of [Template Name]

Checklist

Before submitting this PR, please make sure that:

Issues related (if applicable)

Close automatically the related issues using the keywords: closes #ISSUE_NUMBER

Screenshots or Videos

image image

Greptile Summary

This PR adds a Verdaccio (private Node.js package registry) blueprint to the Dokploy templates collection. The template includes a docker-compose.yml, a template.toml with a fully embedded Verdaccio config (via [[config.mounts]]), an SVG logo, and a meta.json entry. The overall approach and configuration are correct; however, the docker-compose.yml violates two mandatory project conventions defined in AGENTS.md:

  1. ports used instead of expose: Dokploy handles all external routing; using ports directly exposes port 4873 on the host rather than routing through Dokploy's managed reverse proxy.
  2. Missing restart policy: The service does not define restart: unless-stopped (or restart: always), meaning the container will not automatically recover from crashes or host reboots.

Both issues are explicitly prohibited/required by the project's Docker Compose conventions and must be fixed before this template can be safely deployed.

Confidence Score: 2/5

  • Not safe to merge — the docker-compose.yml violates two mandatory project conventions that will prevent safe deployment in Dokploy.
  • The PR contains two verified violations of mandatory Docker Compose conventions defined in AGENTS.md. The use of ports instead of expose bypasses Dokploy's routing system and exposes the service directly on the host, while the missing restart policy means the service cannot recover automatically. Both must be fixed before deployment. The other files (meta.json, template.toml, and SVG) are correct.
  • blueprints/verdaccio/docker-compose.yml requires fixing: replace ports with expose and add restart: unless-stopped

Last reviewed commit: fc72f73

(3/5) Reply to the agent's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!

Context used:

  • Rule from dashboard - AGENTS.md (source)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Dokploy/templates/pull/735 **Author:** [@wladiarce](https://github.com/wladiarce) **Created:** 3/3/2026 **Status:** ✅ Merged **Merged:** 3/5/2026 **Merged by:** [@Siumauricio](https://github.com/Siumauricio) **Base:** `canary` ← **Head:** `add-verdaccio-template` --- ### 📝 Commits (1) - [`fc72f73`](https://github.com/Dokploy/templates/commit/fc72f73c3c8522ef6e51549e768f18da04260825) feat(blueprint): add Verdaccio - private node.js package registry ### 📊 Changes **4 files changed** (+349 additions, -18 deletions) <details> <summary>View changed files</summary> ➕ `blueprints/verdaccio/docker-compose.yml` (+17 -0) ➕ `blueprints/verdaccio/template.toml` (+259 -0) ➕ `blueprints/verdaccio/verdaccio.svg` (+38 -0) 📝 `meta.json` (+35 -18) </details> ### 📄 Description ## What is this PR about? New PR of [Template Name] ## Checklist Before submitting this PR, please make sure that: - [x] I have read the suggestions in the README.md file https://github.com/Dokploy/templates?tab=readme-ov-file#general-requirements-when-creating-a-template - [x] I have tested the template in my instance, so the maintainers don't spend time trying to figure out what's wrong. - [ ] I have added tests that demonstrate that my correction works or that my new feature works. ## Issues related (if applicable) Close automatically the related issues using the keywords: `closes #ISSUE_NUMBER` ## Screenshots or Videos <img width="1039" height="763" alt="image" src="https://github.com/user-attachments/assets/d9b66f13-28fc-4b33-971e-0dcb8d9c3a01" /> <img width="1256" height="942" alt="image" src="https://github.com/user-attachments/assets/937a8e99-18c3-4503-be5e-701af1d5a39b" /> <!-- greptile_comment --> <h3>Greptile Summary</h3> This PR adds a Verdaccio (private Node.js package registry) blueprint to the Dokploy templates collection. The template includes a `docker-compose.yml`, a `template.toml` with a fully embedded Verdaccio config (via `[[config.mounts]]`), an SVG logo, and a `meta.json` entry. The overall approach and configuration are correct; however, the `docker-compose.yml` violates two mandatory project conventions defined in AGENTS.md: 1. **`ports` used instead of `expose`**: Dokploy handles all external routing; using `ports` directly exposes port `4873` on the host rather than routing through Dokploy's managed reverse proxy. 2. **Missing `restart` policy**: The service does not define `restart: unless-stopped` (or `restart: always`), meaning the container will not automatically recover from crashes or host reboots. Both issues are explicitly prohibited/required by the project's Docker Compose conventions and must be fixed before this template can be safely deployed. <h3>Confidence Score: 2/5</h3> - Not safe to merge — the docker-compose.yml violates two mandatory project conventions that will prevent safe deployment in Dokploy. - The PR contains two verified violations of mandatory Docker Compose conventions defined in AGENTS.md. The use of `ports` instead of `expose` bypasses Dokploy's routing system and exposes the service directly on the host, while the missing `restart` policy means the service cannot recover automatically. Both must be fixed before deployment. The other files (meta.json, template.toml, and SVG) are correct. - blueprints/verdaccio/docker-compose.yml requires fixing: replace `ports` with `expose` and add `restart: unless-stopped` <sub>Last reviewed commit: fc72f73</sub> <!-- greptile_other_comments_section --> <sub>(3/5) Reply to the agent's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!</sub> **Context used:** - Rule from `dashboard` - AGENTS.md ([source](https://app.greptile.com/review/custom-context?memory=09330bde-2058-497c-9c64-ceae637fb5b2)) <!-- /greptile_comment --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 03:36:42 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
pull-request
Mirrored from GitHub Pull Request
 template
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/templates#2859
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?