[PR #718] [CLOSED] fix: make linkstack timezone configurable via env instead of hardcoded #2040

New Issue

GiteaMirror · 2026-04-20T11:03:55-05:00

GiteaMirror commented

2026-04-20 11:03:55 -05:00

📋 Pull Request Information

Original PR: https://github.com/Dokploy/templates/pull/718
Author: @madhuragrawal
Created: 2/21/2026
Status: ❌ Closed

Base: canary ← Head: linkstack-fix-timezone-env

📝 Commits (4)

49ddd31 fix: make linkstack timezone configurable via env instead of hardcoded
0c39002 fix: linkstack volume mount schema
38208e2 fix: remove linkstack invalid volume mounts from template.toml
d5182f2 fix: linkstack volume mount schema

📊 Changes

2 files changed (+4 additions, -11 deletions)

View changed files

📝 blueprints/linkstack/docker-compose.yml (+1 -1)
📝 blueprints/linkstack/template.toml (+3 -10)

📄 Description

What is this PR about?

New PR of linkstack

Previously timezone was effectively hardcoded via template default.
This change exposes timezone as a configurable variable while preserving UTC as the default value.

Checklist

Before submitting this PR, please make sure that:

I have read the suggestions in the README.md file https://github.com/Dokploy/templates?tab=readme-ov-file#general-requirements-when-creating-a-template
I have tested the template in my instance, so the maintainers don't spend time trying to figure out what's wrong.

No automated tests exist for templates; change verified via manual deployment.

Greptile Summary

Changed timezone from hardcoded Europe/Berlin to UTC with environment variable placeholder in docker-compose.yml. However, the timezone is not actually configurable because the TZ variable is missing from the [variables] section in template.toml.

Critical issue:

The TZ variable needs to be defined in [variables] section and referenced as "${TZ}" in [config.env] to allow user configuration
Without this, timezone is still hardcoded (just to UTC instead of Europe/Berlin)
See blueprints/freshrss/template.toml:3 for correct implementation pattern

Confidence Score: 2/5

This PR has a critical implementation gap that prevents the stated goal
The PR claims to make timezone configurable but incomplete implementation leaves it hardcoded to UTC. The docker-compose.yml uses ${TZ:-UTC} correctly, but template.toml lacks the required variable definition in [variables] section and hardcodes "UTC" in [config.env], preventing user configuration.
blueprints/linkstack/template.toml requires critical fixes to achieve stated goal

_{Last reviewed commit: 49ddd31}

_{(2/5) Greptile learns from your feedback when you react with thumbs up/down!}

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Dokploy/templates/pull/718 **Author:** [@madhuragrawal](https://github.com/madhuragrawal) **Created:** 2/21/2026 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `linkstack-fix-timezone-env` --- ### 📝 Commits (4) - [`49ddd31`](https://github.com/Dokploy/templates/commit/49ddd31e9897444edcdf0de30bca0ea749223b7d) fix: make linkstack timezone configurable via env instead of hardcoded - [`0c39002`](https://github.com/Dokploy/templates/commit/0c39002143137a74ffebd3ed6a7184235b921286) fix: linkstack volume mount schema - [`38208e2`](https://github.com/Dokploy/templates/commit/38208e232e667a0af9d609937a1671da47f223a4) fix: remove linkstack invalid volume mounts from template.toml - [`d5182f2`](https://github.com/Dokploy/templates/commit/d5182f26f0db6635a4fc65b7ab0991435bef2de7) fix: linkstack volume mount schema ### 📊 Changes **2 files changed** (+4 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `blueprints/linkstack/docker-compose.yml` (+1 -1) 📝 `blueprints/linkstack/template.toml` (+3 -10) </details> ### 📄 Description ## What is this PR about? New PR of linkstack Previously timezone was effectively hardcoded via template default. This change exposes timezone as a configurable variable while preserving UTC as the default value. ## Checklist Before submitting this PR, please make sure that: - [x] I have read the suggestions in the README.md file https://github.com/Dokploy/templates?tab=readme-ov-file#general-requirements-when-creating-a-template - [x] I have tested the template in my instance, so the maintainers don't spend time trying to figure out what's wrong. No automated tests exist for templates; change verified via manual deployment.  <h3>Greptile Summary</h3> Changed timezone from hardcoded `Europe/Berlin` to `UTC` with environment variable placeholder in `docker-compose.yml`. However, the timezone is not actually configurable because the `TZ` variable is missing from the `[variables]` section in `template.toml`. **Critical issue:** - The `TZ` variable needs to be defined in `[variables]` section and referenced as `"${TZ}"` in `[config.env]` to allow user configuration - Without this, timezone is still hardcoded (just to UTC instead of Europe/Berlin) - See `blueprints/freshrss/template.toml:3` for correct implementation pattern <h3>Confidence Score: 2/5</h3> - This PR has a critical implementation gap that prevents the stated goal - The PR claims to make timezone configurable but incomplete implementation leaves it hardcoded to UTC. The docker-compose.yml uses `${TZ:-UTC}` correctly, but template.toml lacks the required variable definition in `[variables]` section and hardcodes "UTC" in `[config.env]`, preventing user configuration. - blueprints/linkstack/template.toml requires critical fixes to achieve stated goal <sub>Last reviewed commit: 49ddd31</sub>  <sub>(2/5) Greptile learns from your feedback when you react with thumbs up/down!</sub>  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 11:03:55 -05:00

GiteaMirror closed this issue

2026-04-20 11:03:56 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/templates#2040