github-starred/templates
2
0
Fork 1
mirror of https://github.com/Dokploy/templates.git synced 2026-05-06 16:55:42 -05:00
Code Issues 1.2k Packages Projects Releases Wiki Activity

[PR #715] fix(plane): add http scheme to WEB_URL #2037

New Issue
Open
opened 2026-04-20 11:03:50 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 11:03:50 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/Dokploy/templates/pull/715
Author: @adryserage
Created: 2/20/2026
Status: 🔄 Open

Base: canary ← Head: fix/plane-env-urls

📝 Commits (2)

  • 36194c6 fix(plane): add http scheme to WEB_URL
  • 658853e Update blueprints/plane/template.toml

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 blueprints/plane/template.toml (+1 -1)

📄 Description

Summary

  • Add \http://\ scheme to \WEB_URL\ so Plane can generate valid links (emails, redirects, etc.)
  • Uses \http://\ instead of \https://\ since Traefik handles SSL termination

Changes

  • \lueprints/plane/template.toml: \WEB_URL=\ → \WEB_URL=http://\

Context

Follows up on #582 (closed for inactivity). Addresses review feedback from @Siumauricio — removed \https://\ and kept \API_BASE_URL\ as internal \http://api:8000.

Testing

Verified template.toml syntax is valid.

Greptile Summary

Added http:// scheme to WEB_URL environment variable so Plane can generate valid absolute URLs for emails, redirects, and other features. The change correctly uses http:// instead of https:// since Traefik handles SSL termination at the proxy level.

  • Fixed WEB_URL to include http:// scheme prefix (was missing protocol entirely)
  • Change follows repository conventions - many templates use http://${domain} pattern for internal URLs
  • One potential issue: CORS_ALLOWED_ORIGINS still uses https:// which may cause CORS errors

Confidence Score: 4/5

  • Safe to merge with one CORS configuration issue to verify
  • The change is minimal, well-justified, and follows repository conventions for handling SSL termination. Score is 4 instead of 5 due to potential CORS mismatch between WEB_URL (http) and CORS_ALLOWED_ORIGINS (https) that should be verified in testing
  • Verify CORS_ALLOWED_ORIGINS configuration in production to ensure no CORS errors occur

Last reviewed commit: 36194c6

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Dokploy/templates/pull/715 **Author:** [@adryserage](https://github.com/adryserage) **Created:** 2/20/2026 **Status:** 🔄 Open **Base:** `canary` ← **Head:** `fix/plane-env-urls` --- ### 📝 Commits (2) - [`36194c6`](https://github.com/Dokploy/templates/commit/36194c611129bc9c9758835222766d4c72e2bf47) fix(plane): add http scheme to WEB_URL - [`658853e`](https://github.com/Dokploy/templates/commit/658853e9e5fd73c2ff67aa807733c0e6d8d23789) Update blueprints/plane/template.toml ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `blueprints/plane/template.toml` (+1 -1) </details> ### 📄 Description ## Summary - Add \http://\ scheme to \WEB_URL\ so Plane can generate valid links (emails, redirects, etc.) - Uses \http://\ instead of \https://\ since Traefik handles SSL termination ## Changes - \lueprints/plane/template.toml\: \WEB_URL=\\ → \WEB_URL=http://\\ ## Context Follows up on #582 (closed for inactivity). Addresses review feedback from @Siumauricio — removed \https://\ and kept \API_BASE_URL\ as internal \http://api:8000\. ## Testing Verified template.toml syntax is valid. <!-- greptile_comment --> <h3>Greptile Summary</h3> Added `http://` scheme to `WEB_URL` environment variable so Plane can generate valid absolute URLs for emails, redirects, and other features. The change correctly uses `http://` instead of `https://` since Traefik handles SSL termination at the proxy level. - Fixed `WEB_URL` to include `http://` scheme prefix (was missing protocol entirely) - Change follows repository conventions - many templates use `http://${domain}` pattern for internal URLs - One potential issue: `CORS_ALLOWED_ORIGINS` still uses `https://` which may cause CORS errors <h3>Confidence Score: 4/5</h3> - Safe to merge with one CORS configuration issue to verify - The change is minimal, well-justified, and follows repository conventions for handling SSL termination. Score is 4 instead of 5 due to potential CORS mismatch between `WEB_URL` (http) and `CORS_ALLOWED_ORIGINS` (https) that should be verified in testing - Verify `CORS_ALLOWED_ORIGINS` configuration in production to ensure no CORS errors occur <sub>Last reviewed commit: 36194c6</sub> <!-- greptile_other_comments_section --> <!-- /greptile_comment --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 11:03:50 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
pull-request
Mirrored from GitHub Pull Request
 template
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/templates#2037
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?