github-starred/templates
2
0
Fork 1
mirror of https://github.com/Dokploy/templates.git synced 2026-05-08 01:29:11 -05:00
Code Issues 1.2k Packages Projects Releases Wiki Activity

[PR #627] [CLOSED] feat(plane): update to v1.2.1 #1963

New Issue
Closed
opened 2026-04-20 11:00:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 11:00:32 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/Dokploy/templates/pull/627
Author: @Rasaboun
Created: 12/24/2025
Status: ❌ Closed

Base: canary ← Head: feat/plane-v1.2.1

📝 Commits (3)

  • 9ab06eb feat(plane): update to v1.2.1
  • 7ad8913 chore: trigger CI
  • bdf1f04 fix: address PR review comments

📊 Changes

3 files changed (+78 additions, -57 deletions)

View changed files

📝 blueprints/plane/docker-compose.yml (+32 -16)
📝 blueprints/plane/template.toml (+45 -40)
📝 meta.json (+1 -1)

📄 Description

What is this PR about?

Update Plane template from v0.27.1 to v1.2.1

Changes:

  • Update image registry from makeplane/ to artifacts.plane.so/makeplane/
  • Update PostgreSQL from 17-alpine to 15.7-alpine
  • Update Valkey from 7.2.5-alpine to 7.2.11-alpine
  • Add LIVE_SERVER_SECRET_KEY environment variable (required for live service)
  • Add LISTEN_HTTP_PORT and LISTEN_HTTPS_PORT variables
  • Add proxy volumes (proxy_config, proxy_data)
  • Fix RabbitMQ user variable (was literal string instead of variable)
  • Add restart policies for all services

Checklist

Before submitting this PR, please make sure that:

Issues related (if applicable)

N/A

Screenshots or Videos

N/A - Template update based on Plane v1.2.1 Release

Greptile Summary

Updates the Plane template from v0.27.1 to v1.2.1, migrating to the new artifacts.plane.so registry, fixing several existing bugs, and adding new configuration required by the latest Plane release.

  • Registry migration: All Plane images moved from makeplane/ to artifacts.plane.so/makeplane/
  • Bug fixes in template variables: Fixed RABBITMQ_DEFAULT_USER which was a literal string instead of a variable reference; fixed DATABASE_URL and AMQP_URL which incorrectly referenced env vars instead of template variables; fixed AWS_ACCESS_KEY_ID env var reference
  • New v1.2.1 requirements: Added LIVE_SERVER_SECRET_KEY, LISTEN_HTTP_PORT, LISTEN_HTTPS_PORT, SITE_ADDRESS, APP_DOMAIN, APP_RELEASE env vars; added proxy volumes (proxy_config, proxy_data)
  • Infrastructure updates: Postgres 17-alpine → 15.7-alpine (matching Plane's official recommendation), Valkey 7.2.5 → 7.2.11, Minio pinned from latest to specific release
  • Docker Compose improvements: Added restart policies to all services, removed explicit command: from frontend services (now handled by image entrypoints), added admin and live as proxy dependencies
  • Potential issue: WEB_URL and CORS_ALLOWED_ORIGINS were changed from https:// to http:// in the latest commit, which may cause CORS failures for users deploying with HTTPS

Confidence Score: 3/5

  • This PR is mostly safe but has a likely CORS issue that will affect HTTPS deployments
  • The template update is well-structured and fixes several real bugs from the old version. Docker Compose changes are correct (proper restart policies, image pinning, registry migration). However, the review-fix commit changed CORS_ALLOWED_ORIGINS and WEB_URL from https:// to http://, which will likely break CORS for the majority of users who deploy behind HTTPS. This is a functional issue that should be addressed before merging.
  • Pay close attention to blueprints/plane/template.toml — the CORS_ALLOWED_ORIGINS and WEB_URL settings use http:// which may break HTTPS deployments

Last reviewed commit: bdf1f04

(2/5) Greptile learns from your feedback when you react with thumbs up/down!

Context used:

  • Context from dashboard - AGENTS.md (source)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Dokploy/templates/pull/627 **Author:** [@Rasaboun](https://github.com/Rasaboun) **Created:** 12/24/2025 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `feat/plane-v1.2.1` --- ### 📝 Commits (3) - [`9ab06eb`](https://github.com/Dokploy/templates/commit/9ab06eb219640cba80796e1cd29fa36b7c06bd7a) feat(plane): update to v1.2.1 - [`7ad8913`](https://github.com/Dokploy/templates/commit/7ad8913ea3aa9fa69f44107ae63313bb55787953) chore: trigger CI - [`bdf1f04`](https://github.com/Dokploy/templates/commit/bdf1f04b0151a187724c60ace6953fa254d427f3) fix: address PR review comments ### 📊 Changes **3 files changed** (+78 additions, -57 deletions) <details> <summary>View changed files</summary> 📝 `blueprints/plane/docker-compose.yml` (+32 -16) 📝 `blueprints/plane/template.toml` (+45 -40) 📝 `meta.json` (+1 -1) </details> ### 📄 Description ## What is this PR about? Update Plane template from v0.27.1 to v1.2.1 ### Changes: - Update image registry from `makeplane/` to `artifacts.plane.so/makeplane/` - Update PostgreSQL from `17-alpine` to `15.7-alpine` - Update Valkey from `7.2.5-alpine` to `7.2.11-alpine` - Add `LIVE_SERVER_SECRET_KEY` environment variable (required for live service) - Add `LISTEN_HTTP_PORT` and `LISTEN_HTTPS_PORT` variables - Add proxy volumes (`proxy_config`, `proxy_data`) - Fix RabbitMQ user variable (was literal string instead of variable) - Add restart policies for all services ## Checklist Before submitting this PR, please make sure that: - [x] I have read the suggestions in the README.md file https://github.com/Dokploy/templates?tab=readme-ov-file#general-requirements-when-creating-a-template - [ ] I have tested the template in my instance, so the maintainers don't spend time trying to figure out what's wrong. - [x] I have added tests that demonstrate that my correction works or that my new feature works. ## Issues related (if applicable) N/A ## Screenshots or Videos N/A - Template update based on [Plane v1.2.1 Release](https://github.com/makeplane/plane/releases/tag/v1.2.1) <!-- greptile_comment --> <h3>Greptile Summary</h3> Updates the Plane template from v0.27.1 to v1.2.1, migrating to the new `artifacts.plane.so` registry, fixing several existing bugs, and adding new configuration required by the latest Plane release. - **Registry migration**: All Plane images moved from `makeplane/` to `artifacts.plane.so/makeplane/` - **Bug fixes in template variables**: Fixed `RABBITMQ_DEFAULT_USER` which was a literal string instead of a variable reference; fixed `DATABASE_URL` and `AMQP_URL` which incorrectly referenced env vars instead of template variables; fixed `AWS_ACCESS_KEY_ID` env var reference - **New v1.2.1 requirements**: Added `LIVE_SERVER_SECRET_KEY`, `LISTEN_HTTP_PORT`, `LISTEN_HTTPS_PORT`, `SITE_ADDRESS`, `APP_DOMAIN`, `APP_RELEASE` env vars; added proxy volumes (`proxy_config`, `proxy_data`) - **Infrastructure updates**: Postgres 17-alpine → 15.7-alpine (matching Plane's official recommendation), Valkey 7.2.5 → 7.2.11, Minio pinned from `latest` to specific release - **Docker Compose improvements**: Added `restart` policies to all services, removed explicit `command:` from frontend services (now handled by image entrypoints), added `admin` and `live` as proxy dependencies - **Potential issue**: `WEB_URL` and `CORS_ALLOWED_ORIGINS` were changed from `https://` to `http://` in the latest commit, which may cause CORS failures for users deploying with HTTPS <h3>Confidence Score: 3/5</h3> - This PR is mostly safe but has a likely CORS issue that will affect HTTPS deployments - The template update is well-structured and fixes several real bugs from the old version. Docker Compose changes are correct (proper restart policies, image pinning, registry migration). However, the review-fix commit changed CORS_ALLOWED_ORIGINS and WEB_URL from https:// to http://, which will likely break CORS for the majority of users who deploy behind HTTPS. This is a functional issue that should be addressed before merging. - Pay close attention to `blueprints/plane/template.toml` — the `CORS_ALLOWED_ORIGINS` and `WEB_URL` settings use `http://` which may break HTTPS deployments <sub>Last reviewed commit: bdf1f04</sub> <!-- greptile_other_comments_section --> <sub>(2/5) Greptile learns from your feedback when you react with thumbs up/down!</sub> **Context used:** - Context from `dashboard` - AGENTS.md ([source](https://app.greptile.com/review/custom-context?memory=09330bde-2058-497c-9c64-ceae637fb5b2)) <!-- /greptile_comment --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 11:00:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
pull-request
Mirrored from GitHub Pull Request
 template
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/templates#1963
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?