github-starred/templates
2
0
Fork 1
mirror of https://github.com/Dokploy/templates.git synced 2026-05-08 01:29:11 -05:00
Code Issues 1.2k Packages Projects Releases Wiki Activity

[PR #570] feat: Add Frappe LMS template with Payments app integration #1914

New Issue
Open
opened 2026-04-20 10:58:26 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 10:58:26 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/Dokploy/templates/pull/570
Author: @Harikrishnan1367709
Created: 12/4/2025
Status: 🔄 Open

Base: canary ← Head: Add-Frappe-LMS-template

📝 Commits (10+)

  • e2a900b Feat:Added the frappe LMS Template
  • a48ca1f added the payment app
  • c9aea1d added the wiki app
  • 737dc3d production setup update(lms,payments)
  • 2c507c7 remove the force tag in creating site
  • 7924e13 fixed the dtaapersistance,8080 url,400frontend error
  • c0c0e8e fixed the build issue
  • 405d8fa changed the template name to frappe lms
  • 4d7ad9d added the main domain for the email template email and for the :8080 issue
  • 78cbe59 added the nginx 8080 comands and admin password issue

📊 Changes

4 files changed (+627 additions, -0 deletions)

View changed files

➕ blueprints/frappe/docker-compose.yml (+577 -0)
➕ blueprints/frappe/frappe.png (+0 -0)
➕ blueprints/frappe/template.toml (+29 -0)
📝 meta.json (+21 -0)

📄 Description

Adds a new Frappe LMS template with integrated Payments app for deploying a self-hosted learning management system with payment capabilities.

Features

  • Frappe LMS with Payments app integration
  • Production-ready configuration with data persistence
  • Automatic app installation and service coordination

Technical Details

  • Uses ghcr.io/frappe/lms:stable image
  • Clones and installs payments app automatically
  • Shared volumes for app access across all services

Files

  • blueprints/frappe/template.toml
  • blueprints/frappe/docker-compose.yml
  • blueprints/frappe/frappe.png
  • Updated meta.json entry
Screenshot 2025-12-04 at 5 15 49 PM

Greptile Summary

Adds a new Frappe LMS template with integrated Payments app for deploying a self-hosted learning management system. The template follows the established pattern from the existing frappe-hr blueprint but is significantly more complex, with custom bash entrypoint scripts for most services to handle payments app installation and domain configuration.

  • Critical: Migration service is non-functional — shell operator precedence bug on line 473 of docker-compose.yml causes exit 0 to always execute, making the migration commands unreachable in all code paths.
  • Critical: MAIN_DOMAIN env var in create-site will be empty — line 454 uses ${main_domain} (a template-level variable) instead of ${MAIN_DOMAIN} (the docker-compose env var), so domain configuration during site creation will silently fail.
  • Minor: Inconsistent tag casing in meta.json — "Payments" should be lowercase to match conventions.

Confidence Score: 2/5

  • This PR has two logic bugs that will cause runtime failures in migration and domain configuration.
  • The migration service will never execute its migration commands due to a shell operator precedence bug, and the create-site service will have an empty MAIN_DOMAIN variable due to incorrect variable casing. Both issues will silently fail at runtime and affect the usability of the deployed template.
  • Pay close attention to blueprints/frappe/docker-compose.yml — specifically the migration service (line 473) and the create-site service environment (line 454).

Last reviewed commit: 78cbe59

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Dokploy/templates/pull/570 **Author:** [@Harikrishnan1367709](https://github.com/Harikrishnan1367709) **Created:** 12/4/2025 **Status:** 🔄 Open **Base:** `canary` ← **Head:** `Add-Frappe-LMS-template` --- ### 📝 Commits (10+) - [`e2a900b`](https://github.com/Dokploy/templates/commit/e2a900b5ac3944035a6869bca3b30c1be3794091) Feat:Added the frappe LMS Template - [`a48ca1f`](https://github.com/Dokploy/templates/commit/a48ca1f48b63458100f7d219e25ac09c13ae840c) added the payment app - [`c9aea1d`](https://github.com/Dokploy/templates/commit/c9aea1db8db6ebe45f56eedb12db8889b2a56777) added the wiki app - [`737dc3d`](https://github.com/Dokploy/templates/commit/737dc3df8b1f3dff2e01164d4d71ab3ec63e3216) production setup update(lms,payments) - [`2c507c7`](https://github.com/Dokploy/templates/commit/2c507c76c3346244381f292611ba511147b32373) remove the force tag in creating site - [`7924e13`](https://github.com/Dokploy/templates/commit/7924e133c5da9117558128e4485b69d3406e8a74) fixed the dtaapersistance,8080 url,400frontend error - [`c0c0e8e`](https://github.com/Dokploy/templates/commit/c0c0e8edb094476b3e7995cc58604d4fc61d0a14) fixed the build issue - [`405d8fa`](https://github.com/Dokploy/templates/commit/405d8fae6435a8390b2c76084e9bdd68d4f68239) changed the template name to frappe lms - [`4d7ad9d`](https://github.com/Dokploy/templates/commit/4d7ad9dae2724879c02344cc7eda825ba9ea8856) added the main domain for the email template email and for the :8080 issue - [`78cbe59`](https://github.com/Dokploy/templates/commit/78cbe5903bbcaecf2f2cb1ac959b9674d146d528) added the nginx 8080 comands and admin password issue ### 📊 Changes **4 files changed** (+627 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `blueprints/frappe/docker-compose.yml` (+577 -0) ➕ `blueprints/frappe/frappe.png` (+0 -0) ➕ `blueprints/frappe/template.toml` (+29 -0) 📝 `meta.json` (+21 -0) </details> ### 📄 Description Adds a new Frappe LMS template with integrated Payments app for deploying a self-hosted learning management system with payment capabilities. ## Features - Frappe LMS with Payments app integration - Production-ready configuration with data persistence - Automatic app installation and service coordination ## Technical Details - Uses `ghcr.io/frappe/lms:stable` image - Clones and installs payments app automatically - Shared volumes for app access across all services ## Files - `blueprints/frappe/template.toml` - `blueprints/frappe/docker-compose.yml` - `blueprints/frappe/frappe.png` - Updated `meta.json` entry <img width="1433" height="655" alt="Screenshot 2025-12-04 at 5 15 49 PM" src="https://github.com/user-attachments/assets/cb312ff0-d909-46bd-ba4c-c23afae5aa93" /> <!-- greptile_comment --> <h3>Greptile Summary</h3> Adds a new Frappe LMS template with integrated Payments app for deploying a self-hosted learning management system. The template follows the established pattern from the existing `frappe-hr` blueprint but is significantly more complex, with custom bash entrypoint scripts for most services to handle payments app installation and domain configuration. - **Critical: Migration service is non-functional** — shell operator precedence bug on line 473 of `docker-compose.yml` causes `exit 0` to always execute, making the migration commands unreachable in all code paths. - **Critical: `MAIN_DOMAIN` env var in `create-site` will be empty** — line 454 uses `${main_domain}` (a template-level variable) instead of `${MAIN_DOMAIN}` (the docker-compose env var), so domain configuration during site creation will silently fail. - **Minor: Inconsistent tag casing** in `meta.json` — `"Payments"` should be lowercase to match conventions. <h3>Confidence Score: 2/5</h3> - This PR has two logic bugs that will cause runtime failures in migration and domain configuration. - The migration service will never execute its migration commands due to a shell operator precedence bug, and the `create-site` service will have an empty `MAIN_DOMAIN` variable due to incorrect variable casing. Both issues will silently fail at runtime and affect the usability of the deployed template. - Pay close attention to `blueprints/frappe/docker-compose.yml` — specifically the `migration` service (line 473) and the `create-site` service environment (line 454). <sub>Last reviewed commit: 78cbe59</sub> <!-- greptile_other_comments_section --> <!-- /greptile_comment --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 10:58:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
pull-request
Mirrored from GitHub Pull Request
 template
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/templates#1914
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?