[PR #1013] [MERGED] fix(nextcloud-aio): drop AIO branding, pin nextcloud 33.0.6 #17340

Closed
opened 2026-07-16 06:56:16 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Dokploy/templates/pull/1013
Author: @Siumauricio
Created: 7/14/2026
Status: ✅ Merged
Merged: 7/14/2026
Merged by: @Siumauricio

Base: canary ← Head: fix/nextcloud-naming


📝 Commits (1)

  • f036dda fix(nextcloud-aio): drop AIO branding, keep template id, pin nextcloud 33.0.6

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 blueprints/nextcloud-aio/docker-compose.yml (+2 -2)
📝 blueprints/nextcloud-aio/meta.json (+1 -1)

📄 Description

Problem (#133)

The nextcloud-aio template does not deploy Nextcloud All-In-One (nextcloud/all-in-one mastercontainer). It deploys the plain nextcloud image with MariaDB, Redis and a cron sidecar. Calling it "AIO" was misleading because none of the AIO tooling (mastercontainer UI, managed backups, Collabora/Talk orchestration) is present.

Options considered

  1. Rename the template folder to nextcloud — the most "honest" option, but the folder name is the template id. Changing it would break existing installs and any references to the nextcloud-aio id, and there is no functional gain: the user-facing name can be fixed without an id migration.
  2. Convert it into a real AIO deployment — rejected. The AIO mastercontainer requires mounting /var/run/docker.sock and spawns/manages its own set of containers outside the compose file. That is fundamentally incompatible with Dokploy's template model: the spawned containers would be orphans outside the compose lifecycle (no Traefik/domain integration, not stopped/removed with the service, not visible to Dokploy), and handing templates root-equivalent docker.sock access is a security non-starter.
  3. Fix the metadata while keeping the folder id — chosen. The template's meta.json display name is "Nextcloud" and the description describes standard Nextcloud, so the Dokploy UI no longer advertises AIO anywhere. The nextcloud-aio id remains only as an internal identifier, preserving backwards compatibility for existing installs.

Changes

  • Pinned nextcloud:stable -> nextcloud:33.0.6 in both the app and cron services (Docker Hub's stable tag currently resolves to the same digest as 33.0.6; pinning restores the template's original pinned-version style and makes deploys reproducible).
  • meta.json version bumped stable -> 33.0.6.
  • No AIO wording remains in name, description, links or compose (verified with a repo grep — the only remaining occurrence is the folder id itself).

Deploy evidence

Deployed on a Dokploy test instance from this branch:

  • Deploy finished in 31s, HTTP 200 on the template domain with the Nextcloud installer page.
  • GET /status.php -> {"installed":false,"maintenance":false,"needsDbUpgrade":false,"version":"33.0.6.2","versionstring":"33.0.6","productname":"Nextcloud"}
  • node build-scripts/generate-meta.js --check -> 476 templates validated.

If a real AIO template is still desired, it should be a separate discussion given the docker.sock/orphan-container constraints described above.

Closes #133

🤖 Generated with Claude Code


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Dokploy/templates/pull/1013 **Author:** [@Siumauricio](https://github.com/Siumauricio) **Created:** 7/14/2026 **Status:** ✅ Merged **Merged:** 7/14/2026 **Merged by:** [@Siumauricio](https://github.com/Siumauricio) **Base:** `canary` ← **Head:** `fix/nextcloud-naming` --- ### 📝 Commits (1) - [`f036dda`](https://github.com/Dokploy/templates/commit/f036ddae928af8c02585159a1a57443b88d7f82d) fix(nextcloud-aio): drop AIO branding, keep template id, pin nextcloud 33.0.6 ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `blueprints/nextcloud-aio/docker-compose.yml` (+2 -2) 📝 `blueprints/nextcloud-aio/meta.json` (+1 -1) </details> ### 📄 Description ## Problem (#133) The `nextcloud-aio` template does not deploy Nextcloud All-In-One (`nextcloud/all-in-one` mastercontainer). It deploys the plain `nextcloud` image with MariaDB, Redis and a cron sidecar. Calling it "AIO" was misleading because none of the AIO tooling (mastercontainer UI, managed backups, Collabora/Talk orchestration) is present. ## Options considered 1. **Rename the template folder to `nextcloud`** — the most "honest" option, but the folder name is the template id. Changing it would break existing installs and any references to the `nextcloud-aio` id, and there is no functional gain: the user-facing name can be fixed without an id migration. 2. **Convert it into a real AIO deployment** — rejected. The AIO mastercontainer requires mounting `/var/run/docker.sock` and spawns/manages its own set of containers *outside* the compose file. That is fundamentally incompatible with Dokploy's template model: the spawned containers would be orphans outside the compose lifecycle (no Traefik/domain integration, not stopped/removed with the service, not visible to Dokploy), and handing templates root-equivalent docker.sock access is a security non-starter. 3. **Fix the metadata while keeping the folder id** — chosen. The template's `meta.json` display name is `"Nextcloud"` and the description describes standard Nextcloud, so the Dokploy UI no longer advertises AIO anywhere. The `nextcloud-aio` id remains only as an internal identifier, preserving backwards compatibility for existing installs. ## Changes - Pinned `nextcloud:stable` -> `nextcloud:33.0.6` in both the app and cron services (Docker Hub's `stable` tag currently resolves to the same digest as `33.0.6`; pinning restores the template's original pinned-version style and makes deploys reproducible). - `meta.json` version bumped `stable` -> `33.0.6`. - No AIO wording remains in name, description, links or compose (verified with a repo grep — the only remaining occurrence is the folder id itself). ## Deploy evidence Deployed on a Dokploy test instance from this branch: - Deploy finished in 31s, HTTP 200 on the template domain with the Nextcloud installer page. - `GET /status.php` -> `{"installed":false,"maintenance":false,"needsDbUpgrade":false,"version":"33.0.6.2","versionstring":"33.0.6","productname":"Nextcloud"}` - `node build-scripts/generate-meta.js --check` -> 476 templates validated. If a real AIO template is still desired, it should be a separate discussion given the docker.sock/orphan-container constraints described above. Closes #133 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-07-16 06:56:16 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/templates#17340